25682 2009-05-10 20:32:24 -0700 [GTK] Expose password field with role of PASSWORD_TEXT 2009-05-20 14:37:22 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux VERIFIED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro walker.willie xan.lopez oldest_to_newest 120592 0 jdiggs 2009-05-10 20:32:24 -0700 Steps to reproduce: 1. Open the (to be) attached test case. 2. Examine the accessible associated with the password field in Accerciser. Expected results: The accessible's role would be PASSWORD_TEXT. Actual results: The accessible's role is ENTRY. Usage/Need: Screen readers such as Orca have an option to echo the keys being typed (i.e. to confirm to a user less familiar with the keyboard layout that each keypress is for the expected key). If this were to take place in a password field, the user would be announcing his/her password character by character each time he/she entered it. Therefore, it is necessary for screen readers to be able to distinguish traditional entries from password fields. 120593 1 30170 jdiggs 2009-05-10 20:33:14 -0700 Created attachment 30170 aforementioned test case 122115 2 30504 jmalonzo 2009-05-20 03:37:43 -0700 Created attachment 30504 return PASSWORD_TEXT for password fields 122118 3 30504 xan.lopez 2009-05-20 03:44:42 -0700 Comment on attachment 30504 return PASSWORD_TEXT for password fields Looks good to me. One thing to consider is why there's no equivalent role in WebCore, and whether it might sense to add one. 122121 4 jmalonzo 2009-05-20 04:19:34 -0700 (In reply to comment #3) > (From update of attachment 30504 [review]) > Looks good to me. One thing to consider is why there's no equivalent role in > WebCore, and whether it might sense to add one. > Landed in r43899 122202 5 jdiggs 2009-05-20 14:37:22 -0700 Thanks Jan. Marking as VERIFIED. 30170 2009-05-10 20:33:14 -0700 2009-05-10 20:33:14 -0700 aforementioned test case password-text.html text/html 124 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+VGVzdDwvdGl0bGU+CjwvaGVhZD4KPGJvZHk+CjxwPlBhc3N3 b3JkOiA8aW5wdXQgbmFtZT0icHciIHR5cGU9InBhc3N3b3JkIj48L2lucHV0PjwvcD4KPC9ib2R5 Pgo8L2h0bWw+Cg== 30504 2009-05-20 03:37:43 -0700 2009-05-20 03:44:42 -0700 return PASSWORD_TEXT for password fields password_text.patch text/plain 1538 jmalonzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmUzYjMwZC4uMGRlNzI5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNS0yMCAgSmFuIE1pY2hhZWwg QWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBFeHBvc2UgcGFzc3dvcmQgZmllbGQgd2l0aCBy b2xlIG9mIFBBU1NXT1JEX1RFWFQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI1NjgyCisKKyAgICAgICAgQ2hlY2sgaWYgaW5wdXQgdHlwZSBpcyBhIHBh c3N3b3JkIGZpZWxkIGFuZCByZXR1cm4KKyAgICAgICAgQVRLX1JPTEVfUEFTU1dPUkRfVEVYVCBp ZiBpdCBpcy4KKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5H RUQKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyQXRrLmNwcDoKKwogMjAwOS0wNS0xOSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBs ZS5jb20+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY4ODkyMTg+IFJFR1JFU1NJT046IFNv bWUgaUNoYXQgdHJhbnNjcmlwdCByZXNvdXJjZXMgYXJlIG5vdApkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAgYi9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNw cAppbmRleCAxYzAwNzg1Li5kM2ExZmRjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcAorKysgYi9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcApAQCAtMjY1 LDcgKzI2NSwxNSBAQCBzdGF0aWMgQXRrUm9sZSBhdGtSb2xlKEFjY2Vzc2liaWxpdHlSb2xlIHJv bGUpCiAKIHN0YXRpYyBBdGtSb2xlIHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9yb2xlKEF0a09iamVj dCogb2JqZWN0KQogewotICAgIHJldHVybiBhdGtSb2xlKGNvcmUob2JqZWN0KS0+cm9sZVZhbHVl KCkpOworICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFYT2JqZWN0ID0gY29yZShvYmplY3QpOwor CisgICAgaWYgKCFBWE9iamVjdCkKKyAgICAgICAgcmV0dXJuIEFUS19ST0xFX1VOS05PV047CisK KyAgICBpZiAoQVhPYmplY3QtPmlzUGFzc3dvcmRGaWVsZCgpKQorICAgICAgICByZXR1cm4gQVRL X1JPTEVfUEFTU1dPUkRfVEVYVDsKKworICAgIHJldHVybiBhdGtSb2xlKEFYT2JqZWN0LT5yb2xl VmFsdWUoKSk7CiB9CiAKIHN0YXRpYyB2b2lkIHNldEF0a1N0YXRlU2V0RnJvbUNvcmVPYmplY3Qo QWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCwgQXRrU3RhdGVTZXQqIHN0YXRlU2V0KQo=