25676 2009-05-10 14:14:14 -0700 Problems navigating by caret in links whose text wraps onto subsequent lines 2010-12-06 22:04:10 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 31920 25531 0 jdiggs webkit-unassigned adele alex apinheiro darin enrica mitz simon.fraser tonikitoo walker.willie xan.lopez oldest_to_newest 120577 0 jdiggs 2009-05-10 14:14:14 -0700 Steps to reproduce: 1. Open the (to be) attached test case. 2. Resize the window so that the first line ends with the word "span". 3. Position the caret to the left of the first link and use Right Arrow to move through the text of the first paragraph. Expected results: Right Arrow would continue to move the caret one character at a time. Actual results: Right Arrow works as expected until the end of the first line is reached. Pressing Right Arrow from the end of the line causes the caret to jump to the end of the link. 4. Having arrowed past the first link, use Left Arrow to move the caret one character at a time in the opposite direction. Expected results: Left Arrow would continue to move the caret one character at a time. Actual results: Left Arrow works as expected until the beginning of the second line is reached. Pressing Left Arrow from the beginning of the second line causes the caret to jump to the end of the link. Note: If you perform the above steps on the link in the second paragraph instead, things work as expected. The difference is that the second paragraph has a line break inserted at the end of "span". 120578 1 30167 jdiggs 2009-05-10 14:15:36 -0700 Created attachment 30167 aforementioned test case 154128 2 alex 2009-10-12 12:13:15 -0700 Apparently the patch in bug 13736 is causing the problem, I'll comment in that bug and try to check how to fix the problem completely. 172270 3 44967 alex 2009-12-16 05:57:22 -0800 Created attachment 44967 Proposed patch This patch fix the problem, it is another regression caused by the search ahead patch. Now I have to check how to add a test to the patch before asking for review. 172271 4 alex 2009-12-16 05:58:33 -0800 I forgot to mention you can check bug 31920 for more information about the regression. 172394 5 alex 2009-12-16 10:45:40 -0800 New dependency for this bug is the bug 32612. 172445 6 45000 alex 2009-12-16 11:56:22 -0800 Created attachment 45000 Proposed patch This patch requires the patch in the bug 32612 in order to run the test correctly. I'll not ask for review until we have that patch landed. 172707 7 45052 alex 2009-12-17 03:13:43 -0800 Created attachment 45052 Proposed patch I've decided to remove the !box condition because actually it is apparently the wrong way to check if the candidate is the last one. Not review until we have the patch of the bug 32612 in the repository. 173075 8 alex 2009-12-18 01:41:00 -0800 Now the patch with the new property have landed I've set r? and added darin to the bug so he can check it. 173771 9 jdiggs 2009-12-20 10:03:16 -0800 Just tried the patch. Awesome. Thanks so much for doing this Alex! 184961 10 xan.lopez 2010-01-26 23:18:51 -0800 This is not really GTK specific at all, changing the bug title. 186257 11 jdiggs 2010-01-31 16:02:54 -0800 It would be awesome if Alex's patch could be reviewed and committed. It's really important for users who require the ability to navigate content via the keyboard. Thanks! 186805 12 adele 2010-02-01 21:54:09 -0800 CC'ing a few more people who might feel comfortable reviewing. 186969 13 45052 darin 2010-02-02 08:18:09 -0800 Comment on attachment 45052 Proposed patch This change has no effect outside caret navigation? The function being changed is not just used in caret navigation. If the change does have other effects, then it should be straightforward to add a cross-platform test case showing that effect. 186975 14 mitz 2010-02-02 08:29:29 -0800 I was able to test on Mac OS X by adding "style='-webkit-user-modify: read-write'" to the body element. Note that just setting the contenteditable attribute will not work, because it changes the line breaking style. 187013 15 45052 darin 2010-02-02 09:50:50 -0800 Comment on attachment 45052 Proposed patch review- because this all-platforms fix needs an all-platforms test. It's fine if you want to keep the GTK-specific accessibility-based test too, but the identical test can be done based on Mitz’s suggestion in a way that will work on all platforms. 188949 16 48400 alex 2010-02-09 03:30:38 -0800 Created attachment 48400 Proposed patch I've moved the test and added the style property, it fails before the applying the patch and works after it. I've removed the a11y specific test because basically both were checking the same point. Thanks for the comments. Btw, now that I have the committer account I do not need the cq+ :) 189044 17 48400 enrica 2010-02-09 08:55:38 -0800 Comment on attachment 48400 Proposed patch > diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog > index 2d13e20..d9ea28b 100644 > --- a/LayoutTests/ChangeLog > +++ b/LayoutTests/ChangeLog > @@ -1,3 +1,16 @@ > +2010-02-09 Alejandro G. Castro <alex@igalia.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Problems navigating by caret in links whose text wraps onto > + subsequent lines. > + https://bugs.webkit.org/show_bug.cgi?id=25676 > + > + Added tests showing the problem. > + > + * fast/events/multiline-link-arrow-navigation.html > + * fast/events/multiline-link-arrow-navigation-expected.txt > + > 2010-02-09 Zoltan Herczeg <zherczeg@inf.u-szeged.hu> > > Reviewed by Oliver Hunt. > diff --git a/LayoutTests/fast/events/multiline-link-arrow-navigation-expected.txt b/LayoutTests/fast/events/multiline-link-arrow-navigation-expected.txt > new file mode 100644 > index 0000000..6681480 > --- /dev/null > +++ b/LayoutTests/fast/events/multiline-link-arrow-navigation-expected.txt > @@ -0,0 +1,3 @@ > +This is a test of links which span multiple lines for various and sundry reasons. > + > +PASS > diff --git a/LayoutTests/fast/events/multiline-link-arrow-navigation.html b/LayoutTests/fast/events/multiline-link-arrow-navigation.html > new file mode 100644 > index 0000000..83d8441 > --- /dev/null > +++ b/LayoutTests/fast/events/multiline-link-arrow-navigation.html > @@ -0,0 +1,26 @@ > +<html><head> > +<meta http-equiv="content-type" content="text/html; charset=UTF-8"> > + > +<script> > +if (window.layoutTestController) { > + layoutTestController.overridePreference("WebKitEnableCaretBrowsing", true); > + layoutTestController.dumpAsText(); > +} > + > +function runTest() > +{ > + var para = document.getElementById("para"); > + window.getSelection().setPosition(para.childNodes.item(1).childNodes.item(0), 15); > + eventSender.keyDown("rightArrow"); > + eventSender.keyDown("rightArrow"); > + > + document.getElementById("result").innerText = getSelection().baseOffset == 17 ? "PASS" : "FAIL"; > +} > +</script> > + > +<title>Test</title> > +</head><body onLoad="runTest();"> > +<p id="para" style="-webkit-user-modify: read-write; width: 250px; height: 100px; border: 1px solid blue;">This is a test of <a href="https://bug-25676-attachments.webkit.org/foo.html">links which span multiple lines</a> for various and sundry reasons.</p> > + > +<p id="result"></p> > +</body></html> > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 9fdf2cf..21487a7 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,15 @@ > +2010-02-09 Alejandro G. Castro <alex@igalia.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Problems navigating by caret in links whose text wraps onto > + subsequent lines. > + https://bugs.webkit.org/show_bug.cgi?id=25676 > + > + We should not search ahead if we are not in the last element. > + > + * dom/Position.cpp: > + > 2010-02-08 Dominic Cooney <dominicc@google.com> > > Reviewed by Adam Barth. > diff --git a/WebCore/dom/Position.cpp b/WebCore/dom/Position.cpp > index 0126835..c0f6fa3 100644 > --- a/WebCore/dom/Position.cpp > +++ b/WebCore/dom/Position.cpp > @@ -1046,7 +1046,7 @@ void Position::getInlineBoxAndOffset(EAffinity affinity, TextDirection primaryDi > > candidate = box; > } > - if (candidate && !box && affinity == DOWNSTREAM) { > + if (candidate && candidate == textRenderer->lastTextBox() && affinity == DOWNSTREAM) { > box = searchAheadForBetterMatch(textRenderer); > if (box) > caretOffset = box->caretMinOffset(); This looks good to me. I'm assuming you've run all the layout tests and found no errors. 189072 18 48400 darin 2010-02-09 10:43:07 -0800 Comment on attachment 48400 Proposed patch r=me A more thorough test case would be good to have, but this one is fine for this bug fix. 189142 19 xan.lopez 2010-02-09 13:10:56 -0800 This was committed in r54566, closing. 318058 20 48400 tonikitoo 2010-12-06 22:04:10 -0800 Comment on attachment 48400 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=48400&action=review > LayoutTests/fast/events/multiline-link-arrow-navigation.html:6 > + layoutTestController.overridePreference("WebKitEnableCaretBrowsing", true); It turns out enabling caret browsing is not need at all here, since you are using -webkit-user-modify. 1) Mac and Win does not support toggling caret browsing on/off in DRT. 2) I tested both Qt, Gtk (ports that support enabling caret browsing) and both also worked without enabling it. 3) I assume chromium port, which also support enabling caret browsing in DRT, should also work. 4) In Qt and Gtk, if I keep enabling caret browsing and removed the -webkit-user-modify style, it also worked. I propose we use the style approach only here instead of caret browsing, since it makes the test testable on all DRTs. 30167 2009-05-10 14:15:36 -0700 2009-05-10 14:15:36 -0700 aforementioned test case multiline-link-test.html text/html 295 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+VGVzdDwvdGl0bGU+CjwvaGVhZD4KPGJvZHk+CjxwPlRoaXMg aXMgYSB0ZXN0IG9mIDxhIGhyZWY9ImZvby5odG1sIj5saW5rcyB3aGljaCBzcGFuIG11bHRpcGxl IGxpbmVzPC9hPiBmb3IgdmFyaW91cyBhbmQgc3VuZHJ5IHJlYXNvbnMuPC9wPgo8cD5UaGlzIGlz IGEgdGVzdCBvZiA8YSBocmVmPSJmb28uaHRtbCI+bGlua3Mgd2hpY2ggc3BhbjxiciAvPiBtdWx0 aXBsZSBsaW5lczwvYT4gZm9yIHZhcmlvdXMgYW5kIHN1bmRyeSByZWFzb25zLjwvcD4KPC9ib2R5 Pgo8L2h0bWw+Cg== 44967 2009-12-16 05:57:22 -0800 2009-12-16 11:56:22 -0800 Proposed patch avoid_searchAhead.patch text/plain 603 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0 aW9uLmNwcAppbmRleCAwZmY4MjYyLi5kNTU3ZTFiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Q b3NpdGlvbi5jcHAKKysrIGIvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCkBAIC0xMDM1LDcgKzEw MzUsNyBAQCB2b2lkIFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZzZXQoRUFmZmluaXR5IGFm ZmluaXR5LCBUZXh0RGlyZWN0aW9uIHByaW1hcnlEaQogCiAgICAgICAgICAgICBjYW5kaWRhdGUg PSBib3g7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKGNhbmRpZGF0ZSAmJiAhYm94ICYmIGFmZmlu aXR5ID09IERPV05TVFJFQU0pIHsKKyAgICAgICAgaWYgKGNhbmRpZGF0ZSAmJiAhYm94ICYmIGFm ZmluaXR5ID09IERPV05TVFJFQU0gJiYgY2FuZGlkYXRlID09IHRleHRSZW5kZXJlci0+bGFzdFRl eHRCb3goKSkgewogICAgICAgICAgICAgYm94ID0gc2VhcmNoQWhlYWRGb3JCZXR0ZXJNYXRjaCh0 ZXh0UmVuZGVyZXIpOwogICAgICAgICAgICAgaWYgKGJveCkKICAgICAgICAgICAgICAgICBjYXJl dE9mZnNldCA9IGJveC0+Y2FyZXRNaW5PZmZzZXQoKTsK 45000 2009-12-16 11:56:22 -0800 2009-12-17 03:13:43 -0800 Proposed patch caret_browsing.patch text/plain 3470 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkYTgyMjU5Li4wZDhmYTlhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MTYgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvYmxlbXMgbmF2aWdhdGluZyBi eSBjYXJldCBpbiBsaW5rcyB3aG9zZSB0ZXh0IHdyYXBzIG9udG8KKyAgICAgICAgc3Vic2VxdWVu dCBsaW5lcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI1Njc2CisKKyAgICAgICAgQWRkZWQgdGVzdHMgc2hvd2luZyB0aGUgcHJvYmxlbS4KKworICAg ICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L211bHRpbGluZS1saW5rLXRlc3QtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L211bHRpbGlu ZS1saW5rLXRlc3QuaHRtbDoKKwogMjAwOS0xMi0xMyAgUm9sYW5kIFN0ZWluZXIgIDxyb2xhbmRz dGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbXVsdGls aW5lLWxpbmstdGVzdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNj ZXNzaWJpbGl0eS9tdWx0aWxpbmUtbGluay10ZXN0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi42NjgxNDgwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbXVsdGlsaW5lLWxpbmstdGVzdC1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitUaGlzIGlzIGEgdGVzdCBvZiBsaW5rcyB3aGljaCBz cGFuIG11bHRpcGxlIGxpbmVzIGZvciB2YXJpb3VzIGFuZCBzdW5kcnkgcmVhc29ucy4KKworUEFT UwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbXVs dGlsaW5lLWxpbmstdGVzdC5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2li aWxpdHkvbXVsdGlsaW5lLWxpbmstdGVzdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLjM0MzBjY2UKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvYWNjZXNzaWJpbGl0eS9tdWx0aWxpbmUtbGluay10ZXN0Lmh0bWwKQEAgLTAsMCArMSwy NiBAQAorPGh0bWw+PGhlYWQ+Cis8bWV0YSBodHRwLWVxdWl2PSJjb250ZW50LXR5cGUiIGNvbnRl bnQ9InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCI+CisKKzxzY3JpcHQ+CitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZW5hYmxlQ2Fy ZXRCcm93c2luZygpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30K KworZnVuY3Rpb24gcnVuVGVzdCgpCit7CisgICAgdmFyIHBhcmEgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgicGFyYSIpOworICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihw YXJhLmNoaWxkTm9kZXMuaXRlbSgxKS5jaGlsZE5vZGVzLml0ZW0oMCksIDE1KTsKKyAgICBldmVu dFNlbmRlci5rZXlEb3duKCJyaWdodEFycm93Iik7CisgICAgZXZlbnRTZW5kZXIua2V5RG93bigi cmlnaHRBcnJvdyIpOworCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlu bmVyVGV4dCA9IGdldFNlbGVjdGlvbigpLmJhc2VPZmZzZXQgPT0gMTcgPyAiUEFTUyIgOiAiRkFJ TCI7Cit9Cis8L3NjcmlwdD4KKworPHRpdGxlPlRlc3Q8L3RpdGxlPgorPC9oZWFkPjxib2R5IG9u TG9hZD0icnVuVGVzdCgpOyI+Cis8cCBpZD0icGFyYSIgc3R5bGU9IndpZHRoOiAyNTBweDsgaGVp Z2h0OiAxMDBweDsgYm9yZGVyOiAxcHggc29saWQgYmx1ZTsiPlRoaXMgaXMgYSB0ZXN0IG9mIDxh IGhyZWY9Imh0dHBzOi8vYnVnLTI1Njc2LWF0dGFjaG1lbnRzLndlYmtpdC5vcmcvZm9vLmh0bWwi PmxpbmtzIHdoaWNoIHNwYW4gbXVsdGlwbGUgbGluZXM8L2E+IGZvciB2YXJpb3VzIGFuZCBzdW5k cnkgcmVhc29ucy48L3A+CisKKzxwIGlkPSJyZXN1bHQiPjwvcD4KKzwvYm9keT48L2h0bWw+CmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU2 YTJhNGIuLjg4NTgzMWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMTYgIEFsZWphbmRybyBHLiBD YXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUHJvYmxlbXMgbmF2aWdhdGluZyBieSBjYXJldCBpbiBsaW5rcyB3 aG9zZSB0ZXh0IHdyYXBzIG9udG8KKyAgICAgICAgc3Vic2VxdWVudCBsaW5lcy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1Njc2CisKKyAgICAgICAg V2Ugc2hvdWxkIG5vdCBzZWFyY2ggYWhlYWQgaWYgd2UgYXJlIG5vdCBpbiB0aGUgbGFzdCBlbGVt ZW50LgorCisgICAgICAgICogZG9tL1Bvc2l0aW9uLmNwcDoKKwogMjAwOS0xMi0xMyAgUm9sYW5k IFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwIGIv V2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCmluZGV4IDBmZjgyNjIuLmQ1NTdlMWIgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5j cHAKQEAgLTEwMzUsNyArMTAzNSw3IEBAIHZvaWQgUG9zaXRpb246OmdldElubGluZUJveEFuZE9m ZnNldChFQWZmaW5pdHkgYWZmaW5pdHksIFRleHREaXJlY3Rpb24gcHJpbWFyeURpCiAKICAgICAg ICAgICAgIGNhbmRpZGF0ZSA9IGJveDsKICAgICAgICAgfQotICAgICAgICBpZiAoY2FuZGlkYXRl ICYmICFib3ggJiYgYWZmaW5pdHkgPT0gRE9XTlNUUkVBTSkgeworICAgICAgICBpZiAoY2FuZGlk YXRlICYmICFib3ggJiYgYWZmaW5pdHkgPT0gRE9XTlNUUkVBTSAmJiBjYW5kaWRhdGUgPT0gdGV4 dFJlbmRlcmVyLT5sYXN0VGV4dEJveCgpKSB7CiAgICAgICAgICAgICBib3ggPSBzZWFyY2hBaGVh ZEZvckJldHRlck1hdGNoKHRleHRSZW5kZXJlcik7CiAgICAgICAgICAgICBpZiAoYm94KQogICAg ICAgICAgICAgICAgIGNhcmV0T2Zmc2V0ID0gYm94LT5jYXJldE1pbk9mZnNldCgpOwo= 45052 2009-12-17 03:13:43 -0800 2010-02-09 03:30:38 -0800 Proposed patch caret_browsing.patch text/plain 3551 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYTIyOThmLi42MDY0MWRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MTYgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvYmxlbXMgbmF2aWdhdGluZyBi eSBjYXJldCBpbiBsaW5rcyB3aG9zZSB0ZXh0IHdyYXBzIG9udG8KKyAgICAgICAgc3Vic2VxdWVu dCBsaW5lcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI1Njc2CisKKyAgICAgICAgQWRkZWQgdGVzdHMgc2hvd2luZyB0aGUgcHJvYmxlbS4KKworICAg ICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L211bHRpbGluZS1saW5rLXRlc3QtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L211bHRpbGlu ZS1saW5rLXRlc3QuaHRtbDoKKwogMjAwOS0xMi0xNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gUHV0IHRlc3QgaW50byBza2lwbGlzdCBiZWNh dXNlIG9mIG1pc3NpbmcgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0U21hcnRJbnNlcnREZWxldGVF bmFibGVkKCkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJp bGl0eS9tdWx0aWxpbmUtbGluay10ZXN0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9hY2Nlc3NpYmlsaXR5L211bHRpbGluZS1saW5rLXRlc3QtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjY2ODE0ODAKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9tdWx0aWxpbmUtbGlu ay10ZXN0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1RoaXMgaXMgYSB0ZXN0IG9mIGxp bmtzIHdoaWNoIHNwYW4gbXVsdGlwbGUgbGluZXMgZm9yIHZhcmlvdXMgYW5kIHN1bmRyeSByZWFz b25zLgorCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNz aWJpbGl0eS9tdWx0aWxpbmUtbGluay10ZXN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvYWNjZXNzaWJpbGl0eS9tdWx0aWxpbmUtbGluay10ZXN0Lmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMC4uNDYzNzc3NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L211bHRpbGluZS1saW5rLXRlc3QuaHRtbApA QCAtMCwwICsxLDI2IEBACis8aHRtbD48aGVhZD4KKzxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQt dHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PVVURi04Ij4KKworPHNjcmlwdD4KK2lm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5vdmVycmlkZVByZWZlcmVuY2UoIldlYktpdEVuYWJsZUNhcmV0QnJvd3NpbmciLCB0cnVlKTsK KyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit9CisKK2Z1bmN0aW9uIHJ1 blRlc3QoKQoreworICAgIHZhciBwYXJhID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInBhcmEi KTsKKyAgICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24ocGFyYS5jaGlsZE5vZGVz Lml0ZW0oMSkuY2hpbGROb2Rlcy5pdGVtKDApLCAxNSk7CisgICAgZXZlbnRTZW5kZXIua2V5RG93 bigicmlnaHRBcnJvdyIpOworICAgIGV2ZW50U2VuZGVyLmtleURvd24oInJpZ2h0QXJyb3ciKTsK KworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lclRleHQgPSBnZXRT ZWxlY3Rpb24oKS5iYXNlT2Zmc2V0ID09IDE3ID8gIlBBU1MiIDogIkZBSUwiOworfQorPC9zY3Jp cHQ+CisKKzx0aXRsZT5UZXN0PC90aXRsZT4KKzwvaGVhZD48Ym9keSBvbkxvYWQ9InJ1blRlc3Qo KTsiPgorPHAgaWQ9InBhcmEiIHN0eWxlPSJ3aWR0aDogMjUwcHg7IGhlaWdodDogMTAwcHg7IGJv cmRlcjogMXB4IHNvbGlkIGJsdWU7Ij5UaGlzIGlzIGEgdGVzdCBvZiA8YSBocmVmPSJodHRwczov L2J1Zy0yNTY3Ni1hdHRhY2htZW50cy53ZWJraXQub3JnL2Zvby5odG1sIj5saW5rcyB3aGljaCBz cGFuIG11bHRpcGxlIGxpbmVzPC9hPiBmb3IgdmFyaW91cyBhbmQgc3VuZHJ5IHJlYXNvbnMuPC9w PgorCis8cCBpZD0icmVzdWx0Ij48L3A+Cis8L2JvZHk+PC9odG1sPgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmNDNmNGQwLi4zMTIwODg4 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDA5LTEyLTE2ICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBp Z2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByb2JsZW1zIG5hdmlnYXRpbmcgYnkgY2FyZXQgaW4gbGlua3Mgd2hvc2UgdGV4dCB3cmFw cyBvbnRvCisgICAgICAgIHN1YnNlcXVlbnQgbGluZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTY3NgorCisgICAgICAgIFdlIHNob3VsZCBub3Qg c2VhcmNoIGFoZWFkIGlmIHdlIGFyZSBub3QgaW4gdGhlIGxhc3QgZWxlbWVudC4KKworICAgICAg ICAqIGRvbS9Qb3NpdGlvbi5jcHA6CisKIDIwMDktMTItMTUgTU9SSVRBIEhhamltZSA8bW9ycml0 YUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAK aW5kZXggYzgzOTY1Yi4uZDNjMGMwMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vUG9zaXRpb24u Y3BwCisrKyBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcApAQCAtMTAzNSw3ICsxMDM1LDcgQEAg dm9pZCBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KEVBZmZpbml0eSBhZmZpbml0eSwg VGV4dERpcmVjdGlvbiBwcmltYXJ5RGkKIAogICAgICAgICAgICAgY2FuZGlkYXRlID0gYm94Owog ICAgICAgICB9Ci0gICAgICAgIGlmIChjYW5kaWRhdGUgJiYgIWJveCAmJiBhZmZpbml0eSA9PSBE T1dOU1RSRUFNKSB7CisgICAgICAgIGlmIChjYW5kaWRhdGUgJiYgY2FuZGlkYXRlID09IHRleHRS ZW5kZXJlci0+bGFzdFRleHRCb3goKSAmJiBhZmZpbml0eSA9PSBET1dOU1RSRUFNKSB7CiAgICAg ICAgICAgICBib3ggPSBzZWFyY2hBaGVhZEZvckJldHRlck1hdGNoKHRleHRSZW5kZXJlcik7CiAg ICAgICAgICAgICBpZiAoYm94KQogICAgICAgICAgICAgICAgIGNhcmV0T2Zmc2V0ID0gYm94LT5j YXJldE1pbk9mZnNldCgpOwo= 48400 2010-02-09 03:30:38 -0800 2010-12-06 22:04:09 -0800 Proposed patch multiline-link-arrow-navigation.patch text/plain 3493 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyZDEzZTIwLi5kOWVhMjhiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDIt MDkgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvYmxlbXMgbmF2aWdhdGluZyBi eSBjYXJldCBpbiBsaW5rcyB3aG9zZSB0ZXh0IHdyYXBzIG9udG8KKyAgICAgICAgc3Vic2VxdWVu dCBsaW5lcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI1Njc2CisKKyAgICAgICAgQWRkZWQgdGVzdHMgc2hvd2luZyB0aGUgcHJvYmxlbS4KKworICAg ICAgICAqIGZhc3QvZXZlbnRzL211bHRpbGluZS1saW5rLWFycm93LW5hdmlnYXRpb24uaHRtbAor ICAgICAgICAqIGZhc3QvZXZlbnRzL211bHRpbGluZS1saW5rLWFycm93LW5hdmlnYXRpb24tZXhw ZWN0ZWQudHh0CisKIDIwMTAtMDItMDkgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAaW5mLnUt c3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbXVsdGlsaW5lLWxpbmstYXJyb3ctbmF2aWdhdGlv bi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tdWx0aWxpbmUtbGluay1h cnJvdy1uYXZpZ2F0aW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi42NjgxNDgwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvbXVsdGlsaW5lLWxpbmstYXJyb3ctbmF2aWdhdGlvbi1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwzIEBACitUaGlzIGlzIGEgdGVzdCBvZiBsaW5rcyB3aGljaCBzcGFuIG11bHRpcGxlIGxpbmVz IGZvciB2YXJpb3VzIGFuZCBzdW5kcnkgcmVhc29ucy4KKworUEFTUwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvbXVsdGlsaW5lLWxpbmstYXJyb3ctbmF2aWdhdGlvbi5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbXVsdGlsaW5lLWxpbmstYXJyb3ctbmF2aWdhdGlv bi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjgzZDg0NDEKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tdWx0aWxpbmUtbGluay1hcnJv dy1uYXZpZ2F0aW9uLmh0bWwKQEAgLTAsMCArMSwyNiBAQAorPGh0bWw+PGhlYWQ+Cis8bWV0YSBo dHRwLWVxdWl2PSJjb250ZW50LXR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD1VVEYt OCI+CisKKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXRFbmFibGVDYXJl dEJyb3dzaW5nIiwgdHJ1ZSk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgp OworfQorCitmdW5jdGlvbiBydW5UZXN0KCkKK3sKKyAgICB2YXIgcGFyYSA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJwYXJhIik7CisgICAgd2luZG93LmdldFNlbGVjdGlvbigpLnNldFBvc2l0 aW9uKHBhcmEuY2hpbGROb2Rlcy5pdGVtKDEpLmNoaWxkTm9kZXMuaXRlbSgwKSwgMTUpOworICAg IGV2ZW50U2VuZGVyLmtleURvd24oInJpZ2h0QXJyb3ciKTsKKyAgICBldmVudFNlbmRlci5rZXlE b3duKCJyaWdodEFycm93Iik7CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0 IikuaW5uZXJUZXh0ID0gZ2V0U2VsZWN0aW9uKCkuYmFzZU9mZnNldCA9PSAxNyA/ICJQQVNTIiA6 ICJGQUlMIjsKK30KKzwvc2NyaXB0PgorCis8dGl0bGU+VGVzdDwvdGl0bGU+Cis8L2hlYWQ+PGJv ZHkgb25Mb2FkPSJydW5UZXN0KCk7Ij4KKzxwIGlkPSJwYXJhIiBzdHlsZT0iLXdlYmtpdC11c2Vy LW1vZGlmeTogcmVhZC13cml0ZTsgd2lkdGg6IDI1MHB4OyBoZWlnaHQ6IDEwMHB4OyBib3JkZXI6 IDFweCBzb2xpZCBibHVlOyI+VGhpcyBpcyBhIHRlc3Qgb2YgPGEgaHJlZj0iaHR0cHM6Ly9idWct MjU2NzYtYXR0YWNobWVudHMud2Via2l0Lm9yZy9mb28uaHRtbCI+bGlua3Mgd2hpY2ggc3BhbiBt dWx0aXBsZSBsaW5lczwvYT4gZm9yIHZhcmlvdXMgYW5kIHN1bmRyeSByZWFzb25zLjwvcD4KKwor PHAgaWQ9InJlc3VsdCI+PC9wPgorPC9ib2R5PjwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWZkZjJjZi4uMjE0ODdhNyAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMC0wMi0wOSAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ cm9ibGVtcyBuYXZpZ2F0aW5nIGJ5IGNhcmV0IGluIGxpbmtzIHdob3NlIHRleHQgd3JhcHMgb250 bworICAgICAgICBzdWJzZXF1ZW50IGxpbmVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU2NzYKKworICAgICAgICBXZSBzaG91bGQgbm90IHNlYXJj aCBhaGVhZCBpZiB3ZSBhcmUgbm90IGluIHRoZSBsYXN0IGVsZW1lbnQuCisKKyAgICAgICAgKiBk b20vUG9zaXRpb24uY3BwOgorCiAyMDEwLTAyLTA4ICBEb21pbmljIENvb25leSAgPGRvbWluaWNj QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcApp bmRleCAwMTI2ODM1Li5jMGY2ZmEzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5j cHAKKysrIGIvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCkBAIC0xMDQ2LDcgKzEwNDYsNyBAQCB2 b2lkIFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZzZXQoRUFmZmluaXR5IGFmZmluaXR5LCBU ZXh0RGlyZWN0aW9uIHByaW1hcnlEaQogCiAgICAgICAgICAgICBjYW5kaWRhdGUgPSBib3g7CiAg ICAgICAgIH0KLSAgICAgICAgaWYgKGNhbmRpZGF0ZSAmJiAhYm94ICYmIGFmZmluaXR5ID09IERP V05TVFJFQU0pIHsKKyAgICAgICAgaWYgKGNhbmRpZGF0ZSAmJiBjYW5kaWRhdGUgPT0gdGV4dFJl bmRlcmVyLT5sYXN0VGV4dEJveCgpICYmIGFmZmluaXR5ID09IERPV05TVFJFQU0pIHsKICAgICAg ICAgICAgIGJveCA9IHNlYXJjaEFoZWFkRm9yQmV0dGVyTWF0Y2godGV4dFJlbmRlcmVyKTsKICAg ICAgICAgICAgIGlmIChib3gpCiAgICAgICAgICAgICAgICAgY2FyZXRPZmZzZXQgPSBib3gtPmNh cmV0TWluT2Zmc2V0KCk7Cg==