25671 2009-05-10 11:42:40 -0700 [GTK] Implement support for set_caret_offset 2009-06-10 16:26:59 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux VERIFIED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro walker.willie xan.lopez oldest_to_newest 120562 0 jdiggs 2009-05-10 11:42:40 -0700 The accessible text interface includes a method which ATs can use to (re)position the caret as needed. For more information please see http://library.gnome.org/devel/atk/unstable/AtkText.html#atk-text-set-caret-offset. Usage/need example: Screen reader users who have a refreshable braille display often review the text on the screen by panning/scrolling their display. If while doing so, they spot some text they wish to select, edit, whathaveyou, they can press a "cursor routing key" on their display. The AT in turn needs to use set_caret_offset to reposition the caret at the desired location. 124950 1 31095 xan.lopez 2009-06-09 08:38:27 -0700 Created attachment 31095 setcaretoffset.patch Implement the function. 125157 2 31095 gustavo 2009-06-10 10:22:50 -0700 Comment on attachment 31095 setcaretoffset.patch r=me 125161 3 xan.lopez 2009-06-10 10:28:55 -0700 Landed as r44571, closing as FIXED. 125232 4 jdiggs 2009-06-10 16:26:59 -0700 This seems to work quite nicely. Thanks! Marking as VERIFIED. 31095 2009-06-09 08:38:27 -0700 2009-06-10 10:22:50 -0700 setcaretoffset.patch setcaretoffset.patch text/plain 2683 xan.lopez RnJvbSA5NmQ1MDIzY2RmN2VlMTI1ZDhhZTAzZTA1ODU2N2UzYTkxNWUzZmM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBU dWUsIDkgSnVuIDIwMDkgMTg6Mzc6MDAgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTA2LTA5 ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNTY3MQogICAgICAgIFtHVEtdIEltcGxlbWVudCBzdXBwb3J0IGZvciBzZXRfY2FyZXRf b2Zmc2V0CgogICAgICAgIE1ha2UgYW4gaW1wbGVtZW50YXRpb24gdGhhdCBhY3R1YWxseSB3b3Jr cy4KCiAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHA6CiAgICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxlX3RleHRfc2V0X2NhcmV0X29mZnNl dCk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQs IDIzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0NDBmMmU1Li4zZDM5NTVjIDEwMDY0 NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDA5LTA2LTA5ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU2NzEKKyAgICAgICAgW0dUS10gSW1wbGVt ZW50IHN1cHBvcnQgZm9yIHNldF9jYXJldF9vZmZzZXQKKworICAgICAgICBNYWtlIGFuIGltcGxl bWVudGF0aW9uIHRoYXQgYWN0dWFsbHkgd29ya3MuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5 L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRf YWNjZXNzaWJsZV90ZXh0X3NldF9jYXJldF9vZmZzZXQpOgorCiAyMDA5LTA2LTA4ICBYYW4gTG9w ZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJBdGsuY3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3Np YmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKaW5kZXggZjNjODNiNC4uYzI4NWNiNCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHAKKysrIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlckF0ay5jcHAKQEAgLTYzNiwxMCArNjM2LDE4IEBAIHN0YXRpYyBnYm9vbGVhbiB3 ZWJraXRfYWNjZXNzaWJsZV90ZXh0X3NldF9zZWxlY3Rpb24oQXRrVGV4dCogdGV4dCwgZ2ludCBz ZWxlY3RpCiAKIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfYWNjZXNzaWJsZV90ZXh0X3NldF9jYXJl dF9vZmZzZXQoQXRrVGV4dCogdGV4dCwgZ2ludCBvZmZzZXQpCiB7Ci0gICAgLy8gVE9ETzogVmVy aWZ5Ci0gICAgLy9jb3JlKHRleHQpLT5zZXRTZWxlY3RlZFRleHRSYW5nZShQbGFpblRleHRSYW5n ZShvZmZzZXQsIDApKTsKICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0ID0gY29y ZSh0ZXh0KTsKLSAgICBjb3JlT2JqZWN0LT5zZXRTZWxlY3RlZFZpc2libGVQb3NpdGlvblJhbmdl KGNvcmVPYmplY3QtPnZpc2libGVQb3NpdGlvblJhbmdlRm9yUmFuZ2UoUGxhaW5UZXh0UmFuZ2Uo b2Zmc2V0LCAwKSkpOworCisgICAgLy8gRklYTUU6IFdlIG5lZWQgdG8gcmVpbXBsZW1lbnQgdmlz aWJsZVBvc2l0aW9uUmFuZ2VGb3JSYW5nZSBoZXJlCisgICAgLy8gYmVjYXVzZSB0aGUgYWN0dWFs IGZ1bmN0aW9uIGNoZWNrcyB0aGUgb2Zmc2V0IGlzIHdpdGhpbiB0aGUKKyAgICAvLyBib3VuZGFy aWVzIG9mIHRleHQoKS5sZW5ndGgoKSwgYnV0IHRleHQoKSBvbmx5IHdvcmtzIGZvciB0ZXh0Cisg ICAgLy8gY29udHJvbHMuLi4KKyAgICBWaXNpYmxlUG9zaXRpb24gc3RhcnRQb3NpdGlvbiA9IGNv cmVPYmplY3QtPnZpc2libGVQb3NpdGlvbkZvckluZGV4KG9mZnNldCk7CisgICAgc3RhcnRQb3Np dGlvbi5zZXRBZmZpbml0eShET1dOU1RSRUFNKTsKKyAgICBWaXNpYmxlUG9zaXRpb24gZW5kUG9z aXRpb24gPSBjb3JlT2JqZWN0LT52aXNpYmxlUG9zaXRpb25Gb3JJbmRleChvZmZzZXQpOworICAg IFZpc2libGVQb3NpdGlvblJhbmdlIHJhbmdlID0gVmlzaWJsZVBvc2l0aW9uUmFuZ2Uoc3RhcnRQ b3NpdGlvbiwgZW5kUG9zaXRpb24pOworCisgICAgY29yZU9iamVjdC0+c2V0U2VsZWN0ZWRWaXNp YmxlUG9zaXRpb25SYW5nZShyYW5nZSk7CiAgICAgcmV0dXJuIFRSVUU7CiB9CiAKLS0gCjEuNi4z LjEKCg==