256535 2023-05-09 11:18:37 -0700 [GPU Process][Filters] Top level SVGFilter should own its FilterResults 2023-05-11 18:50:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 232845 1 sabouhallawa sabouhallawa bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1954085 0 sabouhallawa 2023-05-09 11:18:37 -0700 This will allow caching the FilterResults along with the SVGFilter in RemoteResourceCache. The solution has to consider the following cases for the SVGFilter & FilterResults: a. SVGFilter is created in WebProcess: 1. Rendering in WebProcess: i. Top level SVGFilter: SVGFilter creates its FilterResults. SVGFilter caches its FilterResults (will be implemented by this bug). ii. Referenced SVGFilter: SVGFilter should not create FilterResults. 2. Rendering in GPUProcess: i. Top level SVGFilter: SVGFilter should not create FilterResults (will be fixed by this bug). ii. Referenced SVGFilter: SVGFilter should not create FilterResults. b. SVGFilter is created in GPUProcess: 1. Rendering in GPUProcess: i. Top level SVGFilter: SVGFilter creates its FilterResults (Memory has to be attributed to WebProcess). SVGFilter caches its FilterResults (will be implemented in another bug). ii. Referenced SVGFilter: SVGFilter should not create FilterResults. To do that GraphicsContext::drawFilteredImageBuffer() has to take FilterResultsEnsurer which returns FilterResults&. drawFilteredImageBuffer() will call it only when the FilterResults is needed. SVGFilter::ensureResults() will return FilterResults& and it takes FilterResultsCreator. FilterResultsCreator will return a std::unique_ptr<FilterResults> which SVGFilter will maintain. 1954086 1 webkit-bug-importer 2023-05-09 11:19:25 -0700 <rdar://problem/109107572> 1954094 2 sabouhallawa 2023-05-09 11:45:30 -0700 Pull request: https://github.com/apple/WebKit/pull/587 1954124 3 sabouhallawa 2023-05-09 13:46:42 -0700 Pull request: https://github.com/WebKit/WebKit/pull/13652 1954211 4 sabouhallawa 2023-05-09 18:22:20 -0700 Pull request: https://github.com/WebKit/WebKit/pull/13676 1954880 5 ews-feeder 2023-05-11 18:50:44 -0700 Committed 263996@main (b860110f0ae4): <https://commits.webkit.org/263996@main> Reviewed commits have been landed. Closing PR #13676 and removing active labels.