256525 2023-05-09 08:48:47 -0700 Clamp frameset cols/rows values safely to integers for absolute & percentage 2023-07-19 13:34:03 -0700 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=256764 BrowserCompat, InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 webkit-unassigned simon.fraser webkit-bug-importer zalan oldest_to_newest 1954043 0 ahmad.saleem792 2023-05-09 08:48:47 -0700 Hi Team, While looking at 'frameset' failure, I came across another Blink commit, which can lead to passes on WPT: Failing WPT Tests: https://wpt.fyi/results/html/rendering/non-replaced-elements/the-frameset-and-frame-elements?label=master&label=experimental&aligned=&q=frameset large-cols-abssize.html large-cols-percentage.html large-cols-relsize.html large-rows-abssize.html large-rows-percentage.html large-rows-relsize.html Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/7091ff7be362763203b68fb09f48898258df0c37 WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFrameSet.cpp#186 Just wanted to raise, so this can be fixed. I tried locally to do clampTo<int> but these tests still fail, so it might be not my expertise area. Thanks! 1955672 1 webkit-bug-importer 2023-05-16 08:49:25 -0700 <rdar://problem/109407606> 1967391 2 ahmad.saleem792 2023-07-19 13:34:03 -0700 For some reason, it does not lead to progressions on GTK-WK2 and WPE-WK2. I am closing my PR. PR - https://github.com/WebKit/WebKit/pull/13858 But anyone from GTK-WK2 team, who can help in investigating the failures?