256428 2023-05-07 03:13:52 -0700 [GStreamer][MSE] Decoder sometimes receives caps event before stream-start 2024-04-19 06:22:42 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 philn philn bugs-noreply cadubentzen mcatanzaro webkit-bug-importer oldest_to_newest 1953492 0 philn 2023-05-07 03:13:52 -0700 And that triggers a crash in the recently added player codecProbe. operator():<MSE-media-player-5> Setting codec for stream (null) to avc1.64002A Reproduces flakily on release builds (wasn't able to reproduce this on debug) when loading https://interbrand.com/ For now I'll add a workaround/warning. This codec probe is not critically important, but there's a bug to dive in here, caps events should not reach a pad before stream-start. 1953493 1 pnormand 2023-05-07 03:19:01 -0700 Pull request: https://github.com/WebKit/WebKit/pull/13548 1953640 2 ews-feeder 2023-05-08 04:30:19 -0700 Committed 263791@main (c49bd915d945): <https://commits.webkit.org/263791@main> Reviewed commits have been landed. Closing PR #13548 and removing active labels. 1953641 3 webkit-bug-importer 2023-05-08 04:31:21 -0700 <rdar://problem/109034676> 1953642 4 philn 2023-05-08 04:40:01 -0700 This needs a proper patch... 1958032 5 mcatanzaro 2023-05-25 14:34:22 -0700 (This was on the backport list for 2.40, but it depends on 263585@main which has many conflicts, so I decided not to cherry-pick it.) 2006342 6 philn 2024-01-20 04:40:18 -0800 (In reply to Philippe Normand from comment #4) > This needs a proper patch... This works now, I can't trigger the warning anymore... 2029793 7 cadubentzen 2024-04-19 06:22:42 -0700 (In reply to Philippe Normand from comment #6) > (In reply to Philippe Normand from comment #4) > > This needs a proper patch... > > This works now, I can't trigger the warning anymore... I can trigger this 100% of the time with media/media-source/media-source-abort-resets-parser.html in release mode (the test times out due to a deadlock as well, fwiw). I'm working on fixing to that test, and with my current WIP solution, this warning also goes away. But the fix isn't quite ready to be merged yet. (bug 272975)