256422 2023-05-06 18:34:52 -0700 [SameObject] missing from few SVG IDL files 2024-03-18 15:42:56 -0700 1 1 1 Unclassified WebKit DOM Safari Technology Preview Unspecified Unspecified NEW InRadar P2 Normal --- 163414 1 ahmad.saleem792 webkit-unassigned cdumez karlcow rniwa sabouhallawa webkit-bug-importer oldest_to_newest 1953451 0 ahmad.saleem792 2023-05-06 18:34:52 -0700 Hi Team, While going through few files, I noticed that the [SameObject] is missing from following: * Source/WebCore/svg/SVGAnimatedLengthList.idl: It should be: [SameObject] readonly attribute SVGLengthList baseVal; [SameObject] readonly attribute SVGLengthList animVal; As per spec: https://svgwg.org/svg2-draft/types.html#InterfaceSVGAnimatedLengthList * Source/WebCore/svg/SVGAnimatedNumberList.idl: [SameObject] readonly attribute SVGNumberList baseVal; [SameObject] readonly attribute SVGNumberList animVal; As per spec: https://svgwg.org/svg2-draft/types.html#InterfaceSVGAnimatedNumberList * Source/WebCore/svg/SVGAnimatedRect.idl: [SameObject] readonly attribute SVGRect baseVal; [SameObject] readonly attribute SVGRect animVal; https://svgwg.org/svg2-draft/types.html#InterfaceSVGAnimatedRect ^ As per spec, it should be DOMRec and DOMRectReadOnly as well. * Source/WebCore/svg/SVGImageElement.idl: [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; [SameObject] readonly attribute SVGAnimatedPreserveAspectRatio preserveAspectRatio; As per spec - https://svgwg.org/svg2-draft/embedded.html#InterfaceSVGImageElement _______ There might be more cases but just highlighting few examples. Thanks! 1953459 1 cdumez 2023-05-06 19:15:50 -0700 FYI, SameObject in the IDL in WebKit has no effect. Implementing the behavior of SameObject is actually involves either using [CachedAttribute] or a custom JS bindings visitor function. 1953460 2 ahmad.saleem792 2023-05-06 19:16:46 -0700 (In reply to Chris Dumez from comment #1) > FYI, SameObject in the IDL in WebKit has no effect. Implementing the > behavior of SameObject is actually involves either using [CachedAttribute] > or a custom JS bindings visitor function. So then is it Invalid bug? 1953464 3 cdumez 2023-05-06 20:30:57 -0700 (In reply to Ahmad Saleem from comment #2) > (In reply to Chris Dumez from comment #1) > > FYI, SameObject in the IDL in WebKit has no effect. Implementing the > > behavior of SameObject is actually involves either using [CachedAttribute] > > or a custom JS bindings visitor function. > > So then is it Invalid bug? No necessarily, we would have to write tests to verify if those attributes always return the same object or not. 1955277 4 webkit-bug-importer 2023-05-13 18:35:19 -0700 <rdar://problem/109311723>