256136 2023-04-29 13:57:47 -0700 Features specific to other ports should not be compiled in 2023-05-03 13:27:24 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=255518 InRadar P2 Normal --- 1 aperez aperez bugs-noreply cgarcia webkit-bug-importer oldest_to_newest 1952033 0 aperez 2023-04-29 13:57:47 -0700 After bug #255518 I have noticed that some of the features which end up in the built code do not make any sense for the GLib ports. For example: AcceleratedDrawingEnabled: type: bool status: internal defaultsOverridable: true humanReadableName: "GraphicsLayerCA accelerated drawing" humanReadableDescription: "Enable GraphicsLayerCA accelerated drawing" ... The above feature is specific to the Apple ports, as none of WPE, GTK, WinCairo, or PlayStation can use CoreAnimation. It would be good to go over the list in UnifiedWebPreferences.yaml and add missing conditions for such cases; e.g. in the example above we need to add: condition: USE(CA) 1952201 1 aperez 2023-05-01 12:57:41 -0700 (In reply to Adrian Perez from comment #0) > After bug #255518 I have noticed that some of the features which end > up in the built code do not make any sense for the GLib ports. For > example: > > AcceleratedDrawingEnabled: > type: bool > status: internal > defaultsOverridable: true > humanReadableName: "GraphicsLayerCA accelerated drawing" > humanReadableDescription: "Enable GraphicsLayerCA accelerated drawing" > ... > > The above feature is specific to the Apple ports, as none of WPE, GTK, > WinCairo, or PlayStation can use CoreAnimation. > > It would be good to go over the list in UnifiedWebPreferences.yaml and > add missing conditions for such cases; e.g. in the example above we need > to add: > > condition: USE(CA) Mmmmkay, maybe this wasn't the best example because the feature setting is used also by ports that don't define USE(CA), so in this case the course of action would be to change the description to read “GraphicsLayer accelerated drawing” (without the “CA”); but the general idea applies to other feature settings. 1952597 2 aperez 2023-05-03 02:00:14 -0700 Pull request: https://github.com/WebKit/WebKit/pull/13392 1952715 3 ews-feeder 2023-05-03 13:26:20 -0700 Committed 263646@main (8cb6215d7346): <https://commits.webkit.org/263646@main> Reviewed commits have been landed. Closing PR #13392 and removing active labels. 1952716 4 webkit-bug-importer 2023-05-03 13:27:24 -0700 <rdar://problem/108857292>