25604 2009-05-06 22:03:04 -0700 No way to intercept command-b or command-i on Mac WebKit 2009-05-08 08:50:43 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED DUPLICATE 18693 GoogleBug P2 Normal --- 25607 1 eric webkit-unassigned jparent justin.garcia ojan oldest_to_newest 120220 0 eric 2009-05-06 22:03:04 -0700 No way to intercept command-b or command-i on Mac WebKit HTML editors need to be able to tie in to do their own bold/italic handling (for notification change events or for recording extra data). Multiple HTML editing libraries @ Google have hacks around this bug. The current best-practice hack is to make the editable region plain-text only, and catch they key events yourself. You never see the key events if the editable region is full rich text. 120224 1 eric 2009-05-06 22:13:44 -0700 Actually, I'm wrong. You can turn on read-write-plaintext-only, but then you still don't get any key events to catch. 120225 2 30087 eric 2009-05-06 22:14:24 -0700 Created attachment 30087 test harness for showing this bug 120391 3 eric 2009-05-07 21:03:58 -0700 The stack trace called: #0 0x0370985b in WebCore::executeToggleBold at EditorCommand.cpp:977 #1 0x03705d67 in WebCore::Editor::Command::execute at EditorCommand.cpp:1480 #2 0x0031f6fb in -[WebHTMLView executeCoreCommandByName:] at WebHTMLView.mm:2358 #3 0x0030f463 in -[WebHTMLView _handleStyleKeyEquivalent:] at WebHTMLView.mm:4121 #4 0x003148b3 in -[WebHTMLView performKeyEquivalent:] at WebHTMLView.mm:4134 120423 4 ap 2009-05-08 08:50:43 -0700 *** This bug has been marked as a duplicate of 18693 *** 30087 2009-05-06 22:14:24 -0700 2009-05-06 22:14:24 -0700 test harness for showing this bug test.html text/html 1774 eric PGRpdiBpZD0icmljaFRleHQiIHN0eWxlPSJib3JkZXIgMXB4IHNvbGlkIGJsYWNrIiBjb250ZW50 RWRpdGFibGU+cmljaCB0ZXh0IHJlZ2lvbjwvZGl2Pgo8ZGl2IGlkPSJwbGFpblRleHQiIHN0eWxl PSJib3JkZXIgMXB4IHNvbGlkIGJsdWU7IC13ZWJraXQtdXNlci1tb2RpZnk6IHJlYWQtd3JpdGUt cGxhaW50ZXh0LW9ubHkiPnBsYWluIHRleHQgcmVnaW9uPC9kaXY+Cgo8ZGl2IHN0eWxlPSJoZWln aHQ6IDkwJTsgb3ZlcmZsb3c6IGF1dG87Ij4KICAgIDx0YWJsZSBzdHlsZT0iZm9udDogMTBweCBt b25vc3BhY2U7IiBpZD0ibG9nIj48L3RhYmxlPgo8L2Rpdj4KCjxzY3JpcHQ+CnZhciBzZXF1ZW5j ZU51bWJlciA9IDA7CgpmdW5jdGlvbiBhZGRMb2dSb3coZXZlbnRTdHJpbmcsIGNvbG9yKQp7CiAg ICBzZXF1ZW5jZU51bWJlcisrOwoKICAgIHZhciBzZXF1ZW5jZUNlbGwgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCJ0ZCIpOwogICAgc2VxdWVuY2VDZWxsLmlubmVySFRNTCA9IHNlcXVlbmNlTnVt YmVyOwoKICAgIHZhciBsb2dDZWxsID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidGQiKTsKICAg IGxvZ0NlbGwuaW5uZXJIVE1MID0gZXZlbnRTdHJpbmc7CiAgICBsb2dDZWxsLnN0eWxlLmNvbG9y ID0gY29sb3I7CgogICAgdmFyIG5ld1JvdyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRyIik7 CiAgICBuZXdSb3cuYXBwZW5kQ2hpbGQoc2VxdWVuY2VDZWxsKTsKICAgIG5ld1Jvdy5hcHBlbmRD aGlsZChsb2dDZWxsKTsKCiAgICBsb2cuaW5zZXJ0QmVmb3JlKG5ld1JvdywgbG9nLmZpcnN0Q2hp bGQpOwp9CgpmdW5jdGlvbiBjb2xvckZvckV2ZW50VHlwZShldmVudFR5cGUpIHsKICAgIGlmIChl dmVudFR5cGUubWF0Y2goL0RPTS8pKQogICAgICAgIHJldHVybiAiZ3JleSI7CiAgICBpZiAoZXZl bnRUeXBlLm1hdGNoKC9rZXkvKSkKICAgICAgICByZXR1cm4gImdyZWVuIjsKICAgIHJldHVybiAi YmxhY2siOwp9CgpmdW5jdGlvbiBsb2dFdmVudChldmVudCkgewogICAgdmFyIGxvZyA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJsb2ciKTsKICAgIHZhciBldmVudFN0cmluZyA9IGV2ZW50LnR5 cGU7CiAgICBpZiAoZXZlbnQudHlwZS5tYXRjaCgva2V5LykpCiAgICAgICAgZXZlbnRTdHJpbmcg Kz0gIiAiICsgZXZlbnQua2V5Q29kZSArICIoIiArIFN0cmluZy5mcm9tQ2hhckNvZGUoZXZlbnQu a2V5Q29kZSkgKyAiKSI7CiAgICAKICAgIGFkZExvZ1JvdyhldmVudFN0cmluZywgY29sb3JGb3JF dmVudFR5cGUoZXZlbnQudHlwZSkpOwp9Cgp2YXIgZXZlbnRzVG9Mb2cgPSBbCiAgICAia2V5dXAi LAogICAgImtleWRvd24iLAogICAgImtleXByZXNzIiwKICAgICJET01TdWJ0cmVlTW9kaWZpZWQi LAogICAgIkRPTU5vZGVSZW1vdmVkIiwKICAgICJET01Ob2RlSW5zZXJ0ZWQiLApdOwoKZnVuY3Rp b24gYWRkRXZlbnRIYW5kbGVycyhlbGVtZW50KSB7CiAgICBmb3IgKHZhciB4ID0gMDsgeCA8IGV2 ZW50c1RvTG9nLmxlbmd0aDsgeCsrKSB7CiAgICAgICAgZWxlbWVudC5hZGRFdmVudExpc3RlbmVy KGV2ZW50c1RvTG9nW3hdLCBsb2dFdmVudCwgdHJ1ZSk7CiAgICB9Cn0KCnZhciByaWNoVGV4dCA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyaWNoVGV4dCIpOwphZGRFdmVudEhhbmRsZXJzKHJp Y2hUZXh0KTsKdmFyIHBsYWluVGV4dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJwbGFpblRl eHQiKTsKYWRkRXZlbnRIYW5kbGVycyhwbGFpblRleHQpOwoKcmljaFRleHQuZm9jdXMoKTsKPC9z Y3JpcHQ+Cg==