25601 2009-05-06 19:53:41 -0700 [Qt] Make sure that public APIs are properly exported on all Qt supported platforms 2009-05-11 09:24:06 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned manyoso oldest_to_newest 120200 0 laszlo.gombos 2009-05-06 19:53:41 -0700 WebCore should define QT_MAKEDLL (in WebCore.pro) for all non-static builds (not just for win) to for properly export all Qt public APIs. ChangeSet 41494 (http://trac.webkit.org/changeset/41494) intended to fix this by defining QT_SHARED in webkitdirs.pm, but since not all the Qt build environments are using the build-webkit perl script to build, WebCore.pro is a better place to fix this. I think QT_MAKEDLL is the proper define to export all Qt public APIs, and not QT_SHARED. 120201 1 30082 laszlo.gombos 2009-05-06 20:00:28 -0700 Created attachment 30082 Proposed fix. 120618 2 30082 zecke 2009-05-11 03:41:25 -0700 Comment on attachment 30082 Proposed fix. thanks. 120677 3 zecke 2009-05-11 09:24:06 -0700 Landed in r43497. 30082 2009-05-06 20:00:28 -0700 2009-05-11 03:41:25 -0700 Proposed fix. patch_25601.txt text/plain 2264 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzMzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDUtMDYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gTWFrZSBzdXJlIHRoYXQgcHVibGljIEFQSXMgYXJlIHByb3Blcmx5IGV4cG9y dGVkIG9uIGFsbCBRdCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI1NjAxCisKKyAgICAgICAgKiBXZWJDb3JlLnBybzogRGVmaW5lIFFU X01BS0VETEwgZm9yIGFsbCBub24tc3RhdGljIGJ1aWxkcywgbm90IGp1c3QgZm9yIHdpbgorCiAy MDA5LTA1LTA2ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAg ICAgICAgIHd4IGJ1aWxkIGZpeCwgZml4ZXMgZm9yIHd4IHRydW5rIGJ1aWxkcy4KSW5kZXg6IFdl YkNvcmUvV2ViQ29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnBybwkocmV2 aXNpb24gNDMyOTQpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0x NCw3ICsxNCw3IEBAIENPTkZJRyhRVERJUl9idWlsZCkgewogICAgIFBSRUNPTVBJTEVEX0hFQURF UiA9ICQkUFdELy4uL1dlYktpdC9xdC9XZWJLaXRfcGNoLmgKICAgICBERUZJTkVTICo9IE5ERUJV RwogfSBlbHNlIHsKLSAgICB3aW4zMi0qOiFzdGF0aWM6IERFRklORVMgKz0gUVRfTUFLRURMTAor ICAgICFzdGF0aWM6IERFRklORVMgKz0gUVRfTUFLRURMTAogCiAgICAgQ09ORklHKGRlYnVnLCBk ZWJ1Z3xyZWxlYXNlKSB7CiAgICAgICAgIGlzRW1wdHkoR0VORVJBVEVEX1NPVVJDRVNfRElSKTpH RU5FUkFURURfU09VUkNFU19ESVIgPSBnZW5lcmF0ZWQvZGVidWcKSW5kZXg6IFdlYktpdFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9u IDQzMzMyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMDktMDUtMDYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gTWFrZSBzdXJlIHRoYXQgcHVibGljIEFQSXMgYXJlIHByb3Blcmx5IGV4cG9ydGVkIG9u IGFsbCBRdCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI1NjAxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06IFJlbW92 ZSBRVF9TSEFSRUQgZGVmaW5lIGZyb20gUXQgYnVpbGRzLCBkZWZpbmUgUVRfTUFLRURMTCBpbiBX ZWJDb3JlLnBybyBpbnN0ZWFkCisKIDIwMDktMDUtMDYgIEtldmluIE9sbGl2aWVyICA8a2V2aW5v QHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgd3ggYnVpbGQgZml4LCBmaXhlcyBmb3Igd3gg dHJ1bmsgYnVpbGRzLgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24g NDMyOTQpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29w eSkKQEAgLTExMjcsOCArMTEyNyw2IEBAIHN1YiBidWlsZFFNYWtlUHJvamVjdCgkQCkKIAogICAg IG15IEBidWlsZEFyZ3MgPSAoIi1yIik7CiAKLSAgICBwdXNoIEBidWlsZEFyZ3MsICJERUZJTkVT Kz1RVF9TSEFSRUQiOwotCiAgICAgbXkgJHFtYWtlYmluID0gInFtYWtlIjsgIyBBbGxvdyBvdmVy cmlkZSBvZiB0aGUgcW1ha2UgYmluYXJ5IGZyb20gJFBBVEgKICAgICBteSAkbWFrZWFyZ3MgPSAi IjsKICAgICBmb3IgbXkgJGkgKDAgLi4gJCNidWlsZFBhcmFtcykgewo=