25596 2009-05-06 14:00:09 -0700 Chromium build bustage caused by r43317 (making RefCountedBase::m_refCount private) 2009-05-06 16:53:19 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd darin oldest_to_newest 120140 0 fishd 2009-05-06 14:00:09 -0700 Chromium build bustage caused by r43317 (making RefCountedBase::m_refCount private) See http://trac.webkit.org/changeset/43317 Our AccessibilityObjectWrapper still needs the old semantics of RefCounted (when it was zero initialized). We haven't fixed that yet because we are waiting to get our WebKit layer side into svn.webkit.org. That side uses COM style reference counting, which leads to needing the object to be initialized with a ref count of 0. This is all super annoyingly ugly, and I really want it to be fixed. But, I want the WebKit API to be upstreamed more than that, and so I am putting off this :-( Ugly workaround patch coming up... 120141 1 30063 fishd 2009-05-06 14:04:20 -0700 Created attachment 30063 v1 patch 120142 2 30063 dglazkov 2009-05-06 14:06:21 -0700 Comment on attachment 30063 v1 patch Eek. 120143 3 fishd 2009-05-06 14:07:35 -0700 Landed as: http://trac.webkit.org/changeset/43322 120167 4 darin 2009-05-06 15:10:57 -0700 Another way to fix this would be to not use RefCounted until you can match its normal semantics. RefPtr works fine as long as there are ref and deref functions; they don't have to come from the RefCounted class template. 120181 5 fishd 2009-05-06 16:53:19 -0700 > Another way to fix this would be to not use RefCounted until you can match its > normal semantics. RefPtr works fine as long as there are ref and deref > functions; they don't have to come from the RefCounted class template. That's a very good suggestion! 30063 2009-05-06 14:04:20 -0700 2009-05-06 14:06:21 -0700 v1 patch fix_1.txt text/plain 1176 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQzMzIx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDUt MDYgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjU1OTYKKworICAgICAgICBGaXhlcyBDaHJvbWl1bSBidWlsZCBidXN0 YWdlIGNhdXNlZCBieSByNDMzMTcgKG1ha2luZworICAgICAgICBSZWZDb3VudGVkQmFzZTo6bV9y ZWZDb3VudCBwcml2YXRlKQorCisgICAgICAgICogcGFnZS9jaHJvbWl1bS9BY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlci5oOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdFdy YXBwZXI6OkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyKToKKwogMjAwOS0wNS0wNiAgSGluLUNo dW5nIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBGaXNoZXIuCkluZGV4OiBwYWdlL2Nocm9taXVtL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gcGFnZS9jaHJvbWl1bS9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ci5oCShyZXZpc2lvbiA0MzMyMSkKKysrIHBhZ2UvY2hyb21pdW0vQWNjZXNzaWJpbGl0eU9iamVj dFdyYXBwZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAgICAgICAgICAgICA6IG1fb2JqZWN0KG9iaikKICAgICAgICAgewogICAgICAgICAg ICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG9uY2Ugb3VyIGltbWVkaWF0ZSBzdWJjbGFzcyBubyBs b25nZXIgdXNlcyBDT00uCi0gICAgICAgICAgICBtX3JlZkNvdW50ID0gMDsKKyAgICAgICAgICAg ICphZGRyZXNzT2ZDb3VudCgpID0gMDsKICAgICAgICAgfQogICAgICAgICBBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlcigpIDogbV9vYmplY3QoMCkgeyB9CiAK