25593 2009-05-06 12:36:43 -0700 Refactor MediaPlayerPviate for Chromium port 2009-05-06 12:58:27 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hclam hclam dglazkov fishd oldest_to_newest 120125 0 hclam 2009-05-06 12:36:43 -0700 Remove all the methods from MediaPlayerPrivate from MediaPlayerPrivateChromium.h so it only has one static method. 120127 1 30059 hclam 2009-05-06 12:40:23 -0700 Created attachment 30059 patch + changelog This is a refactoring, no layout tests are provided. 120129 2 30059 fishd 2009-05-06 12:46:03 -0700 Comment on attachment 30059 patch + changelog >+2009-05-06 hclam <hclam@chromium.org> actually, one nit for next time: please set REAL_NAME in your environment so that prepare-ChangeLog automatically includes your full name instead of "hclam" in the ChangeLog. 120132 3 fishd 2009-05-06 12:58:27 -0700 Landed as: http://trac.webkit.org/changeset/43321 30059 2009-05-06 12:40:23 -0700 2009-05-06 12:45:08 -0700 patch + changelog webkit-media-player-refactor.patch text/plain 2693 hclam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQzMzE2KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNS0wNiAgaGNsYW0gIDxoY2xhbUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NTkzCisKKyAgICAgICAgUmVmYWN0 b3IgZm9yIE1lZGlhUGxheWVyUHJpdmF0ZSBmb3IgQ2hyb21pdW0gcG9ydC4gUmVtb3ZlCisgICAg ICAgIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBNZWRpYVBsYXllclByaXZhdGVJbmZlcmZhY2UgZnJv bSBpdC4KKworICAgICAgICAqIHBsYXRmb3JtXGdyYXBoaWNzXGNocm9taXVtXE1lZGlhUGxheWVy UHJpdmF0ZUNocm9taXVtLmg6CisKIDIwMDktMDUtMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dCwgRGFuIEJl cm5zdGVpbgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9NZWRpYVBs YXllclByaXZhdGVDaHJvbWl1bS5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9NZWRpYVBsYXllclByaXZhdGVDaHJvbWl1bS5oCShyZXZpc2lvbiA0 MzMxNSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTWVkaWFQbGF5ZXJQ cml2YXRlQ2hyb21pdW0uaAkod29ya2luZyBjb3B5KQpAQCAtMzcsNjkgKzM3LDEyIEBACiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgTWVkaWFQbGF5ZXJQcml2YXRlIDogcHVibGljIE1l ZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSB7CitjbGFzcyBNZWRpYVBsYXllclByaXZhdGUgewog cHVibGljOgogICAgIHN0YXRpYyB2b2lkIHJlZ2lzdGVyTWVkaWFFbmdpbmUoTWVkaWFFbmdpbmVS ZWdpc3RyYXIpOwotICAgIH5NZWRpYVBsYXllclByaXZhdGUoKTsKLQotICAgIEludFNpemUgbmF0 dXJhbFNpemUoKSBjb25zdDsKLSAgICBib29sIGhhc1ZpZGVvKCkgY29uc3Q7Ci0KLSAgICB2b2lk IGxvYWQoY29uc3QgU3RyaW5nJiB1cmwpOwotICAgIHZvaWQgY2FuY2VsTG9hZCgpOwotCi0gICAg dm9pZCBwbGF5KCk7Ci0gICAgdm9pZCBwYXVzZSgpOyAgICAKLQotICAgIGJvb2wgcGF1c2VkKCkg Y29uc3Q7Ci0gICAgYm9vbCBzZWVraW5nKCkgY29uc3Q7Ci0KLSAgICBmbG9hdCBkdXJhdGlvbigp IGNvbnN0OwotICAgIGZsb2F0IGN1cnJlbnRUaW1lKCkgY29uc3Q7Ci0gICAgdm9pZCBzZWVrKGZs b2F0IHRpbWUpOwotICAgIHZvaWQgc2V0RW5kVGltZShmbG9hdCk7Ci0KLSAgICB2b2lkIHNldFJh dGUoZmxvYXQpOwotICAgIHZvaWQgc2V0Vm9sdW1lKGZsb2F0KTsKLQotICAgIGludCBkYXRhUmF0 ZSgpIGNvbnN0OwotCi0gICAgTWVkaWFQbGF5ZXI6Ok5ldHdvcmtTdGF0ZSBuZXR3b3JrU3RhdGUo KSBjb25zdDsKLSAgICBNZWRpYVBsYXllcjo6UmVhZHlTdGF0ZSByZWFkeVN0YXRlKCkgY29uc3Q7 Ci0KLSAgICBmbG9hdCBtYXhUaW1lQnVmZmVyZWQoKSBjb25zdDsKLSAgICBmbG9hdCBtYXhUaW1l U2Vla2FibGUoKSBjb25zdDsKLSAgICB1bnNpZ25lZCBieXRlc0xvYWRlZCgpIGNvbnN0OwotICAg IGJvb2wgdG90YWxCeXRlc0tub3duKCkgY29uc3Q7Ci0gICAgdW5zaWduZWQgdG90YWxCeXRlcygp IGNvbnN0OwotCi0gICAgdm9pZCBzZXRWaXNpYmxlKGJvb2wpOwotICAgIHZvaWQgc2V0U2l6ZShj b25zdCBJbnRTaXplJik7Ci0KLSAgICB2b2lkIHBhaW50KEdyYXBoaWNzQ29udGV4dCosIGNvbnN0 IEludFJlY3QmKTsKLQotICAgIC8vIFB1YmxpYyBtZXRob2RzIHRvIGJlIGNhbGxlZCBieSBXZWJN ZWRpYVBsYXllcgotICAgIEZyYW1lVmlldyogZnJhbWVWaWV3KCk7Ci0gICAgdm9pZCByZXBhaW50 KCk7Ci0gICAgdm9pZCBuZXR3b3JrU3RhdGVDaGFuZ2VkKCk7Ci0gICAgdm9pZCByZWFkeVN0YXRl Q2hhbmdlZCgpOwotICAgIHZvaWQgdm9sdW1lQ2hhbmdlZCgpOwotICAgIHZvaWQgdGltZUNoYW5n ZWQoKTsKLSAgICB2b2lkIHNpemVDaGFuZ2VkKCk7Ci0gICAgdm9pZCByYXRlQ2hhbmdlZCgpOwot ICAgIHZvaWQgZHVyYXRpb25DaGFuZ2VkKCk7Ci0KLXByaXZhdGU6Ci0gICAgTWVkaWFQbGF5ZXJQ cml2YXRlKE1lZGlhUGxheWVyKik7Ci0gICAgc3RhdGljIE1lZGlhUGxheWVyUHJpdmF0ZUludGVy ZmFjZSogY3JlYXRlKE1lZGlhUGxheWVyKiBwbGF5ZXIpOwotICAgIHN0YXRpYyB2b2lkIGdldFN1 cHBvcnRlZFR5cGVzKEhhc2hTZXQ8U3RyaW5nPiYpOwotICAgIHN0YXRpYyBNZWRpYVBsYXllcjo6 U3VwcG9ydHNUeXBlIHN1cHBvcnRzVHlwZShjb25zdCBTdHJpbmcmIHR5cGUsIGNvbnN0IFN0cmlu ZyYgY29kZWNzKTsKLQotICAgIE1lZGlhUGxheWVyKiBtX3BsYXllcjsKLSAgICB2b2lkKiBtX2Rh dGE7CiB9OwogCi19ICAvLyBuYW1lc3BhY2UgV2ViQ29yZQorfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQogCiAjZW5kaWYKIAo=