<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>25591</bug_id>
          
          <creation_ts>2009-05-06 11:18:56 -0700</creation_ts>
          <short_desc>Upstream V8 bindings for HTMLFormElement</short_desc>
          <delta_ts>2009-05-07 09:18:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Nate Chapin">japhet</reporter>
          <assigned_to name="David Levin">levin</assigned_to>
          <cc>japhet</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>120112</commentid>
    <comment_count>0</comment_count>
    <who name="Nate Chapin">japhet</who>
    <bug_when>2009-05-06 11:18:56 -0700</bug_when>
    <thetext>See summary.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120117</commentid>
    <comment_count>1</comment_count>
      <attachid>30058</attachid>
    <who name="Nate Chapin">japhet</who>
    <bug_when>2009-05-06 11:53:28 -0700</bug_when>
    <thetext>Created attachment 30058
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120120</commentid>
    <comment_count>2</comment_count>
      <attachid>30058</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-05-06 11:55:39 -0700</bug_when>
    <thetext>Comment on attachment 30058
patch

Don&apos;t forget to add bug URL in the ChangeLog entry.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120148</commentid>
    <comment_count>3</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-05-06 14:13:02 -0700</bug_when>
    <thetext>Assign to levin for landing.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120164</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-05-06 15:02:37 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/43326</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120279</commentid>
    <comment_count>5</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2009-05-07 08:58:07 -0700</bug_when>
    <thetext>This change had an &apos;oops&apos; in it that broke the Chromium build:
http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/3199/steps/compile/logs/stdio_html

Fixed:  http://trac.webkit.org/changeset/43344</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120285</commentid>
    <comment_count>6</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2009-05-07 09:18:41 -0700</bug_when>
    <thetext>Also needed this fix:  http://trac.webkit.org/changeset/43346</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>30058</attachid>
            <date>2009-05-06 11:53:28 -0700</date>
            <delta_ts>2009-05-06 11:55:39 -0700</delta_ts>
            <desc>patch</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>2403</size>
            <attacher name="Nate Chapin">japhet</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0MzMxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMDktMDUtMDYgIE5hdGUgQ2hhcGluICA8amFwaGV0QGdvb2dsZS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBz
dHJlYW0gVjhIVE1MRm9ybUVsZW1lbnQgZnJvbSB0aGUgQ2hyb21pdW0gcmVwb3NpdG9yeS4KKwor
ICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxGb3JtRWxlbWVudEN1c3RvbS5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpJTkRFWEVEX1BST1BFUlRZX0dFVFRFUik6IFVwc3RyZWFtZWQg
ZnJvbSBDaHJvbWl1bSByZXBvc2l0b3J5CisgICAgICAgIChXZWJDb3JlOjpOQU1FRF9QUk9QRVJU
WV9HRVRURVIpOiBDaGFuZ2VkIGVtcHR5IGVsZW1lbnQgcmV0dXJuIGNhc2UgdG8gcmV0dXJuIG5v
dEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CisgICAgICAgIChXZWJDb3JlOjpDQUxMQkFDS19GVU5D
X0RFQ0wpOiBVcHN0cmVhbWVkIGZyb20gQ2hyb21pdW0gcmVwb3NpdG9yeQorCiAyMDA5LTA1LTA2
ICBLZXZpbiBNY0N1bGxvdWdoICA8a21jY3VsbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIC1D
bGFyaWZpZWQgYSBjb21tZW50CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhU
TUxGb3JtRWxlbWVudEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92
OC9jdXN0b20vVjhIVE1MRm9ybUVsZW1lbnRDdXN0b20uY3BwCShyZXZpc2lvbiA0MzMxMikKKysr
IFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEZvcm1FbGVtZW50Q3VzdG9tLmNwcAko
d29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgsMTggQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewog
CitJTkRFWEVEX1BST1BFUlRZX0dFVFRFUihIVE1MRm9ybUVsZW1lbnQpCit7CisgICAgSU5DX1NU
QVRTKCJET00uSFRNTEZvcm1FbGVtZW50LkluZGV4ZWRQcm9wZXJ0eUdldHRlciIpOworICAgIEhU
TUxGb3JtRWxlbWVudCogZm9ybSA9IFY4UHJveHk6RE9NV3JhcHBlclRvTm9kZTxIVE1MRm9ybUVs
ZW1lbnQ+KGluZm8uSG9sZGVyKCkpOworICAgIAorICAgIFJlZlB0cjxOb2RlPiBmb3JtRWxlbWVu
dCA9IGZvcm0tPmVsZW1lbnRzKCktPml0ZW0oaW5kZXgpOworICAgIGlmICghZm9ybUVsZW1lbnQp
CisgICAgICAgIHJldHVybiBub3RIYW5kbGVkQnlJbnRlcmNlcHRvcigpOworICAgIHJldHVybiBW
OFByb3h5OjpOb2RlVG9WOE9iamVjdChmb3JtRWxlbWVudC5nZXQoKSk7Cit9CisKKwogTkFNRURf
UFJPUEVSVFlfR0VUVEVSKEhUTUxGb3JtRWxlbWVudCkKIHsKICAgICBJTkNfU1RBVFMoIkRPTS5I
VE1MRm9ybUVsZW1lbnQuTmFtZWRQcm9wZXJ0eUdldHRlciIpOwpAQCAtNTEsNyArNjMsNyBAQCBO
QU1FRF9QUk9QRVJUWV9HRVRURVIoSFRNTEZvcm1FbGVtZW50KQogICAgICAgICBWZWN0b3I8UmVm
UHRyPE5vZGU+ID4gZWxlbWVudHM7CiAgICAgICAgIGltcC0+Z2V0TmFtZWRFbGVtZW50cyh2LCBl
bGVtZW50cyk7CiAgICAgICAgIGlmIChlbGVtZW50cy5pc0VtcHR5KCkpCi0gICAgICAgICAgICBy
ZXR1cm4gdjg6OkhhbmRsZTx2ODo6VmFsdWU+KCk7CisgICAgICAgICAgICByZXR1cm4gbm90SGFu
ZGxlZEJ5SW50ZXJjZXB0b3IoKTsKICAgICB9CiAKICAgICAvLyBTZWNvbmQgY2FsbCBtYXkgcmV0
dXJuIGRpZmZlcmVudCByZXN1bHRzIGZyb20gdGhlIGZpcnN0IGNhbGwsCkBAIC02Niw1ICs3OCwx
MiBAQCBOQU1FRF9QUk9QRVJUWV9HRVRURVIoSFRNTEZvcm1FbGVtZW50KQogICAgIE5vZGVMaXN0
KiBjb2xsZWN0aW9uID0gbmV3IFY4TmFtZWROb2Rlc0NvbGxlY3Rpb24oZWxlbWVudHMpOwogICAg
IHJldHVybiBWOFByb3h5OjpUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6Tk9ERUxJU1QsIGNvbGxl
Y3Rpb24pOwogfQorICAgIAorQ0FMTEJBQ0tfRlVOQ19ERUNMKEhUTUxGb3JtRWxlbWVudFN1Ym1p
dCkgeworICAgIElOQ19TVEFUUygiRE9NLkhUTUxGb3JtRWxlbWVudC5zdWJtaXQoKSIpOworICAg
IEhUTUxGb3JtRWxlbWVudCogZm9ybSA9IFY4UHJveHk6OkRPTVdyYXBwZXJUb05hdGl2ZTxIVE1M
Rm9ybUVsZW1lbnQ+KGFyZ3MuSG9sZGVyKCkpOworICAgIGZvcm0tPnN1Ym1pdCgwLCBmYWxzZSwg
ZmFsc2UpOworICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7Cit9CiAKIH0gLy8gbmFtZXNwYWNl
IFdlYkNvcmUK
</data>
<flag name="review"
          id="15087"
          type_id="1"
          status="+"
          setter="dglazkov"
    />
          </attachment>
      

    </bug>

</bugzilla>