25560 2009-05-05 01:51:22 -0700 REGRESSION (r34821): "string value".__proto__ gets the wrong object. 2009-05-11 11:55:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 erikcorry darin oldest_to_newest 119937 0 erikcorry 2009-05-05 01:51:22 -0700 This is a regression. The problem is not present in eg. Safari 3.2.2 for Windows. In the latest WebKit nightlies and in the Safari 4 beta for OSX it is present. Here is a snippet to reproduce it: <script> "foo".__proto__.foo = "bar"; if (Object.prototype.foo == "bar") alert("Has Safari __proto__ bug"); else alert("Doesn't have Safari __proto__ bug"); </script> It seems the problem is restricted to string values. new String("foo").__proto__ gets the right object. 120087 1 ap 2009-05-06 04:34:23 -0700 <rdar://problem/6861069> 120386 2 30127 darin 2009-05-07 18:40:39 -0700 Created attachment 30127 patch -- needs regression test before review 120698 3 30195 darin 2009-05-11 11:31:47 -0700 Created attachment 30195 patch 120699 4 darin 2009-05-11 11:55:33 -0700 http://trac.webkit.org/changeset/43506 30127 2009-05-07 18:40:39 -0700 2009-05-11 11:31:47 -0700 patch -- needs regression test before review StringProtoPatch.txt text/plain 773 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuY3BwCShyZXZpc2lvbiA0MzM4MCkKKysr IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04 OCw2ICs4OCwxMCBAQCBib29sIEpTU3RyaW5nOjpnZXRPd25Qcm9wZXJ0eVNsb3QoRXhlY1N0CiAg ICAgLy8gVGhpcyBmdW5jdGlvbiBzaG91bGQgb25seSBiZSBjYWxsZWQgYnkgSlNWYWx1ZTo6Z2V0 LgogICAgIGlmIChnZXRTdHJpbmdQcm9wZXJ0eVNsb3QoZXhlYywgcHJvcGVydHlOYW1lLCBzbG90 KSkKICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgaWYgKHByb3BlcnR5TmFtZSA9PSBleGVjLT5w cm9wZXJ0eU5hbWVzKCkudW5kZXJzY29yZVByb3RvKSB7CisgICAgICAgIHNsb3Quc2V0VmFsdWUo ZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLT5zdHJpbmdQcm90b3R5cGUoKSk7CisgICAgICAg IHJldHVybiB0cnVlOworICAgIH0KICAgICBzbG90LnNldEJhc2UodGhpcyk7CiAgICAgSlNPYmpl Y3QqIG9iamVjdDsKICAgICBmb3IgKEpTVmFsdWUgcHJvdG90eXBlID0gZXhlYy0+bGV4aWNhbEds b2JhbE9iamVjdCgpLT5zdHJpbmdQcm90b3R5cGUoKTsgIXByb3RvdHlwZS5pc051bGwoKTsgcHJv dG90eXBlID0gb2JqZWN0LT5wcm90b3R5cGUoKSkgewo= 30195 2009-05-11 11:31:47 -0700 2009-05-11 11:51:13 -0700 patch PrototypesPatch.txt text/plain 6501 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQzNTA0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMDUtMTEgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEJ1ZyAyNTU2MDogUkVHUkVTU0lPTiAocjM0ODIxKTogInN0cmluZyB2 YWx1ZSIuX19wcm90b19fIGdldHMgdGhlIHdyb25nIG9iamVjdC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NTYwCisgICAgICAgIHJkYXI6Ly9wcm9i bGVtLzY4NjEwNjkKKworICAgICAgICBJIG1pc3NlZCB0aGlzIGNhc2UgYmFjayBhIHllYXIgYWdv IHdoZW4gSSBzcGVkIHVwIGhhbmRsaW5nCisgICAgICAgIG9mIEphdmFTY3JpcHQgd3JhcHBlcnMu IEVhc3kgdG8gZml4LgorCisgICAgICAgICogcnVudGltZS9KU09iamVjdC5oOgorICAgICAgICAo SlNDOjpKU1ZhbHVlOjpnZXQpOiBSZXR1cm4gdGhlIHByb3RvdHlwZSBpdHNlbGYgaWYgdGhlIHBy b3BlcnR5IG5hbWUKKyAgICAgICAgaXMgX19wcm90b19fLgorICAgICAgICAqIHJ1bnRpbWUvSlNT dHJpbmcuY3BwOgorICAgICAgICAoSlNDOjpKU1N0cmluZzo6Z2V0T3duUHJvcGVydHlTbG90KTog RGl0dG8uCisKIDIwMDktMDUtMTEgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVja2VA c2VsZmlzaC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguIEJ1aWxkIFBhcnNl ckFyZWFuYS5jcHAgZm9yIFF0CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCShyZXZp c2lvbiA0MzUwMSkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAkod29ya2lu ZyBjb3B5KQpAQCAtNDk0LDYgKzQ5NCw4IEBAIGlubGluZSBKU1ZhbHVlIEpTVmFsdWU6OmdldChF eGVjU3RhdGUqIGUKIHsKICAgICBpZiAoVU5MSUtFTFkoIWlzQ2VsbCgpKSkgewogICAgICAgICBK U09iamVjdCogcHJvdG90eXBlID0gSlNJbW1lZGlhdGU6OnByb3RvdHlwZShhc1ZhbHVlKCksIGV4 ZWMpOworICAgICAgICBpZiAocHJvcGVydHlOYW1lID09IGV4ZWMtPnByb3BlcnR5TmFtZXMoKS51 bmRlcnNjb3JlUHJvdG8pCisgICAgICAgICAgICByZXR1cm4gcHJvdG90eXBlOwogICAgICAgICBp ZiAoIXByb3RvdHlwZS0+Z2V0UHJvcGVydHlTbG90KGV4ZWMsIHByb3BlcnR5TmFtZSwgc2xvdCkp CiAgICAgICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKICAgICAgICAgcmV0dXJuIHNsb3Qu Z2V0VmFsdWUoZXhlYywgcHJvcGVydHlOYW1lKTsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNTdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNT dHJpbmcuY3BwCShyZXZpc2lvbiA0MzUwMSkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNT dHJpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OCw2ICs4OCwxMCBAQCBib29sIEpTU3RyaW5n OjpnZXRPd25Qcm9wZXJ0eVNsb3QoRXhlY1N0CiAgICAgLy8gVGhpcyBmdW5jdGlvbiBzaG91bGQg b25seSBiZSBjYWxsZWQgYnkgSlNWYWx1ZTo6Z2V0LgogICAgIGlmIChnZXRTdHJpbmdQcm9wZXJ0 eVNsb3QoZXhlYywgcHJvcGVydHlOYW1lLCBzbG90KSkKICAgICAgICAgcmV0dXJuIHRydWU7Cisg ICAgaWYgKHByb3BlcnR5TmFtZSA9PSBleGVjLT5wcm9wZXJ0eU5hbWVzKCkudW5kZXJzY29yZVBy b3RvKSB7CisgICAgICAgIHNsb3Quc2V0VmFsdWUoZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgp LT5zdHJpbmdQcm90b3R5cGUoKSk7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KICAgICBz bG90LnNldEJhc2UodGhpcyk7CiAgICAgSlNPYmplY3QqIG9iamVjdDsKICAgICBmb3IgKEpTVmFs dWUgcHJvdG90eXBlID0gZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLT5zdHJpbmdQcm90b3R5 cGUoKTsgIXByb3RvdHlwZS5pc051bGwoKTsgcHJvdG90eXBlID0gb2JqZWN0LT5wcm90b3R5cGUo KSkgewpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDM1MDQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNS0xMSAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQnVnIDI1NTYwOiBSRUdSRVNTSU9OIChyMzQ4MjEpOiAic3RyaW5nIHZhbHVl Ii5fX3Byb3RvX18gZ2V0cyB0aGUgd3Jvbmcgb2JqZWN0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU1NjAKKyAgICAgICAgcmRhcjovL3Byb2JsZW0v Njg2MTA2OQorCisgICAgICAgICogZmFzdC9qcy9wcm90b3R5cGVzLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC9qcy9wcm90b3R5cGVzLmh0bWw6IEFkZGVkLgorICAgICAgICAq IGZhc3QvanMvcmVzb3VyY2VzL3Byb3RvdHlwZXMuanM6IEFkZGVkLgorCiAyMDA5LTA1LTExICBE YXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkZWQgd2ViYXJj aGl2ZS90ZXN0LWxpbmstcmVsLWljb24uaHRtbCB0byBndGsgU2tpcHBlZCBsaXN0CkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2pzL3Byb3RvdHlwZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvanMvcHJvdG90eXBlcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Byb3RvdHlwZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDI2IEBACitUZXN0IHByb3RvdG95cGVzIG9mIHZhcmlvdXMgb2JqZWN0 cy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgKCcnKS5fX3Byb3RvX18g aXMgU3RyaW5nLnByb3RvdHlwZQorUEFTUyAoMCkuX19wcm90b19fIGlzIE51bWJlci5wcm90b3R5 cGUKK1BBU1MgKFtdKS5fX3Byb3RvX18gaXMgQXJyYXkucHJvdG90eXBlCitQQVNTICh7fSkuX19w cm90b19fIGlzIE9iamVjdC5wcm90b3R5cGUKK1BBU1MgKG5ldyBEYXRlKS5fX3Byb3RvX18gaXMg RGF0ZS5wcm90b3R5cGUKK1BBU1MgKG5ldyBOdW1iZXIpLl9fcHJvdG9fXyBpcyBOdW1iZXIucHJv dG90eXBlCitQQVNTIChuZXcgT2JqZWN0KS5fX3Byb3RvX18gaXMgT2JqZWN0LnByb3RvdHlwZQor UEFTUyAobmV3IFN0cmluZykuX19wcm90b19fIGlzIFN0cmluZy5wcm90b3R5cGUKK1BBU1MgQXJy YXkucHJvdG90eXBlLl9fcHJvdG9fXyBpcyBPYmplY3QucHJvdG90eXBlCitQQVNTIERhdGUucHJv dG90eXBlLl9fcHJvdG9fXyBpcyBPYmplY3QucHJvdG90eXBlCitQQVNTIE51bWJlci5wcm90b3R5 cGUuX19wcm90b19fIGlzIE9iamVjdC5wcm90b3R5cGUKK1BBU1MgT2JqZWN0LnByb3RvdHlwZS5f X3Byb3RvX18gaXMgbnVsbAorUEFTUyBTdHJpbmcucHJvdG90eXBlLl9fcHJvdG9fXyBpcyBPYmpl Y3QucHJvdG90eXBlCitQQVNTIEFycmF5Ll9fcHJvdG9fXyBpcyBPYmplY3QuX19wcm90b19fCitQ QVNTIERhdGUuX19wcm90b19fIGlzIE9iamVjdC5fX3Byb3RvX18KK1BBU1MgTnVtYmVyLl9fcHJv dG9fXyBpcyBPYmplY3QuX19wcm90b19fCitQQVNTIFN0cmluZy5fX3Byb3RvX18gaXMgT2JqZWN0 Ll9fcHJvdG9fXworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM RVRFCisKClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvanMvcHJvdG90eXBl cy1leHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQogICArIG5hdGl2 ZQoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvcHJvdG90eXBlcy5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvanMvcHJvdG90eXBlcy5odG1sCShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZmFzdC9qcy9wcm90b3R5cGVzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4K KzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9InJlc291cmNlcy9q cy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz Ij48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8 ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcHJvdG90eXBl cy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRU ZXN0cy9mYXN0L2pzL3Byb3RvdHlwZXMuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBzdm46bWltZS10 eXBlCiAgICsgdGV4dC9odG1sCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvcHJvdG90eXBlcy5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9wcm90b3R5cGVzLmpzCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvcHJvdG90eXBlcy5qcwkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSwyMyBAQAorZGVzY3JpcHRpb24oCisnVGVzdCBwcm90b3RveXBl cyBvZiB2YXJpb3VzIG9iamVjdHMuJworKTsKKworc2hvdWxkQmUoIignJykuX19wcm90b19fIiwg IlN0cmluZy5wcm90b3R5cGUiKTsKK3Nob3VsZEJlKCIoMCkuX19wcm90b19fIiwgIk51bWJlci5w cm90b3R5cGUiKTsKK3Nob3VsZEJlKCIoW10pLl9fcHJvdG9fXyIsICJBcnJheS5wcm90b3R5cGUi KTsKK3Nob3VsZEJlKCIoe30pLl9fcHJvdG9fXyIsICJPYmplY3QucHJvdG90eXBlIik7CitzaG91 bGRCZSgiKG5ldyBEYXRlKS5fX3Byb3RvX18iLCAiRGF0ZS5wcm90b3R5cGUiKTsKK3Nob3VsZEJl KCIobmV3IE51bWJlcikuX19wcm90b19fIiwgIk51bWJlci5wcm90b3R5cGUiKTsKK3Nob3VsZEJl KCIobmV3IE9iamVjdCkuX19wcm90b19fIiwgIk9iamVjdC5wcm90b3R5cGUiKTsKK3Nob3VsZEJl KCIobmV3IFN0cmluZykuX19wcm90b19fIiwgIlN0cmluZy5wcm90b3R5cGUiKTsKK3Nob3VsZEJl KCJBcnJheS5wcm90b3R5cGUuX19wcm90b19fIiwgIk9iamVjdC5wcm90b3R5cGUiKTsKK3Nob3Vs ZEJlKCJEYXRlLnByb3RvdHlwZS5fX3Byb3RvX18iLCAiT2JqZWN0LnByb3RvdHlwZSIpOworc2hv dWxkQmUoIk51bWJlci5wcm90b3R5cGUuX19wcm90b19fIiwgIk9iamVjdC5wcm90b3R5cGUiKTsK K3Nob3VsZEJlKCJPYmplY3QucHJvdG90eXBlLl9fcHJvdG9fXyIsICJudWxsIik7CitzaG91bGRC ZSgiU3RyaW5nLnByb3RvdHlwZS5fX3Byb3RvX18iLCAiT2JqZWN0LnByb3RvdHlwZSIpOworc2hv dWxkQmUoIkFycmF5Ll9fcHJvdG9fXyIsICJPYmplY3QuX19wcm90b19fIik7CitzaG91bGRCZSgi RGF0ZS5fX3Byb3RvX18iLCAiT2JqZWN0Ll9fcHJvdG9fXyIpOworc2hvdWxkQmUoIk51bWJlci5f X3Byb3RvX18iLCAiT2JqZWN0Ll9fcHJvdG9fXyIpOworc2hvdWxkQmUoIlN0cmluZy5fX3Byb3Rv X18iLCAiT2JqZWN0Ll9fcHJvdG9fXyIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1 ZTsK