25555 2009-05-04 15:37:36 -0700 [GTK] webkit_web_navigation_action_get_button() documentation 2009-12-16 09:04:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 0 pochu27 webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 119879 0 pochu27 2009-05-04 15:37:36 -0700 The webkit_web_navigation_action_get_button() could be more clear. It just says it returns the mouse button that raised the action. The first I thought was that it would return a GdkModifierType. kov has told me it just returns 1, 2 or 3, and I have thought the middle button would be 3 and not 2. I think the API description could be more clear. Or maybe I'm just stupid :) 172303 1 44980 mrobinson 2009-12-16 08:41:08 -0800 Created attachment 44980 Documentation improvement 172304 2 webkit.review.bot 2009-12-16 08:44:46 -0800 style-queue ran check-webkit-style on attachment 44980 without any errors. 172308 3 44980 gustavo 2009-12-16 08:53:26 -0800 Comment on attachment 44980 Documentation improvement Awesome. Thanks! 172313 4 44980 commit-queue 2009-12-16 09:04:47 -0800 Comment on attachment 44980 Documentation improvement Clearing flags on attachment: 44980 Committed r52198: <http://trac.webkit.org/changeset/52198> 172314 5 commit-queue 2009-12-16 09:04:52 -0800 All reviewed patches have been landed. Closing bug. 44980 2009-12-16 08:41:08 -0800 2009-12-16 09:04:46 -0800 Documentation improvement 0001-Small-documentation-improvement-for-GTK.patch text/plain 2337 mrobinson RnJvbSA3ZmU4NDFjOWJiZjRiZDRkZmI5ODg3ZTIzNGI1YWJhZmYwOThmYmRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1hcnRpbi5qYW1lcy5yb2JpbnNv bkBnbWFpbC5jb20+CkRhdGU6IFdlZCwgMTYgRGVjIDIwMDkgMTc6MzQ6NDMgKzAxMDAKU3ViamVj dDogW1BBVENIXSBTbWFsbCBkb2N1bWVudGF0aW9uIGltcHJvdmVtZW50IGZvciBHVEsrLgoKLS0t CiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTEg KysrKysrKysrKysKIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYm5hdmlnYXRpb25hY3Rpb24u Y3BwIHwgICAgOSArKysrKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwg MyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktp dC9ndGsvQ2hhbmdlTG9nCmluZGV4IDBhMjY2NWMuLjE4Y2FkYzIgMTAwNjQ0Ci0tLSBhL1dlYktp dC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMDktMTItMTYgIE1hcnRpbiBSb2JpbnNvbiAgPG1hcnRpbi5qYW1lcy5yb2JpbnNvbkBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gd2Via2l0X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9nZXRfYnV0dG9uKCkgZG9jdW1l bnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjU1NTUKKworICAgICAgICBTbWFsbCBkb2N1bWVudGF0aW9uIGltcHJvdmVtZW50IGZvciB3ZWJr aXRfd2ViX25hdmlnYXRpb25fYWN0aW9uX2dldF9idXR0b24uCisKKyAgICAgICAgKiB3ZWJraXQv d2Via2l0d2VibmF2aWdhdGlvbmFjdGlvbi5jcHA6CisKIDIwMDktMTItMTMgIFNhbSBXZWluaWcg IDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VibmF2aWdhdGlvbmFjdGlvbi5j cHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJuYXZpZ2F0aW9uYWN0aW9uLmNwcAppbmRl eCBjODY2YzBmLi5mNDIxZjQwIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJuYXZpZ2F0aW9uYWN0aW9uLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJu YXZpZ2F0aW9uYWN0aW9uLmNwcApAQCAtMTc3LDcgKzE3Nyw5IEBAIHN0YXRpYyB2b2lkIHdlYmtp dF93ZWJfbmF2aWdhdGlvbl9hY3Rpb25fY2xhc3NfaW5pdChXZWJLaXRXZWJOYXZpZ2F0aW9uQWN0 aW9uQ2xhCiAgICAgLyoqCiAgICAgICogV2ViS2l0V2ViTmF2aWdhdGlvbkFjdGlvbjpidXR0b246 CiAgICAgICoKLSAgICAgKiBUaGUgYnV0dG9uIHVzZWQgdG8gY2xpY2sgaWYgdGhlIGFjdGlvbiB3 YXMgYSBtb3VzZSBldmVudC4KKyAgICAgKiBUaGUgRE9NIGlkZW50aWZpZXIgZm9yIHRoZSBtb3Vz ZSBidXR0b24gdXNlZCB0byBjbGljay4gRE9NIGJ1dHRvbiB2YWx1ZXMKKyAgICAgKiBhcmUgMCwg MSBhbmQgMiBmb3IgbGVmdCwgbWlkZGxlIGFuZCByaWdodCBidXR0b25zLiBJZiB0aGUgYWN0aW9u IHdhcyBub3QKKyAgICAgKiBpbml0aWF0ZWQgYnkgYSBtb3VzZSBjbGljayB0aGUgdmFsdWUgd2ls bCBiZSAtMS4KICAgICAgKgogICAgICAqIFNpbmNlOiAxLjAuMwogICAgICAqLwpAQCAtMzA4LDgg KzMxMCw5IEBAIHZvaWQgd2Via2l0X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9zZXRfb3JpZ2luYWxf dXJpKFdlYktpdFdlYk5hdmlnYXRpb25BY3Rpb24qIG5hCiAgKiB3ZWJraXRfd2ViX25hdmlnYXRp b25fYWN0aW9uX2dldF9idXR0b246CiAgKiBAbmF2aWdhdGlvbkFjdGlvbjogYSAjV2ViS2l0V2Vi TmF2aWdhdGlvbkFjdGlvbgogICoKLSAqIFJldHVybnMgdGhlIG1vdXNlIGJ1dHRvbiB1c2VkIHRv IGNsaWNrIGlmIHRoZSBhY3Rpb24gd2FzIGEgbW91c2UgZXZlbnQuCi0gKiBPdGhlcndpc2UgcmV0 dXJucyAtMS4KKyAqIFJldHVybnMgdGhlIERPTSBpZGVudGlmaWVyIGZvciB0aGUgbW91c2UgYnV0 dG9uIHVzZWQgdG8gY2xpY2suCisgKiBET00gYnV0dG9uIHZhbHVlcyBhcmUgMCwgMSBhbmQgMiBm b3IgbGVmdCwgbWlkZGxlIGFuZCByaWdodCBidXR0b25zLgorICogSWYgdGhlIGFjdGlvbiB3YXMg bm90IGluaXRpYXRlZCBieSBhIG1vdXNlIGNsaWNrLCByZXR1cm5zIC0xLgogICoKICAqIFJldHVy biB2YWx1ZTogdGhlIG1vdXNlIGJ1dHRvbiB1c2VkIHRvIGNsaWNrCiAgKgotLSAKMS42LjAuNAoK