255473 2023-04-14 16:10:46 -0700 Plumb shape detection API to the GPU Process 2023-04-20 14:13:12 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=255746 InRadar P2 Normal --- 255635 1 mmaxfield mmaxfield fujii sabouhallawa webkit-bug-importer oldest_to_newest 1948897 0 mmaxfield 2023-04-14 16:10:46 -0700 Plumb shape detection API to the GPU Process 1948898 1 webkit-bug-importer 2023-04-14 16:12:31 -0700 <rdar://problem/108070184> 1948906 2 mmaxfield 2023-04-14 16:40:28 -0700 Pull request: https://github.com/WebKit/WebKit/pull/12765 1949572 3 ews-feeder 2023-04-18 14:08:06 -0700 Committed 263094@main (f2195aa52bec): <https://commits.webkit.org/263094@main> Reviewed commits have been landed. Closing PR #12765 and removing active labels. 1949625 4 fujii 2023-04-18 18:17:09 -0700 It broke Windows port. https://build.webkit.org/#/builders/729/builds/4229 FAILED: bin64/WebKit2.dll lib64/WebKit2.lib cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll --intdir=Source\WebKit\CMakeFiles\WebKit.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\x64\mt.exe" --manifests -- C:\MSVS\VC\Tools\MSVC\14.34.31933\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\WebKit.rsp /out:bin64\WebKit2.dll /implib:lib64\WebKit2.lib /pdb:bin64\WebKit2.pdb /dll /version:0.0 /machine:x64 /DEBUG /OPT:ICF /OPT:REF /OPT:NOREF /OPT:NOICF /INCREMENTAL:NO /debug /INCREMENTAL /INCREMENTAL:NO && cd ." LINK Pass 1: command "C:\MSVS\VC\Tools\MSVC\14.34.31933\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\WebKit.rsp /out:bin64\WebKit2.dll /implib:lib64\WebKit2.lib /pdb:bin64\WebKit2.pdb /dll /version:0.0 /machine:x64 /DEBUG /OPT:ICF /OPT:REF /OPT:NOREF /OPT:NOICF /INCREMENTAL:NO /debug /INCREMENTAL /INCREMENTAL:NO /MANIFEST /MANIFESTFILE:Source\WebKit\CMakeFiles\WebKit.dir/intermediate.manifest Source\WebKit\CMakeFiles\WebKit.dir/manifest.res" failed (exit code 1120) with the following output: GeneratedSerializers.cpp.obj : error LNK2005: "bool __cdecl WTF::isValidEnum<enum WebCore::ShapeDetection::BarcodeFormat,void>(unsigned char)" (??$isValidEnum@W4BarcodeFormat@ShapeDetection@WebCore@@X@WTF@@YA_NE@Z) already defined in RemoteRenderingBackendMessageReceiver.cpp.obj Creating library lib64\WebKit2.lib and object lib64\WebKit2.exp UnifiedSource-54928a2b-27.cpp.obj : error LNK2019: unresolved external symbol "public: bool __cdecl IPC::MessageSender::send<class Messages::WebPageProxy::StartURLSchemeTask>(class Messages::WebPageProxy::StartURLSchemeTask &&)" (??$send@VStartURLSchemeTask@WebPageProxy@Messages@@@MessageSender@IPC@@QEAA_N$$QEAVStartURLSchemeTask@WebPageProxy@Messages@@@Z) referenced in function "public: void __cdecl WebKit::WebURLSchemeTaskProxy::startLoading(void)" (?startLoading@WebURLSchemeTaskProxy@WebKit@@QEAAXXZ) UnifiedSource-54928a2b-27.cpp.obj : error LNK2019: unresolved external symbol "public: bool __cdecl IPC::MessageSender::send<class Messages::WebPageProxy::StopURLSchemeTask>(class Messages::WebPageProxy::StopURLSchemeTask &&)" (??$send@VStopURLSchemeTask@WebPageProxy@Messages@@@MessageSender@IPC@@QEAA_N$$QEAVStopURLSchemeTask@WebPageProxy@Messages@@@Z) referenced in function "public: void __cdecl WebKit::WebURLSchemeTaskProxy::stopLoading(void)" (?stopLoading@WebURLSchemeTaskProxy@WebKit@@QEAAXXZ) bin64\WebKit2.dll : fatal error LNK1120: 2 unresolved externals This doesn't seem to be a simple problem. I'm going to revert. 1949634 5 fujii 2023-04-18 18:44:15 -0700 263111@main reverted it. MessageSender::send problem is a simple problem. But, isValidEnum problem is so weird. diff --git a/Source/WebKit/WebProcess/WebPage/WebURLSchemeTaskProxy.cpp b/Source/WebKit/WebProcess/WebPage/WebURLSchemeTaskProxy.cpp index 0c1ef8d82b96..2429106c8c3c 100644 --- a/Source/WebKit/WebProcess/WebPage/WebURLSchemeTaskProxy.cpp +++ b/Source/WebKit/WebProcess/WebPage/WebURLSchemeTaskProxy.cpp @@ -27,6 +27,7 @@ #include "WebURLSchemeTaskProxy.h" #include "Logging.h" +#include "MessageSenderInlines.h" #include "URLSchemeTaskParameters.h" #include "WebCoreArgumentCoders.h" #include "WebFrame.h" 1949640 6 fujii 2023-04-18 19:23:54 -0700 clang-cl also fails to link: [6396/6554] Linking CXX shared library bin64\WebKit2.dll FAILED: bin64/WebKit2.dll lib64/WebKit2.lib cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_dll --intdir=Source\WebKit\CMakeFiles\WebKit.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests -- C:\PROGRA~1\LLVM\bin\lld-link.exe /nologo @CMakeFiles\WebKit.rsp /out:bin64\WebKit2.dll /implib:lib64\WebKit2.lib /pdb:bin64\WebKit2.pdb /dll /version:0.0 /machine:x64 /DEBUG /OPT:ICF /OPT:REF /OPT:NOREF /OPT:NOICF /INCREMENTAL:NO /debug /INCREMENTAL /INCREMENTAL:NO && cd ." LINK Pass 1: command "C:\PROGRA~1\LLVM\bin\lld-link.exe /nologo @CMakeFiles\WebKit.rsp /out:bin64\WebKit2.dll /implib:lib64\WebKit2.lib /pdb:bin64\WebKit2.pdb /dll /version:0.0 /machine:x64 /DEBUG /OPT:ICF /OPT:REF /OPT:NOREF /OPT:NOICF /INCREMENTAL:NO /debug /INCREMENTAL /INCREMENTAL:NO /MANIFEST /MANIFESTFILE:Source\WebKit\CMakeFiles\WebKit.dir/intermediate.manifest Source\WebKit\CMakeFiles\WebKit.dir/manifest.res" failed (exit code 1) with the following output: lld-link: error: duplicate symbol: bool __cdecl WTF::isValidEnum<enum WebCore::ShapeDetection::BarcodeFormat, void>(unsigned char) >>> defined at C:\home\webkit\gc\WebKitBuild\Debug\WTF\Headers\wtf\EnumTraits.h:57 >>> Source\WebKit\CMakeFiles\WebKit.dir\__\__\WebKit\DerivedSources\RemoteRenderingBackendMessageReceiver.cpp.obj >>> defined at Source\WebKit\CMakeFiles\WebKit.dir\__\__\WebKit\DerivedSources\GeneratedSerializers.cpp.obj 1949641 7 mmaxfield 2023-04-18 20:06:37 -0700 Pull request: https://github.com/WebKit/WebKit/pull/12899 1949655 8 ews-feeder 2023-04-18 21:26:18 -0700 Committed 263115@main (5ecd8455a80d): <https://commits.webkit.org/263115@main> Reviewed commits have been landed. Closing PR #12899 and removing active labels.