25535 2009-05-03 21:16:26 -0700 [GTK] object:state-changed:checked events missing for radio buttons and checkboxes 2009-07-30 00:53:46 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned alice.barraclough apinheiro bdakin jhoneycutt mjs walker.willie xan.lopez zecke oldest_to_newest 119768 0 jdiggs 2009-05-03 21:16:26 -0700 Steps to reproduce: 1. Open the (to be) attached test case. 2. In Accerciser, select WebKit (or Epiphany) in the list of accessibles in the left-hand pane. In the right-hand pane, switch to the Event Monitor. Select "Selected application" as the source and object->state-changed as the event type to monitor. 3. With event monitoring enabled, return focus to WebKit (or Epiphany). Toggle the state of the checkboxes and radio buttons. Expected results: Each time the state is toggled, an object:state-changed:checked event would be emitted with detail1 indicating the state (0 == unchecked; 1 == checked). Actual results: no object:state-changed:checked events are emitted. 119769 1 29984 jdiggs 2009-05-03 21:17:39 -0700 Created attachment 29984 aforementioned test case 126442 2 31410 xan.lopez 2009-06-17 06:28:40 -0700 Created attachment 31410 statechangedchecked.patch Implement the signal. I'm not sure if adding the AX notification stuff in HTMLInputElement is OK, but it seemed like the most sensible place I could find. Suggestions welcome! 126853 3 eric 2009-06-18 18:25:35 -0700 CCing Jon so he sees this go by. 130378 4 zecke 2009-07-07 23:24:50 -0700 I think this is a great change. On the down side no one in WebCore/html is doing something like this. You should really try to grab someone on irc to get this in. 135792 5 31410 mjs 2009-07-30 00:42:20 -0700 Comment on attachment 31410 statechangedchecked.patch Accessibility notifications right now are posted from all over the code. It might be good to rationalize them (maybe they should all come from the render tree), but for now this seems like a sensible approach. I wonder if other AX back ends need to react to this notification too. 135793 6 xan.lopez 2009-07-30 00:53:46 -0700 Thanks, I've landed this in r46574 with a small comment explaining why do we emit the notifications from the DOM tree. 29984 2009-05-03 21:17:39 -0700 2009-05-03 21:17:39 -0700 aforementioned test case checkboxes-radiobuttons.html text/html 446 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+Q2hlY2tib3hlcyBhbmQgUmFkaW8gQnV0dG9uczwvdGl0bGU+ CjwvaGVhZD4KPGJvZHk+Cjxmb3JtPgo8cD5DaGVjayBvbmUgb3IgbW9yZTo8L3A+CjxpbnB1dCBp ZD0iY2IxIiB0eXBlPSJjaGVja2JveCIgLz48bGFiZWwgZm9yPSJjYjEiPlJlZDwvbGFiZWw+Cjxp bnB1dCBpZD0iY2IyIiB0eXBlPSJjaGVja2JveCIgLz48bGFiZWwgZm9yPSJjYjIiPkJsdWU8L2xh YmVsPgo8aW5wdXQgaWQ9ImNiMyIgdHlwZT0iY2hlY2tib3giIC8+PGxhYmVsIGZvcj0iY2IzIj5H cmVlbjwvbGFiZWw+CjxwPlllcyBvciBubz88L3A+CjxpbnB1dCBuYW1lPSJyZzEiIHZhbHVlPSJZ IiB0eXBlPSJyYWRpbyI+WWVzPC9pbnB1dD4KPGlucHV0IG5hbWU9InJnMSIgIHZhbHVlPSJOIiB0 eXBlPSJyYWRpbyI+Tm88L2lucHV0Pgo8L2Zvcm0+CjwvYm9keT4KPC9odG1sPgo= 31410 2009-06-17 06:28:40 -0700 2009-07-30 00:42:20 -0700 statechangedchecked.patch statechangedchecked.patch text/plain 3584 xan.lopez RnJvbSA5OTQzNTRlOTcyNjQxMmMxYWIzNjAyYjI1NjA5MjU4MmNlMmNlZTNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX ZWQsIDE3IEp1biAyMDA5IDE2OjI2OjE3ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNi0x NyAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU1MzUKICAgICAgICBbR1RLXSBvYmplY3Q6c3RhdGUtY2hhbmdlZDpjaGVja2VkIGV2 ZW50cyBtaXNzaW5nIGZvciByYWRpbyBidXR0b25zIGFuZCBjaGVja2JveGVzCgogICAgICAgIElt cGxlbWVudCBzdGF0ZS1jaGFuZ2VkOmNoZWNrZWQgZm9yIHJhZGlvIGJ1dHRvbnMgYW5kIGNoZWNr Ym94ZXMuCgogICAgICAgICogYWNjZXNzaWJpbGl0eS9ndGsvQVhPYmplY3RDYWNoZUF0ay5jcHA6 CiAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnBvc3RQbGF0Zm9ybU5vdGlmaWNhdGlv bik6CiAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgogICAgICAgIChXZWJDb3Jl OjpIVE1MSW5wdXRFbGVtZW50OjpzZXRDaGVja2VkKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2d0ay9BWE9iamVjdENhY2hlQXRrLmNwcCB8ICAgIDcgKysrKysrLQog V2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwICAgICAgICAgICAgICB8ICAgIDQgKysr KwogMyBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE5 MjIzYS4uZmFjOTY2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgogCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNTUzNQorICAgICAgICBbR1RLXSBvYmplY3Q6c3RhdGUtY2hhbmdlZDpjaGVja2VkIGV2 ZW50cyBtaXNzaW5nIGZvciByYWRpbyBidXR0b25zIGFuZCBjaGVja2JveGVzCisKKyAgICAgICAg SW1wbGVtZW50IHN0YXRlLWNoYW5nZWQ6Y2hlY2tlZCBmb3IgcmFkaW8gYnV0dG9ucyBhbmQgY2hl Y2tib3hlcy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FYT2JqZWN0Q2FjaGVBdGsu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6cG9zdFBsYXRmb3JtTm90aWZp Y2F0aW9uKToKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c2V0Q2hlY2tlZCk6CisKKzIwMDktMDYtMTcgIFhh biBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNTUyNgogICAgICAgICBbR3RrXSBBZGRpdGlvbmFsIHN1cHBvcnQgaXMgbmVlZGVkIGZv ciBjYXJldCBicm93c2luZwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3Rr L0FYT2JqZWN0Q2FjaGVBdGsuY3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BWE9iamVj dENhY2hlQXRrLmNwcAppbmRleCAyNTY2NWIxLi5hMDQzNjdmIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvZ3RrL0FYT2JqZWN0Q2FjaGVBdGsuY3BwCisrKyBiL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9ndGsvQVhPYmplY3RDYWNoZUF0ay5jcHAKQEAgLTM3LDggKzM3LDEzIEBAIHZv aWQgQVhPYmplY3RDYWNoZTo6YXR0YWNoV3JhcHBlcihBY2Nlc3NpYmlsaXR5T2JqZWN0KiBvYmop CiAgICAgZ19vYmplY3RfdW5yZWYoYXRrT2JqKTsKIH0KIAotdm9pZCBBWE9iamVjdENhY2hlOjpw b3N0UGxhdGZvcm1Ob3RpZmljYXRpb24oQWNjZXNzaWJpbGl0eU9iamVjdCosIGNvbnN0IFN0cmlu ZyYpCit2b2lkIEFYT2JqZWN0Q2FjaGU6OnBvc3RQbGF0Zm9ybU5vdGlmaWNhdGlvbihBY2Nlc3Np YmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0LCBjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiB7CisgICAg aWYgKG1lc3NhZ2UgPT0gIkFYQ2hlY2tlZFN0YXRlQ2hhbmdlZCIpIHsKKyAgICAgICAgaWYgKCFj b3JlT2JqZWN0LT5pc0NoZWNrYm94T3JSYWRpbygpKQorICAgICAgICAgICAgcmV0dXJuOworICAg ICAgICBnX3NpZ25hbF9lbWl0X2J5X25hbWUoY29yZU9iamVjdC0+d3JhcHBlcigpLCAic3RhdGUt Y2hhbmdlIiwgImNoZWNrZWQiLCBjb3JlT2JqZWN0LT5pc0NoZWNrZWQoKSk7CisgICAgfQogfQog ICAgIAogdm9pZCBBWE9iamVjdENhY2hlOjpoYW5kbGVGb2N1c2VkVUlFbGVtZW50Q2hhbmdlZCgp CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKaW5kZXggZGJjODE4Yi4uYTRjN2Q5NiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZp Zy5oIgogI2luY2x1ZGUgIkhUTUxJbnB1dEVsZW1lbnQuaCIKIAorI2luY2x1ZGUgIkFYT2JqZWN0 Q2FjaGUuaCIKICNpbmNsdWRlICJDU1NQcm9wZXJ0eU5hbWVzLmgiCiAjaW5jbHVkZSAiQ2hyb21l Q2xpZW50LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKQEAgLTg4NSw2ICs4ODYsOSBAQCB2b2lk IEhUTUxJbnB1dEVsZW1lbnQ6OnNldENoZWNrZWQoYm9vbCBub3dDaGVja2VkLCBib29sIHNlbmRD aGFuZ2VFdmVudCkKICAgICBpZiAocmVuZGVyZXIoKSAmJiByZW5kZXJlcigpLT5zdHlsZSgpLT5o YXNBcHBlYXJhbmNlKCkpCiAgICAgICAgIHRoZW1lKCktPnN0YXRlQ2hhbmdlZChyZW5kZXJlcigp LCBDaGVja2VkU3RhdGUpOwogCisgICAgaWYgKHJlbmRlcmVyKCkgJiYgQVhPYmplY3RDYWNoZTo6 YWNjZXNzaWJpbGl0eUVuYWJsZWQoKSkKKyAgICAgICAgcmVuZGVyZXIoKS0+ZG9jdW1lbnQoKS0+ YXhPYmplY3RDYWNoZSgpLT5wb3N0Tm90aWZpY2F0aW9uKHJlbmRlcmVyKCksICJBWENoZWNrZWRT dGF0ZUNoYW5nZWQiLCB0cnVlKTsKKwogICAgIC8vIE9ubHkgc2VuZCBhIGNoYW5nZSBldmVudCBm b3IgaXRlbXMgaW4gdGhlIGRvY3VtZW50IChhdm9pZCBmaXJpbmcgZHVyaW5nCiAgICAgLy8gcGFy c2luZykgYW5kIGRvbid0IHNlbmQgYSBjaGFuZ2UgZXZlbnQgZm9yIGEgcmFkaW8gYnV0dG9uIHRo YXQncyBnZXR0aW5nCiAgICAgLy8gdW5jaGVja2VkIHRvIG1hdGNoIG90aGVyIGJyb3dzZXJzLiBE T00gaXMgbm90IGEgdXNlZnVsIHN0YW5kYXJkIGZvciB0aGlzCi0tIAoxLjYuMy4xCgo=