25523 2009-05-03 12:29:40 -0700 The text displayed by push buttons is not exposed to assistive technologies 2009-07-27 14:16:09 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux VERIFIED FIXED Gtk P2 Normal --- 25531 1 jdiggs webkit-unassigned apinheiro jmalonzo mario walker.willie xan.lopez oldest_to_newest 119727 0 jdiggs 2009-05-03 12:29:40 -0700 Step to reproduce: 1. Examine the two push buttons in the (to be) attached test case using WebKit and Accerciser. Expected result: The text displayed for each push button (i.e. "Clear" and "Submit") would be exposed to assistive technologies. Actual result: The text displayed for each push button does not seem to be exposed at all to assistive technologies. Recommendation: Please expose the text displayed by a push button as the accessible name of that button. Thanks! 119728 1 29965 jdiggs 2009-05-03 12:30:50 -0700 Created attachment 29965 aforementioned test case 126445 2 xan.lopez 2009-06-17 06:51:19 -0700 (In reply to comment #0) > Recommendation: Please expose the text displayed by a push button as the > accessible name of that button. Thanks! > Do you mean the accessible name from AtkObject or the accessible name from AtkAction? 126459 3 jdiggs 2009-06-17 08:33:22 -0700 (In reply to comment #2) > (In reply to comment #0) > > Recommendation: Please expose the text displayed by a push button as the > > accessible name of that button. Thanks! > > > > Do you mean the accessible name from AtkObject or the accessible name from > AtkAction? > AtkObject. The AtkAction would be press or click or something like that. 132276 4 32877 mario 2009-07-16 09:18:36 -0700 Created attachment 32877 Patch proposal Added new public method text to RenderButton and used from AccessibilityRenderObject::stringValue() to expose the 'name' property of AtkObject. 132302 5 jdiggs 2009-07-16 11:18:25 -0700 (In reply to comment #4) > Created an attachment (id=32877) [details] > Patch proposal > > Added new public method text to RenderButton and used from > AccessibilityRenderObject::stringValue() to expose the 'name' property of > AtkObject. Tested with both Accerciser and Orca. That certainly solves the problem for me. Thanks!! 132518 6 32877 jmalonzo 2009-07-17 02:04:47 -0700 Comment on attachment 32877 Patch proposal > From 6a309cb208545a60ecf5281d93ef85d66ae4cb1a Mon Sep 17 00:00:00 2001 > From: Mario Sanchez Prada <msanchez@igalia.com> > Date: Thu, 16 Jul 2009 15:38:26 +0200 > Subject: [PATCH] 2009-07-16 Mario Sanchez Prada <msanchez@igalia.com> > MIME-Version: 1.0 > Content-Type: multipart/mixed; boundary="------------1.6.0.4" > > This is a multi-part message in MIME format. > --------------1.6.0.4 > Content-Type: text/plain; charset=UTF-8; format=fixed > Content-Transfer-Encoding: 8bit > > > Reviewed by NOBODY (OOPS!). > > https://bugs.webkit.org/show_bug.cgi?id=25523 > [GTK] The text displayed by push buttons is not exposed to assistive technologies > > Add new public method text to RenderButton and use it from > AccessibilityRenderObject::stringValue(). Hi Mario. This patch requires a ChangeLog. > +String RenderButton::text() const > +{ > + return m_buttonText ? m_buttonText->text() : 0; > +} > + This can be inlined in RenderButton.h. And also, RenderButton::text() should return const String instead of just String. 132527 7 mario 2009-07-17 02:57:31 -0700 (In reply to comment #6) > Hi Mario. This patch requires a ChangeLog. Ok, I'll send a patch with the ChangeLog modified, although I'm afraid I still could not fill myself the "Reviewed by <reviewer>" line, so I'll leave a placeholder there. Or is there a better way to do this? (I'm new contributing to Webkit so any tip here would be appreciated) > > +String RenderButton::text() const > > +{ > > + return m_buttonText ? m_buttonText->text() : 0; > > +} > > + > > This can be inlined in RenderButton.h. And also, RenderButton::text() should > return const String instead of just String. I did it this way as that's how I've seen it's done in other places, such as RenderMenuList.[h|cpp]. Anyway, I've no problem in implementing it as an inline funcion in the .h file if that's ok. I'll come up in some minutes with a new patch addressing these issues then. 132529 8 jmalonzo 2009-07-17 03:22:29 -0700 (In reply to comment #7) > (In reply to comment #6) > > Hi Mario. This patch requires a ChangeLog. > > Ok, I'll send a patch with the ChangeLog modified, although I'm afraid I still > could not fill myself the "Reviewed by <reviewer>" line, so I'll leave a > placeholder there. > > Or is there a better way to do this? (I'm new contributing to Webkit so any tip > here would be appreciated) Please use WebKitTools/Scripts/prepare-ChangeLog. There are also some notes in http://webkit.org/coding/contributing.html on how to contribute. I would also suggest to make the patch description more verbose so other reviewers will notice that the patch applies to platform-independent code even though it's against the Gtk port. Thanks. 132537 9 mario 2009-07-17 04:09:43 -0700 (In reply to comment #8) > [...] > Please use WebKitTools/Scripts/prepare-ChangeLog. There are also some notes in > http://webkit.org/coding/contributing.html on how to contribute. > > I would also suggest to make the patch description more verbose so other > reviewers will notice that the patch applies to platform-independent code even > though it's against the Gtk port. Thank. Just a quick question: when setting the 'review:?' flag, who should I put in the Requestee field? Should I put one specific WebKit reviewer (e.g. Xan Lopez) or should I leave it blank? 132546 10 jmalonzo 2009-07-17 05:06:21 -0700 (In reply to comment #9) > (In reply to comment #8) > > [...] > > Please use WebKitTools/Scripts/prepare-ChangeLog. There are also some notes in > > http://webkit.org/coding/contributing.html on how to contribute. > > > > I would also suggest to make the patch description more verbose so other > > reviewers will notice that the patch applies to platform-independent code even > > though it's against the Gtk port. > > Thank. Just a quick question: when setting the 'review:?' flag, who should I > put in the Requestee field? Should I put one specific WebKit reviewer (e.g. Xan > Lopez) or should I leave it blank? We usually just leave it blank unless we really think that the patch needs to be reviewed by someone with the expertise in the area where code is being modified. 132548 11 mario 2009-07-17 05:14:51 -0700 (In reply to comment #10) > We usually just leave it blank unless we really think that the patch needs to > be reviewed by someone with the expertise in the area where code is being > modified. Ok, I'll attach the patch then leaving tha field blank. Thanks! 132549 12 32932 mario 2009-07-17 05:23:53 -0700 Created attachment 32932 Patch proposal New version of the patch attached. Please notice it touches platform-independent code, even though it's motivated because of a WebKitGtk a11y bug. (In reply to comment #7) > > This can be inlined in RenderButton.h. And also, RenderButton::text() should > > return const String instead of just String. > > I did it this way as that's how I've seen it's done in other places, such as > RenderMenuList.[h|cpp]. Anyway, I've no problem in implementing it as an inline > funcion in the .h file if that's ok. At last, I did not add the method as inline because its implementation relies on the private attribute 'RenderTextFragment* m_buttonText' (m_buttonText->text() is used) and that class is not available at compilation time when compiling the RenderButton.h file, so it fails to compile. Therefore, I've leave it as it was right now (same way than in RenderMenuList.[h|cpp]), just adding the 'const' modifier to the return value of the function. 132593 13 32946 mario 2009-07-17 09:22:14 -0700 Created attachment 32946 Add new public method text() to RenderButton and use it from AccessibilityRenderObject::stringValue(). Fixed indentation issue in previous patch 132690 14 jmalonzo 2009-07-17 14:05:45 -0700 Removed [Gtk] as the code change is not Gtk-specific. 132835 15 32946 jmalonzo 2009-07-17 19:48:15 -0700 Comment on attachment 32946 Add new public method text() to RenderButton and use it from AccessibilityRenderObject::stringValue(). > - > + const String text() const; > + I stand corrected and it should return a String not const String. The reason is because RenderText::text() doesn't return a const String (RenderMenuList return a String for RenderMenuList::text() as well, not const String). r=me with changing it back to just String. 132837 16 jmalonzo 2009-07-17 20:03:52 -0700 (In reply to comment #15) > (From update of attachment 32946 [details]) > > - > > + const String text() const; > > + > > I stand corrected and it should return a String not const String. The reason is > because RenderText::text() doesn't return a const String (RenderMenuList return > a String for RenderMenuList::text() as well, not const String). > > r=me with changing it back to just String. Landed as http://trac.webkit.org/changeset/46080 135013 17 jdiggs 2009-07-27 14:16:09 -0700 Verifying. Thanks! 29965 2009-05-03 12:30:50 -0700 2009-05-03 12:30:50 -0700 aforementioned test case alt-and-title.html text/html 607 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+QWx0IFRleHQgYW5kIFRpdGxlczwvdGl0bGU+CjwvaGVhZD4K PGJvZHk+Cgo8aW1nIHNyYz0iaHR0cDovL2xpdmUuZ25vbWUub3JnL09yY2E/YWN0aW9uPUF0dGFj aEZpbGUmZG89Z2V0JnRhcmdldD1vcmNhMi1zbS5qcGciIGFsdD0iT3JjYSIgdGl0bGU9IlRoZSBs b2dvIG9mIE9yY2EsIHNjcmVlbiByZWFkZXIgZm9yIHRoZSBHTk9NRSBkZXNrdG9wIGVudmlvcm5t ZW50IiAvPgo8Zm9ybT4KICA8YSBocmVmPSIiIHRpdGxlPSJpLmUuIHRoZSBudW1iZXIgb2YgeW91 ciBwaG9uZSA6LSkiPlBob25lIG51bWJlcjwvYT46IDxpbnB1dCB0eXBlPSJ0ZXh0IiBuYW1lPSJw aG5vIiB0aXRsZT0iRW50ZXIgeW91ciBwaG9uZSBudW1iZXIgd2l0aG91dCBhbnkgcHVuY3R1YXRp b24iIC8+CiAgPGlucHV0IHR5cGU9InJlc2V0IiB2YWx1ZT0iQ2xlYXIiIC8+CiAgPGlucHV0IHR5 cGU9InN1Ym1pdCIgdmFsdWU9IlN1Ym1pdCIgdGl0bGU9IklmIHlvdSBuZWVkIGEgdG9vbHRpcCB0 byB0ZWxsIHlvdSB0byBwcmVzcyB0aGlzIGJ1dHRvbiwgd2UgZG9uJ3Qgd2FudCB5b3VyIHBob25l IG51bWJlci4iIC8+CjwvZm9ybT4KPC9ib2R5Pgo8L2h0bWw+Cg== 32877 2009-07-16 09:18:36 -0700 2009-07-17 05:23:53 -0700 Patch proposal 0001-2009-07-16-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2959 mario RnJvbSA2YTMwOWNiMjA4NTQ1YTYwZWNmNTI4MWQ5M2VmODVkNjZhZTRjYjFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDE2IEp1bCAyMDA5IDE1OjM4OjI2ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAwOS0wNy0xNiAgTWFyaW8gU2FuY2hleiBQcmFkYSA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K TUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiBtdWx0aXBhcnQvbWl4ZWQ7IGJvdW5kYXJ5 PSItLS0tLS0tLS0tLS0xLjYuMC40IgoKVGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBN SU1FIGZvcm1hdC4KLS0tLS0tLS0tLS0tLS0xLjYuMC40CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFp bjsgY2hhcnNldD1VVEYtODsgZm9ybWF0PWZpeGVkCkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6 IDhiaXQKCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCmh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNTUyMwpbR1RLXSBUaGUgdGV4dCBkaXNwbGF5ZWQgYnkgcHVz aCBidXR0b25zIGlzIG5vdCBleHBvc2VkIHRvIGFzc2lzdGl2ZSB0ZWNobm9sb2dpZXMKCkFkZCBu ZXcgcHVibGljIG1ldGhvZCB0ZXh0IHRvIFJlbmRlckJ1dHRvbiBhbmQgdXNlIGl0IGZyb20KQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c3RyaW5nVmFsdWUoKS4KLS0tCiAuLi4vYWNjZXNzaWJp bGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcCAgICB8ICAgIDQgKysrKwogV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmNwcCAgICAgICAgICAgICAgICAgfCAgICA1ICsrKysr CiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uaCAgICAgICAgICAgICAgICAgICB8ICAg IDMgKystCiAzIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0p CgoKLS0tLS0tLS0tLS0tLS0xLjYuMC40CkNvbnRlbnQtVHlwZTogdGV4dC94LXBhdGNoOyBuYW1l PSI2YTMwOWNiMjA4NTQ1YTYwZWNmNTI4MWQ5M2VmODVkNjZhZTRjYjFhLmRpZmYiCkNvbnRlbnQt VHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKQ29udGVudC1EaXNwb3NpdGlvbjogYXR0YWNobWVudDsg ZmlsZW5hbWU9IjZhMzA5Y2IyMDg1NDVhNjBlY2Y1MjgxZDkzZWY4NWQ2NmFlNGNiMWEuZGlmZiIK CmRpZmYgLS1naXQgYS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9i amVjdC5jcHAgYi9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAKaW5kZXggN2QyZGRjNS4uNjVhMWE3ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCisrKyBiL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcApAQCAtNTUsNiArNTUsNyBAQAog I2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKICNpbmNsdWRlICJOb2RlTGlzdC5oIgogI2lu Y2x1ZGUgIlBhZ2UuaCIKKyNpbmNsdWRlICJSZW5kZXJCdXR0b24uaCIKICNpbmNsdWRlICJSZW5k ZXJGaWVsZHNldC5oIgogI2luY2x1ZGUgIlJlbmRlckZpbGVVcGxvYWRDb250cm9sLmgiCiAjaW5j bHVkZSAiUmVuZGVySFRNTENhbnZhcy5oIgpAQCAtNzczLDYgKzc3NCw5IEBAIFN0cmluZyBBY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzdHJpbmdWYWx1ZSgpIGNvbnN0CiAgICAgaWYgKG1fcmVu ZGVyZXItPmlzTGlzdE1hcmtlcigpKQogICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8UmVuZGVy TGlzdE1hcmtlcio+KG1fcmVuZGVyZXIpLT50ZXh0KCk7CiAgICAgCisgICAgaWYgKG1fcmVuZGVy ZXItPmlzUmVuZGVyQnV0dG9uKCkpCisgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxSZW5kZXJC dXR0b24qPihtX3JlbmRlcmVyKS0+dGV4dCgpOworCiAgICAgaWYgKGlzV2ViQXJlYSgpKSB7CiAg ICAgICAgIGlmIChtX3JlbmRlcmVyLT5kb2N1bWVudCgpLT5mcmFtZSgpKQogICAgICAgICAgICAg cmV0dXJuIFN0cmluZygpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0 dG9uLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5jcHAKaW5kZXggYjI2NmY0 Mi4uNmQzNmEwZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmNw cAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uY3BwCkBAIC0xNjQsNiArMTY0 LDExIEBAIHZvaWQgUmVuZGVyQnV0dG9uOjpzZXRUZXh0KGNvbnN0IFN0cmluZyYgc3RyKQogICAg IH0KIH0KIAorU3RyaW5nIFJlbmRlckJ1dHRvbjo6dGV4dCgpIGNvbnN0Cit7CisgICAgcmV0dXJu IG1fYnV0dG9uVGV4dCA/IG1fYnV0dG9uVGV4dC0+dGV4dCgpIDogMDsKK30KKwogdm9pZCBSZW5k ZXJCdXR0b246OnVwZGF0ZUJlZm9yZUFmdGVyQ29udGVudChQc2V1ZG9JZCB0eXBlKQogewogICAg IGlmIChtX2lubmVyKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9u LmggYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uaAppbmRleCA4OWY3Y2Y4Li4zYjRm ZjNmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uaAorKysgYi9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uaApAQCAtNTUsNyArNTUsOCBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBJbnRSZWN0IGNvbnRyb2xDbGlwUmVjdChpbnQgLyp0eCovLCBpbnQgLyp0 eSovKSBjb25zdDsKIAogICAgIHZvaWQgc2V0VGV4dChjb25zdCBTdHJpbmcmKTsKLSAgICAKKyAg ICBTdHJpbmcgdGV4dCgpIGNvbnN0OworCiAgICAgdmlydHVhbCBib29sIGNhbkhhdmVDaGlsZHJl bigpIGNvbnN0OwogCiBwcm90ZWN0ZWQ6CgotLS0tLS0tLS0tLS0tLTEuNi4wLjQtLQoKCg== 32932 2009-07-17 05:23:53 -0700 2009-07-17 09:22:14 -0700 Patch proposal 0001-2009-07-17-Mario-Sanchez-Prada-msanchez-igalia.co.patch text/plain 3379 mario RnJvbSA5MDhkYjU2YzMxMTI5MDZkOGUzMzcxODg2ODhlNDBjNmYwODZmNjMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDE3IEp1bCAyMDA5IDEyOjUyOjU1ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAwOS0wNy0xNyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNTUyMwpbR1RLXSBUaGUgdGV4dCBkaXNwbGF5ZWQgYnkgcHVzaCBidXR0 b25zIGlzIG5vdCBleHBvc2VkIHRvIGFzc2lzdGl2ZSB0ZWNobm9sb2dpZXMKCkFkZCBuZXcgcHVi bGljIG1ldGhvZCB0ZXh0KCkgdG8gUmVuZGVyQnV0dG9uIGFuZCB1c2UgaXQgZnJvbQpBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0OjpzdHJpbmdWYWx1ZSgpLgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysr CiAuLi4vYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcCAgICB8ICAg IDQgKysrKwogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmNwcCAgICAgICAgICAgICAg ICAgfCAgICA1ICsrKysrCiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uaCAgICAgICAg ICAgICAgICAgICB8ICAgIDMgKystCiA0IGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCBkYjIwNjgzLi5jZmE3ZDE3IDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDA5LTA3 LTE3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworCVJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI1NTIzCisJW0dUS10gVGhlIHRleHQgZGlzcGxheWVkIGJ5IHB1c2ggYnV0dG9u cyBpcyBub3QgZXhwb3NlZCB0byBhc3Npc3RpdmUgdGVjaG5vbG9naWVzCisKKwlBZGQgbmV3IHB1 YmxpYyBtZXRob2QgdGV4dCgpIHRvIFJlbmRlckJ1dHRvbiBhbmQgdXNlIGl0IGZyb20KKwlBY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzdHJpbmdWYWx1ZSgpLgorCisgICAgICAgICogYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnN0cmluZ1ZhbHVlKToKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyQnV0dG9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJ1dHRvbjo6 dGV4dCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5oOgorCiAyMDA5LTA3LTE0 ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcCBiL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAppbmRleCA3ZDJkZGM1Li42NWExYTdkIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5j cHAKKysrIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qu Y3BwCkBAIC01NSw2ICs1NSw3IEBACiAjaW5jbHVkZSAiTG9jYWxpemVkU3RyaW5ncy5oIgogI2lu Y2x1ZGUgIk5vZGVMaXN0LmgiCiAjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUgIlJlbmRlckJ1 dHRvbi5oIgogI2luY2x1ZGUgIlJlbmRlckZpZWxkc2V0LmgiCiAjaW5jbHVkZSAiUmVuZGVyRmls ZVVwbG9hZENvbnRyb2wuaCIKICNpbmNsdWRlICJSZW5kZXJIVE1MQ2FudmFzLmgiCkBAIC03NzMs NiArNzc0LDkgQEAgU3RyaW5nIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnN0cmluZ1ZhbHVl KCkgY29uc3QKICAgICBpZiAobV9yZW5kZXJlci0+aXNMaXN0TWFya2VyKCkpCiAgICAgICAgIHJl dHVybiBzdGF0aWNfY2FzdDxSZW5kZXJMaXN0TWFya2VyKj4obV9yZW5kZXJlciktPnRleHQoKTsK ICAgICAKKyAgICBpZiAobV9yZW5kZXJlci0+aXNSZW5kZXJCdXR0b24oKSkKKyAgICAgICAgcmV0 dXJuIHN0YXRpY19jYXN0PFJlbmRlckJ1dHRvbio+KG1fcmVuZGVyZXIpLT50ZXh0KCk7CisKICAg ICBpZiAoaXNXZWJBcmVhKCkpIHsKICAgICAgICAgaWYgKG1fcmVuZGVyZXItPmRvY3VtZW50KCkt PmZyYW1lKCkpCiAgICAgICAgICAgICByZXR1cm4gU3RyaW5nKCk7CmRpZmYgLS1naXQgYS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QnV0dG9uLmNwcAppbmRleCBiMjY2ZjQyLi4wZWU4NWMxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCdXR0b24uY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1 dHRvbi5jcHAKQEAgLTE2NCw2ICsxNjQsMTEgQEAgdm9pZCBSZW5kZXJCdXR0b246OnNldFRleHQo Y29uc3QgU3RyaW5nJiBzdHIpCiAgICAgfQogfQogCitjb25zdCBTdHJpbmcgUmVuZGVyQnV0dG9u Ojp0ZXh0KCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9idXR0b25UZXh0ID8gbV9idXR0b25UZXh0 LT50ZXh0KCkgOiAwOworfQorCiB2b2lkIFJlbmRlckJ1dHRvbjo6dXBkYXRlQmVmb3JlQWZ0ZXJD b250ZW50KFBzZXVkb0lkIHR5cGUpCiB7CiAgICAgaWYgKG1faW5uZXIpCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJ1dHRvbi5oCmluZGV4IDg5ZjdjZjguLjdjZjExN2YgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJ1dHRvbi5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRv bi5oCkBAIC01NSw3ICs1NSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIEludFJlY3QgY29udHJv bENsaXBSZWN0KGludCAvKnR4Ki8sIGludCAvKnR5Ki8pIGNvbnN0OwogCiAgICAgdm9pZCBzZXRU ZXh0KGNvbnN0IFN0cmluZyYpOwotICAgIAorICAgIGNvbnN0IFN0cmluZyB0ZXh0KCkgY29uc3Q7 CisKICAgICB2aXJ0dWFsIGJvb2wgY2FuSGF2ZUNoaWxkcmVuKCkgY29uc3Q7CiAKIHByb3RlY3Rl ZDoKLS0gCjEuNi4wLjQKCg== 32946 2009-07-17 09:22:14 -0700 2009-07-17 19:48:15 -0700 Add new public method text() to RenderButton and use it from AccessibilityRenderObject::stringValue(). 0001-2009-07-17-Mario-Sanchez-Prada-msanchez-igalia.co.patch text/plain 3414 mario RnJvbSBiYWVkZTAxMmY5MTNhYWI2ZmIyNmIyNmI2ZWZjNTg0NDQ0ZmRjYzhlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDE3IEp1bCAyMDA5IDE4OjE1OjUwICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAwOS0wNy0xNyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNTUyMwpbR1RLXSBUaGUgdGV4dCBkaXNwbGF5ZWQgYnkgcHVzaCBidXR0 b25zIGlzIG5vdCBleHBvc2VkIHRvIGFzc2lzdGl2ZSB0ZWNobm9sb2dpZXMKCkFkZCBuZXcgcHVi bGljIG1ldGhvZCB0ZXh0KCkgdG8gUmVuZGVyQnV0dG9uIGFuZCB1c2UgaXQgZnJvbQpBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0OjpzdHJpbmdWYWx1ZSgpLgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysr CiAuLi4vYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcCAgICB8ICAg IDQgKysrKwogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmNwcCAgICAgICAgICAgICAg ICAgfCAgICA1ICsrKysrCiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uaCAgICAgICAg ICAgICAgICAgICB8ICAgIDMgKystCiA0IGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCBkYjIwNjgzLi44Mjc5MDUwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDA5LTA3 LTE3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU1MjMKKyAgICAgICAgW0dUS10gVGhlIHRleHQgZGlz cGxheWVkIGJ5IHB1c2ggYnV0dG9ucyBpcyBub3QgZXhwb3NlZCB0byBhc3Npc3RpdmUgdGVjaG5v bG9naWVzCisKKyAgICAgICAgQWRkIG5ldyBwdWJsaWMgbWV0aG9kIHRleHQoKSB0byBSZW5kZXJC dXR0b24gYW5kIHVzZSBpdCBmcm9tCisgICAgICAgIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6 OnN0cmluZ1ZhbHVlKCkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9i amVjdDo6c3RyaW5nVmFsdWUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCdXR0b24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQnV0dG9uOjp0ZXh0KToKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyQnV0dG9uLmg6CisKIDIwMDktMDctMTQgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVy LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3QuY3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmpl Y3QuY3BwCmluZGV4IDdkMmRkYzUuLjY1YTFhN2QgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAgLTU1LDYgKzU1LDcgQEAK ICNpbmNsdWRlICJMb2NhbGl6ZWRTdHJpbmdzLmgiCiAjaW5jbHVkZSAiTm9kZUxpc3QuaCIKICNp bmNsdWRlICJQYWdlLmgiCisjaW5jbHVkZSAiUmVuZGVyQnV0dG9uLmgiCiAjaW5jbHVkZSAiUmVu ZGVyRmllbGRzZXQuaCIKICNpbmNsdWRlICJSZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5oIgogI2lu Y2x1ZGUgIlJlbmRlckhUTUxDYW52YXMuaCIKQEAgLTc3Myw2ICs3NzQsOSBAQCBTdHJpbmcgQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c3RyaW5nVmFsdWUoKSBjb25zdAogICAgIGlmIChtX3Jl bmRlcmVyLT5pc0xpc3RNYXJrZXIoKSkKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFJlbmRl ckxpc3RNYXJrZXIqPihtX3JlbmRlcmVyKS0+dGV4dCgpOwogICAgIAorICAgIGlmIChtX3JlbmRl cmVyLT5pc1JlbmRlckJ1dHRvbigpKQorICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8UmVuZGVy QnV0dG9uKj4obV9yZW5kZXJlciktPnRleHQoKTsKKwogICAgIGlmIChpc1dlYkFyZWEoKSkgewog ICAgICAgICBpZiAobV9yZW5kZXJlci0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSkKICAgICAgICAgICAg IHJldHVybiBTdHJpbmcoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1 dHRvbi5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uY3BwCmluZGV4IGIyNjZm NDIuLjBlZTg1YzEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5j cHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmNwcApAQCAtMTY0LDYgKzE2 NCwxMSBAQCB2b2lkIFJlbmRlckJ1dHRvbjo6c2V0VGV4dChjb25zdCBTdHJpbmcmIHN0cikKICAg ICB9CiB9CiAKK2NvbnN0IFN0cmluZyBSZW5kZXJCdXR0b246OnRleHQoKSBjb25zdAoreworICAg IHJldHVybiBtX2J1dHRvblRleHQgPyBtX2J1dHRvblRleHQtPnRleHQoKSA6IDA7Cit9CisKIHZv aWQgUmVuZGVyQnV0dG9uOjp1cGRhdGVCZWZvcmVBZnRlckNvbnRlbnQoUHNldWRvSWQgdHlwZSkK IHsKICAgICBpZiAobV9pbm5lcikKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJ1dHRvbi5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmgKaW5kZXggODlmN2Nm OC4uN2NmMTE3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmgK KysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmgKQEAgLTU1LDcgKzU1LDggQEAg cHVibGljOgogICAgIHZpcnR1YWwgSW50UmVjdCBjb250cm9sQ2xpcFJlY3QoaW50IC8qdHgqLywg aW50IC8qdHkqLykgY29uc3Q7CiAKICAgICB2b2lkIHNldFRleHQoY29uc3QgU3RyaW5nJik7Ci0g ICAgCisgICAgY29uc3QgU3RyaW5nIHRleHQoKSBjb25zdDsKKwogICAgIHZpcnR1YWwgYm9vbCBj YW5IYXZlQ2hpbGRyZW4oKSBjb25zdDsKIAogcHJvdGVjdGVkOgotLSAKMS42LjAuNAoK