25520 2009-05-03 01:17:12 -0700 Do not instantiate hidden WebInspector panels. 2009-05-04 10:51:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned dglazkov eric timothy oldest_to_newest 119713 0 pfeldman 2009-05-03 01:17:12 -0700 Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods. 119714 1 29963 pfeldman 2009-05-03 01:19:41 -0700 Created attachment 29963 patch 119715 2 29963 timothy 2009-05-03 03:33:00 -0700 Comment on attachment 29963 patch This looks good. A couple code style things i would like to see changed — that I want to put in our official style rules. 1. Use "===" or "!--" when you know the types already match. 2. Use double quotes fore al string literals. 119716 3 29964 pfeldman 2009-05-03 03:56:18 -0700 Created attachment 29964 post-review patch 119717 4 pfeldman 2009-05-03 04:01:54 -0700 (In reply to comment #2) > (From update of attachment 29963 [review]) > This looks good. A couple code style things i would like to see changed — that > I want to put in our official style rules. > > 1. Use "===" or "!--" when you know the types already match. > 2. Use double quotes fore al string literals. > Done. Interestingly, we only use single quotes for JS and are almost never using === at Google. Talking about the ===, does it give any performance boost? (Or why do you want to enforce it?) 119718 5 pfeldman 2009-05-03 04:11:25 -0700 Dear committers, could you please land tiny patch? (Dmitry, who is usually doing this for me, is going to by out on Monday). 119721 6 timothy 2009-05-03 08:50:58 -0700 (In reply to comment #4) > Done. Interestingly, we only use single quotes for JS and are almost never > using === at Google. Talking about the ===, does it give any performance boost? > (Or why do you want to enforce it?) There is a slight performance increase since it says "i know the types of these two things, don't try to convert them to another type to compare, otherwise be false". 119855 7 pkasting 2009-05-04 10:51:06 -0700 Landed in r43185. 29963 2009-05-03 01:19:41 -0700 2009-05-03 08:48:16 -0700 patch hidden.txt text/plain 2373 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzhjYzYyOC4uZDU3ZmE5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNS0wMyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgRG8gbm90IGluc3RhbnRpYXRlIGhpZGRlbiBXZWJJbnNwZWN0 b3IgcGFuZWxzLiBPdGhlcndpc2UgdGhleSBhcmUgaGl0dGluZyB1bmltcGxlbWVudGVkIEluc3Bl Y3RvckNvbnRyb2xsZXIgbWV0aG9kcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI1NTIwCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2lu c3BlY3Rvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5sb2FkZWQpOgorCiAyMDA5LTA1LTAy ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRl eCBiNzc5YjRkLi5kMTNhOGU1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0 b3IuanMKQEAgLTI3OSwyMiArMjc5LDI0IEBAIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlv bigpCiAgICAgZG9jdW1lbnQuYm9keS5hZGRTdHlsZUNsYXNzKCJwbGF0Zm9ybS0iICsgcGxhdGZv cm0pOwogCiAgICAgdGhpcy5jb25zb2xlID0gbmV3IFdlYkluc3BlY3Rvci5Db25zb2xlKCk7Ci0g ICAgdGhpcy5wYW5lbHMgPSB7Ci0gICAgICAgIGVsZW1lbnRzOiBuZXcgV2ViSW5zcGVjdG9yLkVs ZW1lbnRzUGFuZWwoKSwKLSAgICAgICAgcmVzb3VyY2VzOiBuZXcgV2ViSW5zcGVjdG9yLlJlc291 cmNlc1BhbmVsKCksCi0gICAgICAgIHNjcmlwdHM6IG5ldyBXZWJJbnNwZWN0b3IuU2NyaXB0c1Bh bmVsKCksCi0gICAgICAgIHByb2ZpbGVzOiBuZXcgV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwo KSwKLSAgICAgICAgZGF0YWJhc2VzOiBuZXcgV2ViSW5zcGVjdG9yLkRhdGFiYXNlc1BhbmVsKCkK LSAgICB9OwogCisgICAgdGhpcy5wYW5lbHMgPSB7fTsKICAgICB2YXIgaGlkZGVuUGFuZWxzID0g KEluc3BlY3RvckNvbnRyb2xsZXIuaGlkZGVuUGFuZWxzKCkgfHwgIiIpLnNwbGl0KCcsJyk7Cisg ICAgaWYgKGhpZGRlblBhbmVscy5pbmRleE9mKCdlbGVtZW50cycpID09IC0xKQorICAgICAgICB0 aGlzLnBhbmVscy5lbGVtZW50cyA9IG5ldyBXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbCgpOwor ICAgIGlmIChoaWRkZW5QYW5lbHMuaW5kZXhPZigncmVzb3VyY2VzJykgPT0gLTEpCisgICAgICAg IHRoaXMucGFuZWxzLnJlc291cmNlcyA9IG5ldyBXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwo KTsKKyAgICBpZiAoaGlkZGVuUGFuZWxzLmluZGV4T2YoJ3NjcmlwdHMnKSA9PSAtMSkKKyAgICAg ICAgdGhpcy5wYW5lbHMuc2NyaXB0cyA9IG5ldyBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsKCk7 CisgICAgaWYgKGhpZGRlblBhbmVscy5pbmRleE9mKCdwcm9maWxlcycpID09IC0xKQorICAgICAg ICB0aGlzLnBhbmVscy5wcm9maWxlcyA9IG5ldyBXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbCgp OworICAgIGlmIChoaWRkZW5QYW5lbHMuaW5kZXhPZignZGF0YWJhc2VzJykgPT0gLTEpCisgICAg ICAgIHRoaXMucGFuZWxzLmRhdGFiYXNlcyA9IG5ldyBXZWJJbnNwZWN0b3IuRGF0YWJhc2VzUGFu ZWwoKTsKIAogICAgIHZhciB0b29sYmFyRWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJ0b29sYmFyIik7CiAgICAgdmFyIHByZXZpb3VzVG9vbGJhckl0ZW0gPSB0b29sYmFyRWxlbWVu dC5jaGlsZHJlblswXTsKIAogICAgIGZvciAodmFyIHBhbmVsTmFtZSBpbiB0aGlzLnBhbmVscykg ewotICAgICAgICBpZiAoaGlkZGVuUGFuZWxzLmluZGV4T2YocGFuZWxOYW1lKSAhPT0gLTEpCi0g ICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgdmFyIHBhbmVsID0gdGhpcy5wYW5lbHNbcGFu ZWxOYW1lXTsKICAgICAgICAgdmFyIHBhbmVsVG9vbGJhckl0ZW0gPSBwYW5lbC50b29sYmFySXRl bTsKICAgICAgICAgcGFuZWxUb29sYmFySXRlbS5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRo aXMuX3Rvb2xiYXJJdGVtQ2xpY2tlZC5iaW5kKHRoaXMpKTsK 29964 2009-05-03 03:56:18 -0700 2009-05-03 08:48:05 -0700 post-review patch hidden_2.txt text/plain 2378 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzhjYzYyOC4uZDU3ZmE5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNS0wMyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgRG8gbm90IGluc3RhbnRpYXRlIGhpZGRlbiBXZWJJbnNwZWN0 b3IgcGFuZWxzLiBPdGhlcndpc2UgdGhleSBhcmUgaGl0dGluZyB1bmltcGxlbWVudGVkIEluc3Bl Y3RvckNvbnRyb2xsZXIgbWV0aG9kcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI1NTIwCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2lu c3BlY3Rvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5sb2FkZWQpOgorCiAyMDA5LTA1LTAy ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRl eCBiNzc5YjRkLi42MzNkZWU1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0 b3IuanMKQEAgLTI3OSwyMiArMjc5LDI0IEBAIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlv bigpCiAgICAgZG9jdW1lbnQuYm9keS5hZGRTdHlsZUNsYXNzKCJwbGF0Zm9ybS0iICsgcGxhdGZv cm0pOwogCiAgICAgdGhpcy5jb25zb2xlID0gbmV3IFdlYkluc3BlY3Rvci5Db25zb2xlKCk7Ci0g ICAgdGhpcy5wYW5lbHMgPSB7Ci0gICAgICAgIGVsZW1lbnRzOiBuZXcgV2ViSW5zcGVjdG9yLkVs ZW1lbnRzUGFuZWwoKSwKLSAgICAgICAgcmVzb3VyY2VzOiBuZXcgV2ViSW5zcGVjdG9yLlJlc291 cmNlc1BhbmVsKCksCi0gICAgICAgIHNjcmlwdHM6IG5ldyBXZWJJbnNwZWN0b3IuU2NyaXB0c1Bh bmVsKCksCi0gICAgICAgIHByb2ZpbGVzOiBuZXcgV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwo KSwKLSAgICAgICAgZGF0YWJhc2VzOiBuZXcgV2ViSW5zcGVjdG9yLkRhdGFiYXNlc1BhbmVsKCkK LSAgICB9OwogCisgICAgdGhpcy5wYW5lbHMgPSB7fTsKICAgICB2YXIgaGlkZGVuUGFuZWxzID0g KEluc3BlY3RvckNvbnRyb2xsZXIuaGlkZGVuUGFuZWxzKCkgfHwgIiIpLnNwbGl0KCcsJyk7Cisg ICAgaWYgKGhpZGRlblBhbmVscy5pbmRleE9mKCJlbGVtZW50cyIpID09PSAtMSkKKyAgICAgICAg dGhpcy5wYW5lbHMuZWxlbWVudHMgPSBuZXcgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwoKTsK KyAgICBpZiAoaGlkZGVuUGFuZWxzLmluZGV4T2YoInJlc291cmNlcyIpID09PSAtMSkKKyAgICAg ICAgdGhpcy5wYW5lbHMucmVzb3VyY2VzID0gbmV3IFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5l bCgpOworICAgIGlmIChoaWRkZW5QYW5lbHMuaW5kZXhPZigic2NyaXB0cyIpID09PSAtMSkKKyAg ICAgICAgdGhpcy5wYW5lbHMuc2NyaXB0cyA9IG5ldyBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVs KCk7CisgICAgaWYgKGhpZGRlblBhbmVscy5pbmRleE9mKCJwcm9maWxlcyIpID09PSAtMSkKKyAg ICAgICAgdGhpcy5wYW5lbHMucHJvZmlsZXMgPSBuZXcgV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFu ZWwoKTsKKyAgICBpZiAoaGlkZGVuUGFuZWxzLmluZGV4T2YoImRhdGFiYXNlcyIpID09PSAtMSkK KyAgICAgICAgdGhpcy5wYW5lbHMuZGF0YWJhc2VzID0gbmV3IFdlYkluc3BlY3Rvci5EYXRhYmFz ZXNQYW5lbCgpOwogCiAgICAgdmFyIHRvb2xiYXJFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInRvb2xiYXIiKTsKICAgICB2YXIgcHJldmlvdXNUb29sYmFySXRlbSA9IHRvb2xiYXJF bGVtZW50LmNoaWxkcmVuWzBdOwogCiAgICAgZm9yICh2YXIgcGFuZWxOYW1lIGluIHRoaXMucGFu ZWxzKSB7Ci0gICAgICAgIGlmIChoaWRkZW5QYW5lbHMuaW5kZXhPZihwYW5lbE5hbWUpICE9PSAt MSkKLSAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB2YXIgcGFuZWwgPSB0aGlzLnBhbmVs c1twYW5lbE5hbWVdOwogICAgICAgICB2YXIgcGFuZWxUb29sYmFySXRlbSA9IHBhbmVsLnRvb2xi YXJJdGVtOwogICAgICAgICBwYW5lbFRvb2xiYXJJdGVtLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNr IiwgdGhpcy5fdG9vbGJhckl0ZW1DbGlja2VkLmJpbmQodGhpcykpOwo=