255098 2023-04-06 09:56:35 -0700 RenderBox::hasTrimmedMargin(PhyscialDirection) has redundant code 2023-04-06 13:55:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sgill26 sgill26 bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1947024 0 sgill26 2023-04-06 09:56:35 -0700 There are 2 RenderBox::hasTrimmedMargin methods. They take in either a PhysicalDirection or std::optional<MarginTrimType>. The version that takes in a physicalDirection simply maps the physical direction to a MarginTrimType and then calls the other version to perform the actual logic. There are pieces of debug code in here that are shared/redundant and will make it tedious to modify as future margin trim patches are landed. Since the version that takes in a PhysicalDirection just performs a mapping and calls the other, we can remove the debug code from it and keep it in the other. 1947025 1 webkit-bug-importer 2023-04-06 09:56:52 -0700 <rdar://problem/107713529> 1947026 2 sgill26 2023-04-06 09:59:33 -0700 Actually it's not just strictly debug code. There is also a !isInFlow() check that can be removed too 1947038 3 sgill26 2023-04-06 10:55:13 -0700 Pull request: https://github.com/WebKit/WebKit/pull/12464 1947115 4 ews-feeder 2023-04-06 13:55:14 -0700 Committed 262684@main (0c3876d9cb24): <https://commits.webkit.org/262684@main> Reviewed commits have been landed. Closing PR #12464 and removing active labels.