25509 2009-05-01 01:46:32 -0700 [GTK] Missing accelerator in authentication dialog 2009-07-21 04:21:09 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 elle.uca webkit-unassigned gustavo plaes xan.lopez oldest_to_newest 119577 0 elle.uca 2009-05-01 01:46:32 -0700 Translating webkitgtk I found this message: #: WebKit/gtk/webkit/webkitsoupauthdialog.c:281 msgid "Remember password" It's referred to checkButton = gtk_check_button_new_with_label(_("Remember password")); in source code. As per GNOME HIG, this checkbox should have an accelerator. 133271 1 33116 plaes 2009-07-20 15:33:28 -0700 Created attachment 33116 webkit-bug-25509-add-accelerator 133354 2 33116 zecke 2009-07-20 20:20:16 -0700 Comment on attachment 33116 webkit-bug-25509-add-accelerator As of http://library.gnome.org/devel/hig-book/stable/controls-check-boxes.html.en... 133444 3 gustavo 2009-07-21 04:05:46 -0700 Landed as r46169. 133445 4 elle.uca 2009-07-21 04:21:09 -0700 Silly question: POT file needs to be manually updated in order to have this changed message in translations, isn't it? 33116 2009-07-20 15:33:28 -0700 2009-07-20 20:20:16 -0700 webkit-bug-25509-add-accelerator webkit-bug-25509-add-accelerator.patch text/plain 1991 plaes RnJvbSBmOGRiY2YzZDVjMzg2Y2U1NGNjZTBlMzA5MGIyZTcxMzdhMmU5YzVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFR1 ZSwgMjEgSnVsIDIwMDkgMDE6Mjc6MTkgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTA3LTIx ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCglbR1RLK10gTWlzc2luZyBhY2NlbGVyYXRvciBpbiBhdXRoZW50aWNhdGlv biBkaWFsb2cKCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTUwOQoK CUFkZCBhY2NlbGVyYXRvciB0byBjaGVja2JveCB0ZXh0LgoKCSogd2Via2l0L3dlYmtpdHNvdXBh dXRoZGlhbG9nLmM6Cgkoc2hvd19hdXRoX2RpYWxvZyk6CgpTaWduZWQtb2ZmLWJ5OiBQcmlpdCBM YWVzIDxwbGFlc0BwbGFlcy5vcmc+Ci0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRz b3VwYXV0aGRpYWxvZy5jIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNjIyNTg1Zi4uZjA0NzMyNyAxMDA2NDQKLS0tIGEv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAwOS0wNy0yMSAgUHJpaXQgTGFlcyAgPHBsYWVzQHBsYWVzLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCVtHVEsrXSBNaXNzaW5nIGFjY2Vs ZXJhdG9yIGluIGF1dGhlbnRpY2F0aW9uIGRpYWxvZworCWh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNTUwOQorCisJQWRkIGFjY2VsZXJhdG9yIHRvIGNoZWNrYm94IHRl eHQuCisKKwkqIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHNvdXBhdXRoZGlhbG9nLmM6CisJKHNo b3dfYXV0aF9kaWFsb2cpOgorCiAyMDA5LTA3LTIwICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxn dXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhv bGdlciBGcmV5dGhlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHNvdXBh dXRoZGlhbG9nLmMgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRzb3VwYXV0aGRpYWxvZy5jCmlu ZGV4IGQ3MDQzYjguLjk3NDRlOGMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHNvdXBhdXRoZGlhbG9nLmMKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0c291cGF1dGhk aWFsb2cuYwpAQCAtMjc4LDcgKzI3OCw3IEBAIHN0YXRpYyB2b2lkIHNob3dfYXV0aF9kaWFsb2co V2ViS2l0QXV0aERhdGEqIGF1dGhEYXRhLCBjb25zdCBjaGFyKiBsb2dpbiwgY29uc3QKICAgICBn dGtfYm94X3BhY2tfc3RhcnQgKEdUS19CT1ggKHZib3gpLCByZW1lbWJlckJveCwKICAgICAgICAg ICAgICAgICAgICAgICAgIEZBTFNFLCBGQUxTRSwgMCk7CiAKLSAgICBjaGVja0J1dHRvbiA9IGd0 a19jaGVja19idXR0b25fbmV3X3dpdGhfbGFiZWwoXygiUmVtZW1iZXIgcGFzc3dvcmQiKSk7Cisg ICAgY2hlY2tCdXR0b24gPSBndGtfY2hlY2tfYnV0dG9uX25ld193aXRoX2xhYmVsKF8oIl9SZW1l bWJlciBwYXNzd29yZCIpKTsKICAgICBpZiAobG9naW4gJiYgcGFzc3dvcmQpCiAgICAgICAgIGd0 a190b2dnbGVfYnV0dG9uX3NldF9hY3RpdmUoR1RLX1RPR0dMRV9CVVRUT04oY2hlY2tCdXR0b24p LCBUUlVFKTsKICAgICBndGtfbGFiZWxfc2V0X2xpbmVfd3JhcChHVEtfTEFCRUwoZ3RrX2Jpbl9n ZXRfY2hpbGQoR1RLX0JJTihjaGVja0J1dHRvbikpKSwgVFJVRSk7Ci0tIAoxLjYuMy4zCgo=