<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>255035</bug_id>
          
          <creation_ts>2023-04-05 09:20:43 -0700</creation_ts>
          <short_desc>[ews] A PR that failed to fix a pre-existing test failure was marked as green even though the test was still failing</short_desc>
          <delta_ts>2023-06-13 06:43:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Haddad">ryanhaddad</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1946747</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2023-04-05 09:20:43 -0700</bug_when>
    <thetext>Here is an interesting case with our EWS + results DB integration, but I’m not sure how we’d mitigate it: 
https://github.com/WebKit/WebKit/pull/11769 was supposed to fix TestWebKitAPI.WebKit.MediaBufferingPolicy, and since EWS was ignoring the failure based on post-commit results, it ignored the fact that the test continued to fail with the PR and marked the run as ✅ https://ews-build.webkit.org/#/builders/18/builds/1253</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1946748</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-04-05 09:20:54 -0700</bug_when>
    <thetext>&lt;rdar://problem/107662421&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1961317</commentid>
    <comment_count>2</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2023-06-13 06:43:07 -0700</bug_when>
    <thetext>*** Bug 258005 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>