25501 2009-04-30 17:14:41 -0700 Extra font tag created when changing fonts 2010-01-21 22:53:27 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www.mozilla.org/editor/midasdemo/ P2 Normal --- 1 sullivan webkit-unassigned commit-queue eric jparent michaelthomas tony oldest_to_newest 119551 0 sullivan 2009-04-30 17:14:41 -0700 Steps to reproduce: 1. Go to Midas Demo: http://www.mozilla.org/editor/midasdemo/ 2. Enter the following HTML: text (This is what IE generates when setting the font to Arial.) 3. Uncheck "View HTML Source", highlight "text", and change font to Courier. Actual result: text Expected result: text or just text Lots of editing on different browsers can result in a document filling up with redundant tags. This makes it harder and harder to change the font correctly on all browsers. 183084 1 47099 tony 2010-01-20 23:02:54 -0800 Created attachment 47099 Patch 183085 2 tony 2010-01-20 23:04:54 -0800 (In reply to comment #1) > Created an attachment (id=47099) [details] > Patch I think the original code wasn't removing the extra font tag because it didn't create the font tag. That said, that seems like a silly reason to keep the extra font tag. E.g., if you unbold a section, webkit doesn't care who created the tags and just remove them. 183230 3 47099 darin 2010-01-21 09:54:18 -0800 Comment on attachment 47099 Patch r=me 183396 4 47159 tony 2010-01-21 17:00:40 -0800 Created attachment 47159 Patch 183426 5 47159 tony 2010-01-21 17:52:10 -0800 Comment on attachment 47159 Patch (same as before with better layout test that uses dumpAsText) 183495 6 47159 commit-queue 2010-01-21 22:53:22 -0800 Comment on attachment 47159 Patch Clearing flags on attachment: 47159 Committed r53680: <http://trac.webkit.org/changeset/53680> 183496 7 commit-queue 2010-01-21 22:53:27 -0800 All reviewed patches have been landed. Closing bug. 47099 2010-01-20 23:02:54 -0800 2010-01-21 17:00:34 -0800 Patch bug-25501-20100121160252.patch text/plain 3421 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMjMwNzk5Li5iZmQ1OWU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEt MjAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjU1MDEKKyAgICAgICAgUmVtb3ZlIGVtcHR5IGZvbnQgdGFncyB3aGVuIGFw cGx5aW5nIGEgc3R5bGUgdG8gYSBjb250ZW50IGVkaXRhYmxlCisgICAgICAgIHJlZ2lvbi4KKwor ICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvY2hhbmdlLWZvbnQuaHRtbDogQWRkZWQuCisg ICAgICAgICogcGxhdGZvcm0vbWFjL2VkaXRpbmcvZXhlY0NvbW1hbmQvY2hhbmdlLWZvbnQtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxMC0wMS0yMCAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkIGZhaWxpbmcgdGVzdCBmYXN0L2Nz cy9idXR0b24taGVpZ2h0Lmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvZXhl Y0NvbW1hbmQvY2hhbmdlLWZvbnQuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvY2hhbmdlLWZvbnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43 MDUzYjMzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFu ZC9jaGFuZ2UtZm9udC5odG1sCkBAIC0wLDAgKzEsNSBAQAorPGJvZHkgY29udGVudEVkaXRhYmxl PSJ0cnVlIj48Zm9udCBmYWNlPSJBcmlhbCI+VGhlcmUgc2hvdWxkIG9ubHkgYmUgb25lIGZvbnQg dGFnLjwvZm9udD48L2JvZHk+Cis8c2NyaXB0PgorICBkb2N1bWVudC5leGVjQ29tbWFuZCgic2Vs ZWN0YWxsIik7CisgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJmb250bmFtZSIsIGZhbHNlLCAiQ291 cmllciIpOworPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv ZWRpdGluZy9leGVjQ29tbWFuZC9jaGFuZ2UtZm9udC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9leGVjQ29tbWFuZC9jaGFuZ2UtZm9udC1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNzhjZGQ2MgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL2V4ZWNDb21tYW5kL2No YW5nZS1mb250LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEyIEBACitsYXllciBhdCAoMCwwKSBz aXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0 ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4 MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3ODR4NTg0CisgICAg ICBSZW5kZXJJbmxpbmUge0ZPTlR9IGF0ICgwLDApIHNpemUgMzQweDE4CisgICAgICAgIFJlbmRl clRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDM0MHgxOAorICAgICAgICAgIHRleHQgcnVuIGF0 ICgwLDApIHdpZHRoIDM0MDogIlRoZXJlIHNob3VsZCBvbmx5IGJlIG9uZSBmb250IHRhZy4iCisg ICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKKyAgICAgIFJlbmRlclRl eHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MAorc2VsZWN0aW9uIHN0YXJ0OiBwb3NpdGlvbiAw IG9mIGNoaWxkIDAgeyN0ZXh0fSBvZiBjaGlsZCAwIHtGT05UfSBvZiBjaGlsZCAxIHtCT0RZfSBv ZiBjaGlsZCAwIHtIVE1MfSBvZiBkb2N1bWVudAorc2VsZWN0aW9uIGVuZDogICBwb3NpdGlvbiAz NCBvZiBjaGlsZCAwIHsjdGV4dH0gb2YgY2hpbGQgMCB7Rk9OVH0gb2YgY2hpbGQgMSB7Qk9EWX0g b2YgY2hpbGQgMCB7SFRNTH0gb2YgZG9jdW1lbnQKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDdmM2ViMi4uYjBhZmZmYiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NiBAQAorMjAxMC0wMS0yMCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTUwMQorICAgICAgICBSZW1vdmUgZW1wdHkgZm9u dCB0YWdzIHdoZW4gYXBwbHlpbmcgYSBzdHlsZSB0byBhIGNvbnRlbnQgZWRpdGFibGUKKyAgICAg ICAgcmVnaW9uLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvZXhlY0NvbW1hbmQvY2hhbmdlLWZv bnQuaHRtbAorCisgICAgICAgICogZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjppc0VtcHR5Rm9udFRhZyk6CisKIDIwMTAtMDEtMjAgIEZ1bWl0b3NoaSBV a2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFBy b3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFu ZC5jcHAgYi9XZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCmluZGV4IDdhOGYw MjUuLjVjMjM2MDQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFu ZC5jcHAKKysrIGIvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcApAQCAtMzAy LDcgKzMwMiw5IEBAIHN0YXRpYyBib29sIGlzRW1wdHlGb250VGFnKGNvbnN0IE5vZGUgKm5vZGUp CiAKICAgICBjb25zdCBFbGVtZW50ICplbGVtID0gc3RhdGljX2Nhc3Q8Y29uc3QgRWxlbWVudCAq Pihub2RlKTsKICAgICBOYW1lZE5vZGVNYXAgKm1hcCA9IGVsZW0tPmF0dHJpYnV0ZXModHJ1ZSk7 IC8vIHRydWUgZm9yIHJlYWQtb25seQotICAgIHJldHVybiAoIW1hcCB8fCBtYXAtPmxlbmd0aCgp ID09IDEpICYmIGVsZW0tPmdldEF0dHJpYnV0ZShjbGFzc0F0dHIpID09IHN0eWxlU3BhbkNsYXNz U3RyaW5nKCk7CisgICAgaWYgKCFtYXApCisgICAgICAgIHJldHVybiB0cnVlOworICAgIHJldHVy biBtYXAtPmlzRW1wdHkoKSB8fCAobWFwLT5sZW5ndGgoKSA9PSAxICYmIGVsZW0tPmdldEF0dHJp YnV0ZShjbGFzc0F0dHIpID09IHN0eWxlU3BhbkNsYXNzU3RyaW5nKCkpOwogfQogCiBzdGF0aWMg UGFzc1JlZlB0cjxFbGVtZW50PiBjcmVhdGVGb250RWxlbWVudChEb2N1bWVudCogZG9jdW1lbnQp Cg== 47159 2010-01-21 17:00:40 -0800 2010-01-21 22:53:21 -0800 Patch bug-25501-20100122100038.patch text/plain 3138 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZWJmNmY1Li42ODQ4NzIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEt MjEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjU1MDEKKyAgICAgICAgUmVtb3ZlIGVtcHR5IGZvbnQgdGFncyB3aGVuIGFw cGx5aW5nIGEgc3R5bGUgdG8gYSBjb250ZW50IGVkaXRhYmxlCisgICAgICAgIHJlZ2lvbi4KKwor ICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvY2hhbmdlLWZvbnQuaHRtbDogQWRkZWQuCisg ICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9jaGFuZ2UtZm9udC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorCiAyMDEwLTAxLTIxICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2NoYW5nZS1mb250LWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvY2hhbmdlLWZvbnQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjNhZTNiNjIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2NoYW5nZS1mb250LWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDIgQEAKK1RoZXJlIHNob3VsZCBvbmx5IGJlIG9uZSBmb250IHRhZy4KK1NVQ0NF U1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvY2hhbmdlLWZv bnQuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvY2hhbmdlLWZvbnQuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hZmJhZTMzCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9jaGFuZ2UtZm9udC5odG1s CkBAIC0wLDAgKzEsMTMgQEAKKzxib2R5IGNvbnRlbnRFZGl0YWJsZT0idHJ1ZSI+PGZvbnQgZmFj ZT0iQXJpYWwiPlRoZXJlIHNob3VsZCBvbmx5IGJlIG9uZSBmb250IHRhZy48L2ZvbnQ+PC9ib2R5 PgorPHNjcmlwdCBzcmM9Ii4uL2VkaXRpbmcuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKyAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisgICAgdmFyIGZvbnROb2RlID0gZG9jdW1lbnQuZ2V0RWxlbWVu dHNCeVRhZ05hbWUoImZvbnQiKVswXTsKKyAgICBzZXRTZWxlY3Rpb25Db21tYW5kKGZvbnROb2Rl LCAwLCBmb250Tm9kZSwgMCk7CisgICAgZXhlY0V4dGVuZFNlbGVjdGlvbkZvcndhcmRCeVNlbnRl bmNlQ29tbWFuZCgpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJmb250bmFtZSIsIGZhbHNl LCAiQ291cmllciIpOworICAgIHZhciBudW1Gb250Tm9kZXMgPSBkb2N1bWVudC5nZXRFbGVtZW50 c0J5VGFnTmFtZSgiZm9udCIpLmxlbmd0aDsKKyAgICB2YXIgcmVzdWx0ID0gbnVtRm9udE5vZGVz ID09IDEgPyAiU1VDQ0VTUyIgOiAiRkFJTEVEIjsKKyAgICBkb2N1bWVudC5ib2R5LmlubmVySFRN TCArPSAiPHA+IiArIHJlc3VsdCArICI8L3A+IjsKKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYTMyYTZhLi4zMGIxM2Zm IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTAxLTIxICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NTAxCisgICAgICAgIFJlbW92 ZSBlbXB0eSBmb250IHRhZ3Mgd2hlbiBhcHBseWluZyBhIHN0eWxlIHRvIGEgY29udGVudCBlZGl0 YWJsZQorICAgICAgICByZWdpb24uCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9leGVjQ29tbWFu ZC9jaGFuZ2UtZm9udC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5k LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzRW1wdHlGb250VGFnKToKKwogMjAxMC0wMS0yMSAg RW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21t YW5kLmNwcCBiL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAKaW5kZXggN2E4 ZjAyNS4uNWMyMzYwNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21t YW5kLmNwcAorKysgYi9XZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCkBAIC0z MDIsNyArMzAyLDkgQEAgc3RhdGljIGJvb2wgaXNFbXB0eUZvbnRUYWcoY29uc3QgTm9kZSAqbm9k ZSkKIAogICAgIGNvbnN0IEVsZW1lbnQgKmVsZW0gPSBzdGF0aWNfY2FzdDxjb25zdCBFbGVtZW50 ICo+KG5vZGUpOwogICAgIE5hbWVkTm9kZU1hcCAqbWFwID0gZWxlbS0+YXR0cmlidXRlcyh0cnVl KTsgLy8gdHJ1ZSBmb3IgcmVhZC1vbmx5Ci0gICAgcmV0dXJuICghbWFwIHx8IG1hcC0+bGVuZ3Ro KCkgPT0gMSkgJiYgZWxlbS0+Z2V0QXR0cmlidXRlKGNsYXNzQXR0cikgPT0gc3R5bGVTcGFuQ2xh c3NTdHJpbmcoKTsKKyAgICBpZiAoIW1hcCkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgcmV0 dXJuIG1hcC0+aXNFbXB0eSgpIHx8IChtYXAtPmxlbmd0aCgpID09IDEgJiYgZWxlbS0+Z2V0QXR0 cmlidXRlKGNsYXNzQXR0cikgPT0gc3R5bGVTcGFuQ2xhc3NTdHJpbmcoKSk7CiB9CiAKIHN0YXRp YyBQYXNzUmVmUHRyPEVsZW1lbnQ+IGNyZWF0ZUZvbnRFbGVtZW50KERvY3VtZW50KiBkb2N1bWVu dCkK