<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>25492</bug_id>
          
          <creation_ts>2009-04-30 13:47:12 -0700</creation_ts>
          <short_desc>Add USE(JSC) guards around node wrapper cache calls.</short_desc>
          <delta_ts>2009-04-30 14:23:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dimitri Glazkov (Google)">dglazkov</reporter>
          <assigned_to name="Dimitri Glazkov (Google)">dglazkov</assigned_to>
          <cc>eric</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>119513</commentid>
    <comment_count>0</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-04-30 13:47:12 -0700</bug_when>
    <thetext>These are not used in V8.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>119514</commentid>
    <comment_count>1</comment_count>
      <attachid>29919</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-04-30 13:48:41 -0700</bug_when>
    <thetext>Created attachment 29919
Add JSC guards around node wrapper cache calls, v1.

 WebCore/ChangeLog        |   12 ++++++++++++
 WebCore/dom/Document.cpp |    2 ++
 WebCore/dom/Node.cpp     |    3 ++-
 3 files changed, 16 insertions(+), 1 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>119519</commentid>
    <comment_count>2</comment_count>
      <attachid>29919</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-04-30 14:09:00 -0700</bug_when>
    <thetext>Comment on attachment 29919
Add JSC guards around node wrapper cache calls, v1.

Please add a comment about why removing JSBindings.h is OK. r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>119521</commentid>
    <comment_count>3</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-04-30 14:23:29 -0700</bug_when>
    <thetext>Landed as http://trac.webkit.org/changeset/43091.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>29919</attachid>
            <date>2009-04-30 13:48:41 -0700</date>
            <delta_ts>2009-04-30 14:09:00 -0700</delta_ts>
            <desc>Add JSC guards around node wrapper cache calls, v1.</desc>
            <filename>Add-JSC-guards-around-node-wrapper-cache-calls-v1..patch</filename>
            <type>text/plain</type>
            <size>1758</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">ZWM3MGY3ZjhkZTJhNWE4MmQwZmY1MzRjNTc5ZmIyMzMwMDg3NDJiMgpkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ZmY3ZTY3Li4zMDc1Y2Ux
IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSw1ICsxLDE3IEBACiAyMDA5LTA0LTMwICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj
aHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NDkyCisgICAg
ICAgIEFkZCBKU0MgZ3VhcmRzIGFyb3VuZCBub2RlIHdyYXBwZXIgY2FjaGUgY2FsbHMuIFRoZXNl
IGFyZSBub3QgdXNlZCBieSBWOC4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpEb2N1bWVudDo6fkRvY3VtZW50KTogQWRkZWQgSlNDIGd1YXJkLgorICAg
ICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OnNldERvY3VtZW50
KTogRGl0dG8gYW5kIHJlbW92ZWQgSlNET01CaW5kaW5nIGluY2x1ZGUuCisKKzIwMDktMDQtMzAg
IERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKwogICAgICAgICBVbnJl
dmlld2VkLCBDaHJvbWl1bSBidWlsZCBmaXguCiAKICAgICAgICAgQ2F0Y2ggdXAgdG8gU2NyaXB0
T2JqZWN0IGNoYW5nZXMgZnJvbSBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC80MjUx
Mi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1dlYkNvcmUvZG9tL0Rv
Y3VtZW50LmNwcAppbmRleCAwYTY1NTdhLi5jMDdhNWIyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Rv
bS9Eb2N1bWVudC5jcHAKKysrIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC00MzksNyAr
NDM5LDkgQEAgRG9jdW1lbnQ6On5Eb2N1bWVudCgpCiAKICAgICByZW1vdmVBbGxFdmVudExpc3Rl
bmVycygpOwogCisjaWYgVVNFKEpTQykKICAgICBmb3JnZXRBbGxET01Ob2Rlc0ZvckRvY3VtZW50
KHRoaXMpOworI2VuZGlmCiAKICAgICBkZWxldGUgbV90b2tlbml6ZXI7CiAgICAgbV9kb2N1bWVu
dC5yZXNldFNraXBwaW5nUmVmKDApOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5jcHAg
Yi9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCA2NGU5NzY4Li43MTMyYTYwIDEwMDY0NAotLS0g
YS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtNDgs
NyArNDgsNiBAQAogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCiAj
aW5jbHVkZSAiSFRNTE5hbWVzLmgiCi0jaW5jbHVkZSAiSlNET01CaW5kaW5nLmgiCiAjaW5jbHVk
ZSAiS2V5Ym9hcmRFdmVudC5oIgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlICJNb3Vz
ZUV2ZW50LmgiCkBAIC00MzcsNyArNDM2LDkgQEAgdm9pZCBOb2RlOjpzZXREb2N1bWVudChEb2N1
bWVudCogZG9jdW1lbnQpCiAgICAgd2lsbE1vdmVUb05ld093bmVyRG9jdW1lbnQoKTsKICAgICBB
U1NFUlQod2lsbE1vdmVUb05ld093bmVyRG9jdW1lbnRXYXNDYWxsZWQpOwogCisjaWYgVVNFKEpT
QykKICAgICB1cGRhdGVET01Ob2RlRG9jdW1lbnQodGhpcywgbV9kb2N1bWVudC5nZXQoKSwgZG9j
dW1lbnQpOworI2VuZGlmCiAKICAgICBtX2RvY3VtZW50ID0gZG9jdW1lbnQ7CiAK
</data>
<flag name="review"
          id="14990"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>