254750 2023-03-30 10:20:57 -0700 Return value of LineBoxBuilder::lineContent is not a reference 2023-03-30 14:47:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=254758 InRadar P2 Normal --- 1 mcatanzaro zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1945387 0 mcatanzaro 2023-03-30 10:20:57 -0700 The return value of LineBoxBuilder::lineContent looks probably incorrect: const LineBuilder::LineContent lineContent() const { return m_lineContent; } If it was intended to return a copy, then it would surely return a non-const LineBuilder::LineContent, so I think this should probably be changed to: const LineBuilder::LineContent& lineContent() const { return m_lineContent; } But I have not checked to see if this change would be safe. I noticed due to this false-positive GCC 13 warning: In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-5.cpp:2: /home/mcatanzaro/Projects/WebKit/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: In member function ‘void WebCore::Layout::LineBoxBuilder::adjustOutsideListMarkersPosition(WebCore::Layout::LineBox&)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:714:15: error: possibly dangling reference to a temporary [-Werror=dangling-reference] 714 | auto& listMarkerRun = lineContent().runs[listMarkerBoxIndex]; | ^~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:714:68: note: the temporary was destroyed at the end of the full expression ‘(& WebCore::Layout::LineBoxBuilder::lineContent() const().WebCore::Layout::LineBuilder::LineContent::runs)->WTF::Vector<WebCore::Layout::Line::Run, 10>::operator[](listMarkerBoxIndex)’ 714 | auto& listMarkerRun = lineContent().runs[listMarkerBoxIndex]; | ^ It looks bad, but I don't think it's a real problem because although lineContent() is itself invalid after this statement, lineContent().runs[listMarkerBoxIndex] should still be valid. 1945388 1 zalan 2023-03-30 10:24:31 -0700 hah, indeed. That's very silly. Thank you! Let me quickly fix that. 1945415 2 465683 zalan 2023-03-30 11:00:56 -0700 Created attachment 465683 Patch 1945488 3 465691 zalan 2023-03-30 14:31:57 -0700 Created attachment 465691 [fast-cq]Patch 1945490 4 ews-feeder 2023-03-30 14:38:26 -0700 Committed 262366@main (eff08853244b): <https://commits.webkit.org/262366@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465691. 1945491 5 webkit-bug-importer 2023-03-30 14:39:21 -0700 <rdar://problem/107440230> 1945496 6 zalan 2023-03-30 14:47:12 -0700 Thanks again, Michael! 465683 2023-03-30 11:00:56 -0700 2023-03-30 14:31:56 -0700 Patch bug-254750-20230330110055.patch text/plain 1609 zalan RnJvbSAxMWY5ZTYwODdjOTFiY2RjMzZmY2FlNWE1MWQ1NmRhYWEzYWQ0OTM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFRodSwgMzAgTWFyIDIwMjMgMTE6MDA6MDcgLTA3MDAKU3ViamVjdDogW1BBVENIXSBSZXR1cm4g dmFsdWUgb2YgTGluZUJveEJ1aWxkZXI6OmxpbmVDb250ZW50IGlzIG5vdCBhCiByZWZlcmVuY2Ug aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NDc1MAoKUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCgpPb3BzLgoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0 dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQm94QnVpbGRlci5oOgooV2ViQ29yZTo6TGF5 b3V0OjpMaW5lQm94QnVpbGRlcjo6bGluZUNvbnRlbnQgY29uc3QpOgotLS0KIC4uLi9sYXlvdXQv Zm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQm94QnVpbGRlci5oICAgICB8IDIg Ky0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lu bGluZUxpbmVCb3hCdWlsZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0Nv bnRleHRzL2lubGluZS9JbmxpbmVMaW5lQm94QnVpbGRlci5oCmluZGV4IDAyYTNiZTdhYWVmMS4u ZWJiN2Y2OTM5Y2YyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGlu Z0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQm94QnVpbGRlci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCb3hCdWlsZGVy LmgKQEAgLTU5LDcgKzU5LDcgQEAgcHJpdmF0ZToKICAgICBib29sIGlzRmlyc3RMaW5lKCkgY29u c3QgeyByZXR1cm4gbV9saW5lQ29udGVudC5pc0ZpcnN0Rm9ybWF0dGVkTGluZSAhPSBMaW5lQnVp bGRlcjo6TGluZUNvbnRlbnQ6OkZpcnN0Rm9ybWF0dGVkTGluZTo6Tm87IH0KICAgICBib29sIGlz TGFzdExpbmUoKSBjb25zdCB7IHJldHVybiBtX2xpbmVDb250ZW50LmlzTGFzdExpbmVXaXRoSW5s aW5lQ29udGVudDsgfQogICAgIGNvbnN0IElubGluZUZvcm1hdHRpbmdDb250ZXh0JiBmb3JtYXR0 aW5nQ29udGV4dCgpIGNvbnN0IHsgcmV0dXJuIG1faW5saW5lRm9ybWF0dGluZ0NvbnRleHQ7IH0K LSAgICBjb25zdCBMaW5lQnVpbGRlcjo6TGluZUNvbnRlbnQgbGluZUNvbnRlbnQoKSBjb25zdCB7 IHJldHVybiBtX2xpbmVDb250ZW50OyB9CisgICAgY29uc3QgTGluZUJ1aWxkZXI6OkxpbmVDb250 ZW50JiBsaW5lQ29udGVudCgpIGNvbnN0IHsgcmV0dXJuIG1fbGluZUNvbnRlbnQ7IH0KICAgICBj b25zdCBCb3gmIHJvb3RCb3goKSBjb25zdCB7IHJldHVybiBmb3JtYXR0aW5nQ29udGV4dCgpLnJv b3QoKTsgfQogICAgIGNvbnN0IFJlbmRlclN0eWxlJiByb290U3R5bGUoKSBjb25zdCB7IHJldHVy biBpc0ZpcnN0TGluZSgpID8gcm9vdEJveCgpLmZpcnN0TGluZVN0eWxlKCkgOiByb290Qm94KCku c3R5bGUoKTsgfQogCg== 465691 2023-03-30 14:31:57 -0700 2023-03-30 14:38:27 -0700 [fast-cq]Patch bug-254750-20230330143157.patch text/plain 1602 zalan RnJvbSAxYzdkZGM4NThlM2IwZWFiZGFlN2I3MzI5MDJhNmNjNGMyYTFmY2M3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFRodSwgMzAgTWFyIDIwMjMgMTE6MDA6MDcgLTA3MDAKU3ViamVjdDogW1BBVENIXSBSZXR1cm4g dmFsdWUgb2YgTGluZUJveEJ1aWxkZXI6OmxpbmVDb250ZW50IGlzIG5vdCBhCiByZWZlcmVuY2Ug aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NDc1MAoKUmV2aWV3ZWQg YnkgQW50dGkgS29pdmlzdG8uCgoqIFNvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29u dGV4dHMvaW5saW5lL0lubGluZUxpbmVCb3hCdWlsZGVyLmg6CihXZWJDb3JlOjpMYXlvdXQ6Okxp bmVCb3hCdWlsZGVyOjpsaW5lQ29udGVudCBjb25zdCk6Ci0tLQogLi4uL2xheW91dC9mb3JtYXR0 aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCb3hCdWlsZGVyLmggICAgIHwgMiArLQogMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGlu ZUJveEJ1aWxkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMv aW5saW5lL0lubGluZUxpbmVCb3hCdWlsZGVyLmgKaW5kZXggMDJhM2JlN2FhZWYxLi5lYmI3ZjY5 MzljZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4 dHMvaW5saW5lL0lubGluZUxpbmVCb3hCdWlsZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJveEJ1aWxkZXIuaApAQCAt NTksNyArNTksNyBAQCBwcml2YXRlOgogICAgIGJvb2wgaXNGaXJzdExpbmUoKSBjb25zdCB7IHJl dHVybiBtX2xpbmVDb250ZW50LmlzRmlyc3RGb3JtYXR0ZWRMaW5lICE9IExpbmVCdWlsZGVyOjpM aW5lQ29udGVudDo6Rmlyc3RGb3JtYXR0ZWRMaW5lOjpObzsgfQogICAgIGJvb2wgaXNMYXN0TGlu ZSgpIGNvbnN0IHsgcmV0dXJuIG1fbGluZUNvbnRlbnQuaXNMYXN0TGluZVdpdGhJbmxpbmVDb250 ZW50OyB9CiAgICAgY29uc3QgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQmIGZvcm1hdHRpbmdDb250 ZXh0KCkgY29uc3QgeyByZXR1cm4gbV9pbmxpbmVGb3JtYXR0aW5nQ29udGV4dDsgfQotICAgIGNv bnN0IExpbmVCdWlsZGVyOjpMaW5lQ29udGVudCBsaW5lQ29udGVudCgpIGNvbnN0IHsgcmV0dXJu IG1fbGluZUNvbnRlbnQ7IH0KKyAgICBjb25zdCBMaW5lQnVpbGRlcjo6TGluZUNvbnRlbnQmIGxp bmVDb250ZW50KCkgY29uc3QgeyByZXR1cm4gbV9saW5lQ29udGVudDsgfQogICAgIGNvbnN0IEJv eCYgcm9vdEJveCgpIGNvbnN0IHsgcmV0dXJuIGZvcm1hdHRpbmdDb250ZXh0KCkucm9vdCgpOyB9 CiAgICAgY29uc3QgUmVuZGVyU3R5bGUmIHJvb3RTdHlsZSgpIGNvbnN0IHsgcmV0dXJuIGlzRmly c3RMaW5lKCkgPyByb290Qm94KCkuZmlyc3RMaW5lU3R5bGUoKSA6IHJvb3RCb3goKS5zdHlsZSgp OyB9CiAK