<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>254674</bug_id>
          
          <creation_ts>2023-03-29 10:25:35 -0700</creation_ts>
          <short_desc>[GStreamer] Fix crash on devices where video sink is auto-plugged</short_desc>
          <delta_ts>2023-06-12 05:57:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Enrique Ocaña">eocanha</reporter>
          <assigned_to name="Enrique Ocaña">eocanha</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1945041</commentid>
    <comment_count>0</comment_count>
    <who name="Enrique Ocaña">eocanha</who>
    <bug_when>2023-03-29 10:25:35 -0700</bug_when>
    <thetext>Some (downstream) platforms don&apos;t have any specific videosink enforced and use autoplugging instead. This means that createVideoSink() will return nullptr and the sink will be created automatically (autoplugged) when the time comes. However, the lambda[1] that sets max-lateness at createVideoSink() triggers an assert if the sink is null at that point.

[1] https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L3940</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945045</commentid>
    <comment_count>1</comment_count>
    <who name="Enrique Ocaña">eocanha</who>
    <bug_when>2023-03-29 10:49:27 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/12123</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945046</commentid>
    <comment_count>2</comment_count>
    <who name="Enrique Ocaña">eocanha</who>
    <bug_when>2023-03-29 10:50:22 -0700</bug_when>
    <thetext>See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1059</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1961013</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-06-12 05:56:27 -0700</bug_when>
    <thetext>Committed 265066@main (869bf0a64f0f): &lt;https://commits.webkit.org/265066@main&gt;

Reviewed commits have been landed. Closing PR #12123 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1961014</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-06-12 05:57:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/110639133&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>