25466 2009-04-29 12:42:04 -0700 WebKitGtk+ 1.1.6 prints weird error messages in Liferea 2009-05-02 12:40:09 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 bunk webkit-unassigned busg pochu27 xan.lopez oldest_to_newest 119314 0 bunk 2009-04-29 12:42:04 -0700 I'll attach examples. 119315 1 29890 bunk 2009-04-29 12:43:47 -0700 Created attachment 29890 error on line 81 at column 12: expected '>' it complains about the "h" in the </html> tag 119316 2 29891 bunk 2009-04-29 12:45:58 -0700 Created attachment 29891 error on line 58 at column 3: Extra content at the end of the document the "extra content" is the </body></html> 119317 3 29892 bunk 2009-04-29 12:47:20 -0700 Created attachment 29892 error on line 66 at column 38: expected '>' that's in the middle of the href of <a href="liferea-refresh-comments://lxccyfn-227638"><span>Refresh</span></a> 119325 4 bunk 2009-04-29 13:20:56 -0700 the call to webkit_web_view_load_string() is in https://liferea.svn.sourceforge.net/svnroot/liferea/trunk/liferea/src/webkit/webkit.c Call to webkit_web_view_load_string(): Breakpoint 1, webkit_web_view_load_string (webView=0x182e0b0, content=0x1a89380 "<?xml version=\"1.0\" encoding=\"utf-8\"?><!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"\n\"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n<html xmlns=\"http://www.w3.org/1999/xhtm"..., mimeType=0x46237a "application/xhtml+xml", encoding=0x461614 "UTF-8", baseUri=0x46109f "file://") at WebKit/gtk/webkit/webkitwebview.cpp:2483 2483 { 119328 5 bunk 2009-04-29 13:29:17 -0700 For one optically visible problem (the last of my 3 examples) I have confirmed that the problem is not present with 1.1.5. 119654 6 gustavo 2009-05-01 20:40:50 -0700 I found the problem, apparently. The problem is that the error code patch refactored the loading of string into a shared function, which mistakenly calls g_utf8_strlen on the string that is to be loaded, so any string with !ascii UTF-8 characters will have some content stripped from the end when creating the SharedBuffer: RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(content, g_utf8_strlen(content, -1)); I'm cooking a patch. 119668 7 29956 gustavo 2009-05-02 05:44:30 -0700 Created attachment 29956 Calculate the size of the string correctly WebKit/gtk/ChangeLog | 13 +++++++++++++ WebKit/gtk/webkit/webkitwebframe.cpp | 2 +- 2 files changed, 14 insertions(+), 1 deletions(-) 119687 8 29956 zecke 2009-05-02 12:31:47 -0700 Comment on attachment 29956 Calculate the size of the string correctly > - RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(content, g_utf8_strlen(content, -1)); > + RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(content, strlen(content)); Yes it makes sense, maybe you also want to add a unit test and compare the html with the one we set? 119688 9 gustavo 2009-05-02 12:36:55 -0700 (In reply to comment #8) > (From update of attachment 29956 [review]) > > > - RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(content, g_utf8_strlen(content, -1)); > > + RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(content, strlen(content)); > > > Yes it makes sense, maybe you also want to add a unit test and compare the html > with the one we set? We have no proper way of getting the source code backing a frame, 'till Jan's DataSource patch is landed. I will add a test when we land that =). > 119689 10 gustavo 2009-05-02 12:40:09 -0700 Landed as r43146. I'll open a bug report to remind me of the unit test. 29890 2009-04-29 12:43:47 -0700 2009-04-29 12:43:47 -0700 error on line 81 at column 12: expected '>' output.xhtml text/plain 0 bunk 29891 2009-04-29 12:45:58 -0700 2009-04-29 12:45:58 -0700 error on line 58 at column 3: Extra content at the end of the document output.xhtml text/plain 0 bunk 29892 2009-04-29 12:47:20 -0700 2009-04-29 12:47:20 -0700 error on line 66 at column 38: expected '>' output.xhtml text/plain 0 bunk 29956 2009-05-02 05:44:30 -0700 2009-05-02 12:31:47 -0700 Calculate the size of the string correctly Calculate-the-size-of-the-string-correctly.patch text/plain 1559 gustavo MWQxM2M2NGQ4MDE5MzkxNjZjN2Y5ODJhZGMwNGUxZTQ2OTExMzY4OQpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBkMTk0ZjgxLi5l YWJmMTQxIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTA1LTAyICBHdXN0YXZvIE5vcm9uaGEg U2lsdmEgIDxnbnNAZ25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NTQ2NgorICAgICAgICBXZWJLaXRHdGsrIDEuMS42IHByaW50cyB3ZWlyZCBlcnJvciBtZXNzYWdl cyBpbiBMaWZlcmVhCisKKyAgICAgICAgVXNlIHN0cmxlbiBpbnN0ZWFkIG9mIGdfdXRmOF9zdHJs ZW4gd2hlbiBjYWxjdWxhdGluZyB0aGUgc2l6ZSBvZgorICAgICAgICB0aGUgZGF0YSB0aGF0IGlz IGJlaW5nIGdpdmVuIHRvIHdlYmtpdF93ZWJfZnJhbWVfbG9hZF9zdHJpbmcgdG8gYmUKKyAgICAg ICAgbG9hZGVkLCBzbyB0aGF0IHdlIGRvbid0IG1pc3MgYW55IG9mIHRoZSBjb250ZW50LgorCisg ICAgICAgICogd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcDoKKwogMjAwOS0wNS0wMSAgRGltaXRy aSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGJ1bGlkIGZpeC4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1l LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcAppbmRleCA0ZTY0YmUw Li4wY2IzZDMxIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5j cHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwCkBAIC00MTYsNyAr NDE2LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9mcmFtZV9sb2FkX2RhdGEoV2ViS2l0V2Vi RnJhbWUqIGZyYW1lLCBjb25zdCBnY2hhciogY29udGUKIAogICAgIFJlc291cmNlUmVxdWVzdCBy ZXF1ZXN0KGJhc2VLVVJMKTsKIAotICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IHNoYXJlZEJ1ZmZl ciA9IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKGNvbnRlbnQsIGdfdXRmOF9zdHJsZW4oY29udGVudCwg LTEpKTsKKyAgICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBzaGFyZWRCdWZmZXIgPSBTaGFyZWRCdWZm ZXI6OmNyZWF0ZShjb250ZW50LCBzdHJsZW4oY29udGVudCkpOwogICAgIFN1YnN0aXR1dGVEYXRh IHN1YnN0aXR1dGVEYXRhKHNoYXJlZEJ1ZmZlci5yZWxlYXNlKCksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbWltZVR5cGUgPyBTdHJpbmc6OmZyb21VVEY4KG1pbWVUeXBlKSA6 IFN0cmluZzo6ZnJvbVVURjgoInRleHQvaHRtbCIpLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGVuY29kaW5nID8gU3RyaW5nOjpmcm9tVVRGOChlbmNvZGluZykgOiBTdHJpbmc6 OmZyb21VVEY4KCJVVEYtOCIpLAo=