254627 2023-03-28 16:36:36 -0700 [git-webkit] Prevent publication of commits for redacted PRs 2023-04-18 15:36:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=255043 InRadar P2 Normal --- 1 jbedard jbedard jbedard webkit-bug-importer oldest_to_newest 1944792 0 jbedard 2023-03-28 16:36:36 -0700 By design, git-webkit makes it very hard to opt-in to publishing a fix for a redacted PR. The recent addition of a pre-push hook makes this less crucial, because regardless of how a user answers prompts by `git-webkit`, any push containing a redacted issue will prompt the user before contacting the server. `git-webkit` should respect a user when they explicitly request to make a fix for a redacted issue public. 1944809 1 webkit-bug-importer 2023-03-28 17:18:00 -0700 <rdar://problem/107343169> 1944960 2 jbedard 2023-03-29 07:01:08 -0700 Pull request: https://github.com/WebKit/WebKit/pull/12110 1946784 3 jbedard 2023-04-05 11:39:52 -0700 After talking with Geoff and landing https://commits.webkit.org/262617@main, we're basically going to do the exact opposite of this: we're going to forbid publication of commits for redacted PRs in all circumstances. I'm going to re-purpose this bug because anyone following it already will care about us doing the inverse. 1949592 4 ews-feeder 2023-04-18 15:36:44 -0700 Committed 263101@main (9384f300d865): <https://commits.webkit.org/263101@main> Reviewed commits have been landed. Closing PR #12110 and removing active labels.