25458 2009-04-28 14:58:58 -0700 Restore alignment to device pixel boundaries. 2022-09-04 13:31:33 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Mac OS X 10.5 REOPENED P2 Normal --- 1 dacarson dacarson ahmad.saleem792 ap bfulgham ddkilzer hyatt mitz sabouhallawa simon.fraser socket.h zalan oldest_to_newest 119172 0 dacarson 2009-04-28 14:58:58 -0700 It seems that the calls to roundToDevicePixel() were dropped in http://trac.webkit.org/changeset/34210 This results in blurry images when zoomed out as the images are not aligned to pixel boundaries. I spoke with the author of r34210 change and he said that it caused some regression of images. After some investigation, the regression seems to be because of the srcRect being aligned as well as the destination rect. I would like to restore this feature. 119175 1 29864 dacarson 2009-04-28 15:02:43 -0700 Created attachment 29864 patch 119177 2 dacarson 2009-04-28 15:03:40 -0700 Ran DRT and there was no regressions on my platform. 119197 3 29864 hyatt 2009-04-28 16:10:55 -0700 Comment on attachment 29864 patch r=me 119241 4 dacarson 2009-04-28 18:00:38 -0700 Didn't run pixel tests. When I run those, these tests have an issue: svg/W3C-SVG-1.1/render-groups-03-t.svg expected image image diffs 0.16% svg/carto.net/scrollbar.svg expected image image diffs 0.15% svg/custom/focus-ring.svg expected image image diffs 0.19% svg/custom/image-small-width-height.svg expected image image diffs 0.33% 119244 5 dacarson 2009-04-28 18:21:22 -0700 With the test case: svg/custom/focus-ring.svg The focus ring is now in the correct place! With the test case: svg/custom/image-small-width-height.svg There was slight blurriness where the blue bar meets the green checker pattern. The line is now much sharper. 119265 6 ddkilzer 2009-04-28 21:39:18 -0700 This pixel test seems to have regressed with this patch: fast/repaint/fixed.html 119266 7 ddkilzer 2009-04-28 21:49:45 -0700 (In reply to comment #6) > This pixel test seems to have regressed with this patch: > fast/repaint/fixed.html Mitz informs me this is: https://bugs.webkit.org/show_bug.cgi?id=25269 Since the test is already broken, I will check in new results with this patch. 119271 8 ddkilzer 2009-04-28 22:52:59 -0700 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum M LayoutTests/platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png M LayoutTests/platform/mac/svg/custom/focus-ring-expected.checksum M LayoutTests/platform/mac/svg/custom/focus-ring-expected.png M LayoutTests/platform/mac/svg/custom/image-small-width-height-expected.checksum M LayoutTests/platform/mac/svg/custom/image-small-width-height-expected.png M WebCore/ChangeLog M WebCore/platform/graphics/cg/ImageCG.cpp Committed r42987 http://trac.webkit.org/changeset/42987 119424 9 mitz 2009-04-29 21:42:00 -0700 This change caused bug 25476. 119491 10 ddkilzer 2009-04-30 11:29:01 -0700 Reopening as this change was backed out for Bug 25476. 120131 11 29864 levin 2009-05-06 12:56:45 -0700 Comment on attachment 29864 patch Clearing r+ to move out of commit queue (and since the change was backed out due to some failed test). 1896038 12 ahmad.saleem792 2022-09-03 10:23:09 -0700 The patch was trying to add this and now we have it in Webkit Source: https://github.com/WebKit/WebKit/blob/61e05e09838b2da199e3bf1afe7a6120eee9cb4d/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp#L337 But it is for iOS only. Is something else needed or we can mark this as "RESOLVED CONFIGURATION CHANGED"? Thanks! 29864 2009-04-28 15:02:43 -0700 2010-06-10 17:07:47 -0700 patch reinstateAlignment.txt text/plain 1394 dacarson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mjk2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDQtMjggIERhdmlkIENhcnNvbiAgPGRhY2Fyc29uQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZXN0b3JlIGFsaWdubWVudCB0byBkZXZpY2UgcGl4ZWwgYm91bmRhcmllcy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NDU4CisKKyAgICAgICAgQWRq dXN0IHRoZSBhZGp1c3RlZCBkZXN0aW5hdGlvbiByZWN0IHRvIGJlIGRldmljZSBwaXhlbCBhbGln bmVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpCaXRtYXBJbWFnZTo6ZHJhdyk6CisKIDIwMDktMDQtMjggIFhhbiBMb3Bl eiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQ6IGZpeCBkaXN0Y2hl Y2sgYnVpbGQsIGFkZCBtaXNzaW5nIGhlYWRlciB0byBmaWxlIGxpc3QuCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHAJKHJldmlzaW9uIDQyOTYxKQorKysgV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTg3LDYgKzE4Nyw5IEBAIHZvaWQgQml0bWFwSW1hZ2U6OmRyYXcoR3JhcGhpY3NDb250ZXh0KiAK ICAgICBpZiAoIXNob3VsZFVzZVN1YmltYWdlICYmIGN1cnJIZWlnaHQgPCBzZWxmU2l6ZS5oZWln aHQoKSkKICAgICAgICAgYWRqdXN0ZWREZXN0UmVjdC5zZXRIZWlnaHQoYWRqdXN0ZWREZXN0UmVj dC5oZWlnaHQoKSAqIGN1cnJIZWlnaHQgLyBzZWxmU2l6ZS5oZWlnaHQoKSk7CiAKKyAgICAvLyBB bGlnbiB0byBwaXhlbCBib3VuZGFyaWVzCisgICAgYWRqdXN0ZWREZXN0UmVjdCA9IGN0eHQtPnJv dW5kVG9EZXZpY2VQaXhlbHMoYWRqdXN0ZWREZXN0UmVjdCk7CisKICAgICAvLyBGbGlwIHRoZSBj b29yZHMuCiAgICAgY3R4dC0+c2V0Q29tcG9zaXRlT3BlcmF0aW9uKGNvbXBvc2l0ZU9wKTsKICAg ICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY29udGV4dCwgYWRqdXN0ZWREZXN0UmVjdC54KCksIGFk anVzdGVkRGVzdFJlY3QuYm90dG9tKCkpOwo=