<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>254562</bug_id>
          
          <creation_ts>2023-03-27 18:50:18 -0700</creation_ts>
          <short_desc>WebKit needs to pass along NotificationOptions.silent to API clients</short_desc>
          <delta_ts>2023-04-20 11:38:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>Safari 16</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=254969</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="lehu">hi</reporter>
          <assigned_to name="Brady Eidson">beidson</assigned_to>
          <cc>beidson</cc>
    
    <cc>pwadeveloper2</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1944459</commentid>
    <comment_count>0</comment_count>
    <who name="lehu">hi</who>
    <bug_when>2023-03-27 18:50:18 -0700</bug_when>
    <thetext>Notification pushed by WebPush does not play alert sound both on iOS and macOS.

And here is a demo to reoccur this issue.

https://bugs.webkit.org/show_bug.cgi?id=252544#c3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945369</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-03-30 09:29:29 -0700</bug_when>
    <thetext>&lt;rdar://problem/107424158&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1949939</commentid>
    <comment_count>2</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2023-04-19 19:49:41 -0700</bug_when>
    <thetext>

WebKit itself does not display notifications, and cannot affect whether or not sound plays.

But for clients to be able to make the &quot;sound or silent?&quot; decision, WebKit needs to pass along the silent flag from NotificationOptions.

Let&apos;s do that here. Retitling to:
WebKit needs to pass along NotificationOptions.silent to API clients</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1949940</commentid>
    <comment_count>3</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2023-04-19 19:59:19 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/12953</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1950126</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-04-20 11:38:40 -0700</bug_when>
    <thetext>Committed 263184@main (c33fee9a5907): &lt;https://commits.webkit.org/263184@main&gt;

Reviewed commits have been landed. Closing PR #12953 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>