<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>254490</bug_id>
          
          <creation_ts>2023-03-26 16:55:32 -0700</creation_ts>
          <short_desc>Serialising web fonts duplicates the font custom data in the GPUP</short_desc>
          <delta_ts>2024-01-27 14:48:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Text</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=254774</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=254708</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>268233</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Woodrow">mattwoodrow</reporter>
          <assigned_to name="Matt Woodrow">mattwoodrow</assigned_to>
          <cc>fujii</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1944082</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2023-03-26 16:55:32 -0700</bug_when>
    <thetext>In the Web Process, all Font instances from the same web font share the same underlying font data (via Font::CreationData).

When we serialise fonts to the GPUP we serialise the font data each time, resulting in extra memory usage and time spent parsing the data each time.

&lt;rdar://106965215&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1944086</commentid>
    <comment_count>1</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2023-03-26 17:17:58 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/11987</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1944794</commentid>
    <comment_count>2</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2023-03-28 16:47:37 -0700</bug_when>
    <thetext>Pull request: https://github.com/apple/WebKit/pull/502</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1944892</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-03-29 01:06:17 -0700</bug_when>
    <thetext>Committed 262263@main (b917345920e9): &lt;https://commits.webkit.org/262263@main&gt;

Reviewed commits have been landed. Closing PR #11987 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945465</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2023-03-30 13:44:22 -0700</bug_when>
    <thetext>Regressed: Bug 254708 – REGRESSION(262263@main) [Win] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) in font tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945502</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2023-03-30 14:58:59 -0700</bug_when>
    <thetext>Right; reverting via bug 254774.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945602</commentid>
    <comment_count>6</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2023-03-30 23:26:56 -0700</bug_when>
    <thetext>Re-opening for pull request https://github.com/WebKit/WebKit/pull/12221</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945809</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-03-31 12:37:34 -0700</bug_when>
    <thetext>Committed 262435@main (403125028b31): &lt;https://commits.webkit.org/262435@main&gt;

Reviewed commits have been landed. Closing PR #12221 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>