25448 2009-04-28 10:20:00 -0700 Reveal execution line after SourceFrame loading 2009-04-29 10:38:32 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys webkit-unassigned dglazkov timothy oldest_to_newest 119108 0 yurys 2009-04-28 10:20:00 -0700 When its content is loaded SourceFrame updates current execution line but it doesn't reveal it. In case of asynchronous loading(in Chromium) current execution line stays hidden. 119109 1 29852 yurys 2009-04-28 10:23:13 -0700 Created attachment 29852 Reveal current execution line(if any) when script source is loaded 119111 2 29852 timothy 2009-04-28 10:43:49 -0700 Comment on attachment 29852 Reveal current execution line(if any) when script source is loaded > + if (this._executionLine) > + this.revealLine(this._executionLine); The change is correct. But please use 4 spaces instead of two for indentation. Also include a ChangeLog entry (use the prepare-ChangeLog script). 119276 3 29880 yurys 2009-04-29 00:30:04 -0700 Created attachment 29880 Reveal current execution line(if any) when script source is loaded 119277 4 yurys 2009-04-29 00:31:28 -0700 (In reply to comment #2) > (From update of attachment 29852 [review]) > > + if (this._executionLine) > > + this.revealLine(this._executionLine); > > The change is correct. But please use 4 spaces instead of two for indentation. > > Also include a ChangeLog entry (use the prepare-ChangeLog script). > Done. 119290 5 timothy 2009-04-29 10:38:32 -0700 Landed in r42997. 29852 2009-04-28 10:23:13 -0700 2009-04-29 00:30:04 -0700 Reveal current execution line(if any) when script source is loaded reveal-line.patch text/plain 578 yurys SW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcw0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwkocmV2 aXNpb24gMTQ3MjIpDQorKysgV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1l LmpzCSh3b3JraW5nIGNvcHkpDQpAQCAtMjMzLDYgKzIzMyw4IEBADQogICAgICAgICB0aGlzLl9h ZGRFeGlzdGluZ01lc3NhZ2VzVG9Tb3VyY2UoKTsKICAgICAgICAgdGhpcy5fYWRkRXhpc3RpbmdC cmVha3BvaW50c1RvU291cmNlKCk7CiAgICAgICAgIHRoaXMuX3VwZGF0ZUV4ZWN1dGlvbkxpbmUo KTsKKyAgICAgICAgaWYgKHRoaXMuX2V4ZWN1dGlvbkxpbmUpCisgICAgICAgICAgdGhpcy5yZXZl YWxMaW5lKHRoaXMuX2V4ZWN1dGlvbkxpbmUpOwogCiAgICAgICAgIGlmICh0aGlzLmF1dG9TaXpl c1RvRml0Q29udGVudEhlaWdodCkKICAgICAgICAgICAgIHRoaXMuc2l6ZVRvRml0Q29udGVudEhl aWdodCgpOwo= 29880 2009-04-29 00:30:04 -0700 2009-04-29 09:52:34 -0700 Reveal current execution line(if any) when script source is loaded reveal-line.patch text/plain 1167 yurys SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mjk5MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDQtMjkgIHl1cnlzICA8WXVyeSBTZW1pa2hhdHNreSA8eXVy eXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJldmVhbCBjdXJyZW50IGV4ZWN1dGlvbiBsaW5lIG9uY2UgU291cmNlRnJhbWUg Y29udGVudCBpcyBsb2FkZWQuIAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3Vy Y2VGcmFtZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUu X2xvYWRlZCk6CisKIDIwMDktMDQtMjggIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5A bm9raWEuY29tPgogCiAgICAgICAgIEZpeCB0aGUgUXQgYnVpbGQuCkluZGV4OiBXZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCShyZXZpc2lvbiA0MjkzNSkKKysrIFdl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwkod29ya2luZyBjb3B5KQpA QCAtMjMzLDYgKzIzMyw4IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7 CiAgICAgICAgIHRoaXMuX2FkZEV4aXN0aW5nTWVzc2FnZXNUb1NvdXJjZSgpOwogICAgICAgICB0 aGlzLl9hZGRFeGlzdGluZ0JyZWFrcG9pbnRzVG9Tb3VyY2UoKTsKICAgICAgICAgdGhpcy5fdXBk YXRlRXhlY3V0aW9uTGluZSgpOworICAgICAgICBpZiAodGhpcy5fZXhlY3V0aW9uTGluZSkKKyAg ICAgICAgICAgIHRoaXMucmV2ZWFsTGluZSh0aGlzLl9leGVjdXRpb25MaW5lKTsKIAogICAgICAg ICBpZiAodGhpcy5hdXRvU2l6ZXNUb0ZpdENvbnRlbnRIZWlnaHQpCiAgICAgICAgICAgICB0aGlz LnNpemVUb0ZpdENvbnRlbnRIZWlnaHQoKTsK