25446 2009-04-28 07:49:16 -0700 needless platformWidget() calls in WidgetWx.cpp 2009-04-28 10:07:38 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC All RESOLVED FIXED P2 Trivial --- 0 kevinwatters webkit-unassigned oldest_to_newest 119090 0 kevinwatters 2009-04-28 07:49:16 -0700 WidgetWx.cpp has several places where two platformWidget() calls could be replaced by one. 119091 1 29845 kevinwatters 2009-04-28 07:49:46 -0700 Created attachment 29845 Replaces two platformWidget() calls with one in several functions 119106 2 kevino 2009-04-28 10:07:38 -0700 Landed in r42937, thanks! 29845 2009-04-28 07:49:46 -0700 2009-04-28 09:35:25 -0700 Replaces two platformWidget() calls with one in several functions platform_widget.patch text/plain 2410 kevinwatters SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjkxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDQtMjcgIEtldmluIFdhdHRlcnMgIDxrZXZpbndhdHRlcnNA Z21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNtYWxsIG9wdGltaXphdGlvbiwgZG9uJ3QgZ2V0IHRoZSB3aWRnZXQncyBoYW5kbGUgdHdp Y2UgaW4gb25lIG1ldGhvZC4KKworICAgICAgICAqIHBsYXRmb3JtL3d4L1dpZGdldFd4LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6c2V0Rm9jdXMpOgorICAgICAgICAoV2ViQ29yZTo6 V2lkZ2V0OjpzaG93KToKKyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6aGlkZSk6CisgICAgICAg IChXZWJDb3JlOjpXaWRnZXQ6OmZyYW1lUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpXaWRnZXQ6 OnNldEZyYW1lUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpXaWRnZXQ6OmludmFsaWRhdGVSZWN0 KToKKyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6cGFpbnQpOgorCiAyMDA5LTA0LTI3ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS93eC9XaWRnZXRXeC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS93eC9XaWRnZXRXeC5jcHAJKHJldmlzaW9uIDQy ODk3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS93eC9XaWRnZXRXeC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ1LDggKzQ1LDggQEAKIAogdm9pZCBXaWRnZXQ6OnNldEZvY3VzKCkKIHsKLSAgICBpZiAo cGxhdGZvcm1XaWRnZXQoKSkKLSAgICAgICAgcGxhdGZvcm1XaWRnZXQoKS0+U2V0Rm9jdXMoKTsK KyAgICBpZiAoUGxhdGZvcm1XaWRnZXQgd2lkZ2V0ID0gcGxhdGZvcm1XaWRnZXQoKSkKKyAgICAg ICAgd2lkZ2V0LT5TZXRGb2N1cygpOwogfQogCiB2b2lkIFdpZGdldDo6c2V0Q3Vyc29yKGNvbnN0 IEN1cnNvciYgY3Vyc29yKQpAQCAtNTcsMzggKzU3LDQzIEBACiAKIHZvaWQgV2lkZ2V0OjpzaG93 KCkKIHsKLSAgICBpZiAocGxhdGZvcm1XaWRnZXQoKSkKLSAgICAgICAgcGxhdGZvcm1XaWRnZXQo KS0+U2hvdygpOworICAgIGlmIChQbGF0Zm9ybVdpZGdldCB3aWRnZXQgPSBwbGF0Zm9ybVdpZGdl dCgpKQorICAgICAgICB3aWRnZXQtPlNob3coKTsKIH0KIAogdm9pZCBXaWRnZXQ6OmhpZGUoKQog ewotICAgIGlmIChwbGF0Zm9ybVdpZGdldCgpKQotICAgICAgICBwbGF0Zm9ybVdpZGdldCgpLT5I aWRlKCk7CisgICAgaWYgKFBsYXRmb3JtV2lkZ2V0IHdpZGdldCA9IHBsYXRmb3JtV2lkZ2V0KCkp CisgICAgICAgIHdpZGdldC0+SGlkZSgpOwogfQogCiBJbnRSZWN0IFdpZGdldDo6ZnJhbWVSZWN0 KCkgY29uc3QKIHsKLSAgICBpZiAocGxhdGZvcm1XaWRnZXQoKSkKLSAgICAgICAgcmV0dXJuIHBs YXRmb3JtV2lkZ2V0KCktPkdldFJlY3QoKTsKKyAgICBpZiAoUGxhdGZvcm1XaWRnZXQgd2lkZ2V0 ID0gcGxhdGZvcm1XaWRnZXQoKSkKKyAgICAgICAgcmV0dXJuIHdpZGdldC0+R2V0UmVjdCgpOwor ICAgIAogICAgIHJldHVybiBtX2ZyYW1lOwogfQogCiB2b2lkIFdpZGdldDo6c2V0RnJhbWVSZWN0 KGNvbnN0IEludFJlY3QmIHJlY3QpCiB7Ci0gICAgaWYgKHBsYXRmb3JtV2lkZ2V0KCkpCi0gICAg ICAgIHBsYXRmb3JtV2lkZ2V0KCktPlNldFNpemUocmVjdCk7CisgICAgaWYgKFBsYXRmb3JtV2lk Z2V0IHdpZGdldCA9IHBsYXRmb3JtV2lkZ2V0KCkpCisgICAgICAgIHdpZGdldC0+U2V0U2l6ZShy ZWN0KTsKKyAgICAKICAgICBtX2ZyYW1lID0gcmVjdDsKIH0KIAogdm9pZCBXaWRnZXQ6OmludmFs aWRhdGVSZWN0KGNvbnN0IEludFJlY3QmIHIpCiB7Ci0gICAgaWYgKHBsYXRmb3JtV2lkZ2V0KCkp Ci0gICAgICAgIHBsYXRmb3JtV2lkZ2V0KCktPlJlZnJlc2hSZWN0KHIpOworICAgIGlmIChQbGF0 Zm9ybVdpZGdldCB3aWRnZXQgPSBwbGF0Zm9ybVdpZGdldCgpKQorICAgICAgICB3aWRnZXQtPlJl ZnJlc2hSZWN0KHIpOwogfQogCiB2b2lkIFdpZGdldDo6cGFpbnQoR3JhcGhpY3NDb250ZXh0Kixj b25zdCBJbnRSZWN0JiByKQogeworICAgIGludmFsaWRhdGVSZWN0KHIpOworICAgIGlmIChQbGF0 Zm9ybVdpZGdldCB3aWRnZXQgPSBwbGF0Zm9ybVdpZGdldCgpKQorICAgICAgICB3aWRnZXQtPlVw ZGF0ZSgpOwogfQogCiB9Cg==