254405 2023-03-24 05:13:48 -0700 [MSE] media/media-source/media-source-video-playback-quality.html is a constant failure with MockMSE in GPUP 2023-03-24 07:46:19 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 225367 1 jean-yves.avenard jean-yves.avenard webkit-bug-importer oldest_to_newest 1943679 0 jean-yves.avenard 2023-03-24 05:13:48 -0700 With MockMSE running in the GPU process, the test is a permanent error. ``` RUN(sourceBuffer.appendBuffer(samples)) EVENT(updateend) RUN(quality = video.getVideoPlaybackQuality()) -EXPECTED (quality.totalVideoFrames == '8') OK -EXPECTED (quality.corruptedVideoFrames == '1') OK -EXPECTED (quality.droppedVideoFrames == '2') OK -EXPECTED (quality.totalFrameDelay == '3') OK +EXPECTED (quality.totalVideoFrames == '8'), OBSERVED '1' FAIL +EXPECTED (quality.corruptedVideoFrames == '1'), OBSERVED '0' FAIL +EXPECTED (quality.droppedVideoFrames == '2'), OBSERVED '1' FAIL +EXPECTED (quality.totalFrameDelay == '3'), OBSERVED '0' FAIL END OF TEST ``` The test waits for the `updateend` event to be fired on SourceBuffer before calling `getVideoPlaybackQuality` , but this would only work when the MockMSE runs in the content process due to an implementation detailed with the MockMediaPlayerMediaSource: it updates the time and playback quality immediately. However, in practice this is rather nonsensical, we can only expect the VideoPlaybackQuality object to be up to date once the video has been fully played: frames won't be dropped while the video is paused. 1943680 1 webkit-bug-importer 2023-03-24 05:14:09 -0700 <rdar://problem/107182984> 1943681 2 jean-yves.avenard 2023-03-24 05:25:13 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11915 1943734 3 ews-feeder 2023-03-24 07:46:16 -0700 Committed 262071@main (ad2552fcc7cd): <https://commits.webkit.org/262071@main> Reviewed commits have been landed. Closing PR #11915 and removing active labels.