25440 2009-04-28 00:07:07 -0700 setTimeout should stringify non-string/non-function first arguments 2009-04-29 23:48:35 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED data:text/html,<script>setTimeout({ toString: function() { alert("PASS"); } }, 0);</script> P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 119065 0 sam 2009-04-28 00:07:07 -0700 Per WebIDL, setTimeout should stringify non-string/non-function first arguments. 119137 1 mrowe 2009-04-28 12:08:48 -0700 *** Bug 25441 has been marked as a duplicate of this bug. *** 119431 2 29903 sam 2009-04-29 23:24:19 -0700 Created attachment 29903 patch 119432 3 29903 oliver 2009-04-29 23:32:12 -0700 Comment on attachment 29903 patch you should stop running if toString results in an exception (esp. for setInterval, we don't want a timer for a code that does nothing); Also add tests to cover setInterval 119433 4 sam 2009-04-29 23:48:35 -0700 Fixed with Oliver's suggestions implemented in r43046. 29903 2009-04-29 23:24:19 -0700 2009-04-29 23:32:12 -0700 patch setTimeout.diff text/plain 6937 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzA0NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMDktMDQtMjkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9y IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTQ0MAorICAgICAgICBz ZXRUaW1lb3V0IHNob3VsZCBzdHJpbmdpZnkgbm9uLXN0cmluZy9ub24tZnVuY3Rpb24gZmlyc3Qg YXJndW1lbnRzCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vV2luZG93L3NldFRpbWVvdXQtc3Ry aW5nLWFyZ3VtZW50Lmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3Vz dG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93OjpzZXRUaW1lb3V0KToKKyAg ICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93OjpzZXRJbnRlcnZhbCk6CisgICAgICAgICogYmlu ZGluZ3MvanMvSlNXb3JrZXJDb250ZXh0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpT V29ya2VyQ29udGV4dDo6c2V0VGltZW91dCk6CisgICAgICAgIChXZWJDb3JlOjpKU1dvcmtlckNv bnRleHQ6OnNldEludGVydmFsKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY2hlZHVsZWRBY3Rp b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NoZWR1bGVkQWN0aW9uOjpjcmVhdGUpOgorICAg ICAgICAqIGJpbmRpbmdzL2pzL1NjaGVkdWxlZEFjdGlvbi5oOgorCiAyMDA5LTA0LTI5ICBEYW4g QmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24g RnJhc2VyLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAJ KHJldmlzaW9uIDQzMDQwKQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3Rv bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5NywxOCArNDk3LDE0IEBAIEpTVmFsdWVQdHIgSlNE T01XaW5kb3c6OnBvc3RNZXNzYWdlKEV4ZWMKIAogSlNWYWx1ZVB0ciBKU0RPTVdpbmRvdzo6c2V0 VGltZW91dChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEFyZ0xpc3QmIGFyZ3MpCiB7Ci0gICAgU2No ZWR1bGVkQWN0aW9uKiBhY3Rpb24gPSBTY2hlZHVsZWRBY3Rpb246OmNyZWF0ZShhcmdzKTsKLSAg ICBpZiAoIWFjdGlvbikKLSAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CisgICAgU2NoZWR1 bGVkQWN0aW9uKiBhY3Rpb24gPSBTY2hlZHVsZWRBY3Rpb246OmNyZWF0ZShleGVjLCBhcmdzKTsK ICAgICBpbnQgZGVsYXkgPSBhcmdzLmF0KDEpLnRvSW50MzIoZXhlYyk7CiAgICAgcmV0dXJuIGpz TnVtYmVyKGV4ZWMsIGltcGwoKS0+c2V0VGltZW91dChhY3Rpb24sIGRlbGF5KSk7CiB9CiAKIEpT VmFsdWVQdHIgSlNET01XaW5kb3c6OnNldEludGVydmFsKEV4ZWNTdGF0ZSogZXhlYywgY29uc3Qg QXJnTGlzdCYgYXJncykKIHsKLSAgICBTY2hlZHVsZWRBY3Rpb24qIGFjdGlvbiA9IFNjaGVkdWxl ZEFjdGlvbjo6Y3JlYXRlKGFyZ3MpOwotICAgIGlmICghYWN0aW9uKQotICAgICAgICByZXR1cm4g anNVbmRlZmluZWQoKTsKKyAgICBTY2hlZHVsZWRBY3Rpb24qIGFjdGlvbiA9IFNjaGVkdWxlZEFj dGlvbjo6Y3JlYXRlKGV4ZWMsIGFyZ3MpOwogICAgIGludCBkZWxheSA9IGFyZ3MuYXQoMSkudG9J bnQzMihleGVjKTsKICAgICByZXR1cm4ganNOdW1iZXIoZXhlYywgaW1wbCgpLT5zZXRJbnRlcnZh bChhY3Rpb24sIGRlbGF5KSk7CiB9CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTV29ya2Vy Q29udGV4dEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dv cmtlckNvbnRleHRDdXN0b20uY3BwCShyZXZpc2lvbiA0MzA0MCkKKysrIFdlYkNvcmUvYmluZGlu Z3MvanMvSlNXb3JrZXJDb250ZXh0Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIzLDE4 ICsxMjMsMTQgQEAgSlNWYWx1ZVB0ciBKU1dvcmtlckNvbnRleHQ6OnJlbW92ZUV2ZW50TAogCiBK U1ZhbHVlUHRyIEpTV29ya2VyQ29udGV4dDo6c2V0VGltZW91dChFeGVjU3RhdGUqIGV4ZWMsIGNv bnN0IEFyZ0xpc3QmIGFyZ3MpCiB7Ci0gICAgU2NoZWR1bGVkQWN0aW9uKiBhY3Rpb24gPSBTY2hl ZHVsZWRBY3Rpb246OmNyZWF0ZShhcmdzKTsKLSAgICBpZiAoIWFjdGlvbikKLSAgICAgICAgcmV0 dXJuIGpzVW5kZWZpbmVkKCk7CisgICAgU2NoZWR1bGVkQWN0aW9uKiBhY3Rpb24gPSBTY2hlZHVs ZWRBY3Rpb246OmNyZWF0ZShleGVjLCBhcmdzKTsKICAgICBpbnQgZGVsYXkgPSBhcmdzLmF0KDEp LnRvSW50MzIoZXhlYyk7CiAgICAgcmV0dXJuIGpzTnVtYmVyKGV4ZWMsIGltcGwoKS0+c2V0VGlt ZW91dChhY3Rpb24sIGRlbGF5KSk7CiB9CiAKIEpTVmFsdWVQdHIgSlNXb3JrZXJDb250ZXh0Ojpz ZXRJbnRlcnZhbChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEFyZ0xpc3QmIGFyZ3MpCiB7Ci0gICAg U2NoZWR1bGVkQWN0aW9uKiBhY3Rpb24gPSBTY2hlZHVsZWRBY3Rpb246OmNyZWF0ZShhcmdzKTsK LSAgICBpZiAoIWFjdGlvbikKLSAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CisgICAgU2No ZWR1bGVkQWN0aW9uKiBhY3Rpb24gPSBTY2hlZHVsZWRBY3Rpb246OmNyZWF0ZShleGVjLCBhcmdz KTsKICAgICBpbnQgZGVsYXkgPSBhcmdzLmF0KDEpLnRvSW50MzIoZXhlYyk7CiAgICAgcmV0dXJu IGpzTnVtYmVyKGV4ZWMsIGltcGwoKS0+c2V0SW50ZXJ2YWwoYWN0aW9uLCBkZWxheSkpOwogfQpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9TY2hlZHVsZWRBY3Rpb24uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvYmluZGluZ3MvanMvU2NoZWR1bGVkQWN0aW9uLmNwcAkocmV2aXNpb24gNDMw NDApCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjaGVkdWxlZEFjdGlvbi5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ3LDE0ICs0NywxMiBAQCB1c2luZyBuYW1lc3BhY2UgSlNDOwogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKLVNjaGVkdWxlZEFjdGlvbiogU2NoZWR1bGVkQWN0aW9uOjpjcmVhdGUo Y29uc3QgQXJnTGlzdCYgYXJncykKK1NjaGVkdWxlZEFjdGlvbiogU2NoZWR1bGVkQWN0aW9uOjpj cmVhdGUoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzKQogewogICAgIEpTVmFs dWVQdHIgdiA9IGFyZ3MuYXQoMCk7Ci0gICAgaWYgKHYuaXNTdHJpbmcoKSkKLSAgICAgICAgcmV0 dXJuIG5ldyBTY2hlZHVsZWRBY3Rpb24oYXNTdHJpbmcodiktPnZhbHVlKCkpOwogICAgIENhbGxE YXRhIGNhbGxEYXRhOwogICAgIGlmICh2LmdldENhbGxEYXRhKGNhbGxEYXRhKSA9PSBDYWxsVHlw ZU5vbmUpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gbmV3IFNjaGVkdWxlZEFj dGlvbih2LnRvU3RyaW5nKGV4ZWMpKTsKICAgICBBcmdMaXN0IGFyZ3NUYWlsOwogICAgIGFyZ3Mu Z2V0U2xpY2UoMiwgYXJnc1RhaWwpOwogICAgIHJldHVybiBuZXcgU2NoZWR1bGVkQWN0aW9uKHYs IGFyZ3NUYWlsKTsKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvU2NoZWR1bGVkQWN0aW9uLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9TY2hlZHVsZWRBY3Rpb24uaAkocmV2 aXNpb24gNDMwNDApCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjaGVkdWxlZEFjdGlvbi5oCSh3 b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAq LwogICAgIGNsYXNzIFNjaGVkdWxlZEFjdGlvbiB7CiAgICAgcHVibGljOgotICAgICAgICBzdGF0 aWMgU2NoZWR1bGVkQWN0aW9uKiBjcmVhdGUoY29uc3QgSlNDOjpBcmdMaXN0Jik7CisgICAgICAg IHN0YXRpYyBTY2hlZHVsZWRBY3Rpb24qIGNyZWF0ZShKU0M6OkV4ZWNTdGF0ZSosIGNvbnN0IEpT Qzo6QXJnTGlzdCYpOwogCiAgICAgICAgIHZvaWQgZXhlY3V0ZShTY3JpcHRFeGVjdXRpb25Db250 ZXh0Kik7CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQzMDQ1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDQtMjkgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU0NDAKKyAgICAgICAgc2V0VGltZW91dCBzaG91bGQgc3RyaW5naWZ5IG5vbi1zdHJp bmcvbm9uLWZ1bmN0aW9uIGZpcnN0IGFyZ3VtZW50cworCisgICAgICAgICogZmFzdC9kb20vV2lu ZG93L3NldFRpbWVvdXQtc3RyaW5nLWFyZ3VtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9kb20vV2luZG93L3NldFRpbWVvdXQtc3RyaW5nLWFyZ3VtZW50Lmh0bWw6IEFk ZGVkLgorCiAyMDA5LTA0LTI5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L3NldFRpbWVvdXQtc3RyaW5nLWFyZ3VtZW50LWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvc2V0VGltZW91dC1zdHJpbmctYXJn dW1lbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20v V2luZG93L3NldFRpbWVvdXQtc3RyaW5nLWFyZ3VtZW50LWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSw1IEBACitQQVNTOiBzZXRUaW1lb3V0KCJTVFJJTkciLCAwKSB3b3Jrcy4K K1BBU1M6IHNldFRpbWVvdXQoU3RyaW5nKCJTVFJJTkciKSwgMCkgd29ya3MuCitQQVNTOiBzZXRU aW1lb3V0KHt0b1N0cmluZzpmdW5jdGlvbigpe319LCAwKSB3b3Jrcy4KK1BBU1M6IEFsbCB0ZXN0 cyBwYXNzZWQuCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9zZXRUaW1lb3V0 LXN0cmluZy1hcmd1bWVudC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9t L1dpbmRvdy9zZXRUaW1lb3V0LXN0cmluZy1hcmd1bWVudC5odG1sCShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3NldFRpbWVvdXQtc3RyaW5nLWFyZ3VtZW50Lmh0 bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDkgQEAKKzxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJl PgorCisKKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKQorfQorCitmdW5jdGlvbiBsb2cobXNnKQoreworICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJykuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRl VGV4dE5vZGUobXNnICsgIlxuIikpOworfQorCitmdW5jdGlvbiB0MSgpCit7CisgICAgdmFyIGlk ID0gd2luZG93LnNldFRpbWVvdXQoImxvZygnUEFTUzogc2V0VGltZW91dChcIlNUUklOR1wiLCAw KSB3b3Jrcy4nKTsgdDIoKSIsIDApOworICAgIGlmIChpZCA9PSB1bmRlZmluZWQpCisgICAgICAg IGRvbmUoZmFsc2UpOworfQorCitmdW5jdGlvbiB0MigpCit7CisgICAgdmFyIGlkID0gd2luZG93 LnNldFRpbWVvdXQoU3RyaW5nKCJsb2coJ1BBU1M6IHNldFRpbWVvdXQoU3RyaW5nKFwiU1RSSU5H XCIpLCAwKSB3b3Jrcy4nKTsgdDMoKSIpLCAwKTsKKyAgICBpZiAoaWQgPT0gdW5kZWZpbmVkKQor ICAgICAgICBkb25lKGZhbHNlKTsKK30KKworZnVuY3Rpb24gdDMoKQoreworICAgIHZhciBpZCA9 IHdpbmRvdy5zZXRUaW1lb3V0KHsgdG9TdHJpbmcgOiBmdW5jdGlvbigpIHsgcmV0dXJuICJsb2co J1BBU1M6IHNldFRpbWVvdXQoe3RvU3RyaW5nOmZ1bmN0aW9uKCl7fX0sIDApIHdvcmtzLicpOyBk b25lKHRydWUpIiB9IH0sIDApOworICAgIGlmIChpZCA9PSB1bmRlZmluZWQpCisgICAgICAgIGRv bmUoZmFsc2UpOworfQorCitmdW5jdGlvbiBkb25lKGRpZFBhc3MpCit7CisgICAgaWYgKGRpZFBh c3MpCisgICAgICAgIGxvZygiUEFTUzogQWxsIHRlc3RzIHBhc3NlZC4iKTsKKyAgICBlbHNlCisg ICAgICAgIGxvZygiRkFJTDogQWxsIHRlc3RzIGRpZCBub3QgcGFzcy4iKTsKKworICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKK30KKwordDEoKTsKKworPC9zY3JpcHQ+Cg==