25430 2009-04-27 14:01:58 -0700 Enable loading style sheet for UI controls for media elements in Chromium port 2009-04-29 13:14:33 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 hclam webkit-unassigned dglazkov oldest_to_newest 119020 0 hclam 2009-04-27 14:01:58 -0700 Implement a virtual method in RenderTheme to provide style sheet for media controls in Chromium port. 119021 1 29826 hclam 2009-04-27 14:07:35 -0700 Created attachment 29826 patch + changelog Just the patch with change log, since <video> and <audio> in chromium is not ready to run through layout tests and the style for default ui is subject to change so no layout tests are provided. This patch is just to enable loading the style sheet so change the default style sheet would have effects. 119045 2 sam 2009-04-27 16:04:48 -0700 In the future, please don't remove the NOBODY (OOPS!) from the ChangeLog. We have post commit scripts that check to make sure the lander didn't forget to update the reviewer by checking for it. 119321 3 eric 2009-04-29 13:14:33 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderThemeChromiumWin.cpp M WebCore/rendering/RenderThemeChromiumWin.h Committed r43002 29826 2009-04-27 14:07:35 -0700 2009-04-27 15:34:15 -0700 patch + changelog webkit-render-theme.patch text/plain 1953 hclam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNDYwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDQtMjcgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSA/LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTQzMAorCisgICAgICAgIFByb3ZpZGUgc3R5bGUgc2hl ZXQgZm9yIFVJIGNvbnRyb2xzIG9mIG1lZGlhIGVsZW1lbnRzIGZvciBDaHJvbWl1bSBwb3J0Lgor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1XaW4uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bVdpbjo6ZXh0cmFNZWRpYUNvbnRyb2xzU3R5 bGVTaGVldCk6CisKIDIwMDktMDQtMjMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRoZW1lQ2hyb21pdW1XaW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZUNocm9taXVtV2luLmgJKHJldmlzaW9uIDE0NjA3KQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00 OSw2ICs0OSw5IEBACiAKICAgICAgICAgdmlydHVhbCBTdHJpbmcgZXh0cmFEZWZhdWx0U3R5bGVT aGVldCgpOwogICAgICAgICB2aXJ0dWFsIFN0cmluZyBleHRyYVF1aXJrc1N0eWxlU2hlZXQoKTsK KyNpZiBFTkFCTEUoVklERU8pCisgICAgICAgIHZpcnR1YWwgU3RyaW5nIGV4dHJhTWVkaWFDb250 cm9sc1N0eWxlU2hlZXQoKTsKKyNlbmRpZgogCiAgICAgICAgIC8vIEEgbWV0aG9kIGFza2luZyBp ZiB0aGUgdGhlbWUncyBjb250cm9scyBhY3R1YWxseSBjYXJlIGFib3V0IHJlZHJhd2luZyB3aGVu IGhvdmVyZWQuCiAgICAgICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0hvdmVyKGNvbnN0IFJlbmRl clN0eWxlKikgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5jcHAJKHJldmlzaW9uIDE0NjA3KQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTI2MSw2ICsyNjEsMTMgQEAKICAgICByZXR1cm4gU3RyaW5nKHRoZW1lV2luUXVpcmtzVXNlckFn ZW50U3R5bGVTaGVldCwgc2l6ZW9mKHRoZW1lV2luUXVpcmtzVXNlckFnZW50U3R5bGVTaGVldCkp OwogfQogCisjaWYgRU5BQkxFKFZJREVPKQorU3RyaW5nIFJlbmRlclRoZW1lQ2hyb21pdW1XaW46 OmV4dHJhTWVkaWFDb250cm9sc1N0eWxlU2hlZXQoKQoreworICAgIHJldHVybiBTdHJpbmcobWVk aWFDb250cm9sc1VzZXJBZ2VudFN0eWxlU2hlZXQsIHNpemVvZihtZWRpYUNvbnRyb2xzVXNlckFn ZW50U3R5bGVTaGVldCkpOworfQorI2VuZGlmCisKIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1bVdp bjo6c3VwcG9ydHNGb2N1c1JpbmcoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlKSBjb25zdAogewog ICAgLy8gTGV0IHdlYmtpdCBkcmF3IG9uZSBvZiBpdHMgaGFsbyByaW5ncyBhcm91bmQgYW55IGZv Y3VzZWQgZWxlbWVudCwK