254216 2023-03-21 09:14:06 -0700 [WinCairo] Compile error with ninja and ccache inside Batch 2023-04-15 02:04:08 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Windows 10 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=255481 InRadar P2 Normal --- 254458 1 max philn commit-queue fujii.hironori fujii philn webkit-bug-importer oldest_to_newest 1942842 0 max 2023-03-21 09:14:06 -0700 By default when ccache is available on the system, it gets used. As of today, when you try to compile WebKit on Windows with Ninja and ccmake (make sure its available in the path) it will throw the following error: (Tools\Scripts\build-webkit --wincairo --release --ninja) Not sure if its helpful, but I'm using: ninja --version -> 1.11.0 ccache --version -> 4.8 cmake -> 3.25.1-msvc1 [6382/6536] Building RC object Tools\MiniBrowser\win\CMakeFiles\MiniBrowserLib.dir\MiniBrowserLib.rc.res FAILED: Tools/MiniBrowser/win/CMakeFiles/MiniBrowserLib.dir/MiniBrowserLib.rc.res C:/ProgramData/chocolatey/bin/ccache.exe C:/PROGRA~1/CMake/bin/cmcldeps.exe RC C:\Users\maxschmitt\webkit\Tools\MiniBrowser\win\MiniBrowserLib.rc Tools\MiniBrowser \win\CMakeFiles\MiniBrowserLib.dir\MiniBrowserLib.rc.res.d Tools\MiniBrowser\win\CMakeFiles\MiniBrowserLib.dir\MiniBrowserLib.rc.res "Note: including file: " "C:/P rogram Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe" C:\PROGRA~2\WI3CF2~1\10\bin\100203~1.0\x64\rc.exe -DBUILDING _MiniBrowser -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DEGL_EGLEXT_PROTOTYPES -DEGL_EGL_PROTOTYPES=1 -DGL_GLES_PROTOTYPES=1 -DGL_GLEXT_PROTOTYPES -DHAVE_CONFIG_ H=1 -DMiniBrowserLib_EXPORTS -DNOCRYPT -DNOMINMAX -DPAS_BMALLOC=1 -DUNICODE -DUSE_SYSTEM_EGL -DWINVER=0x601 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECU RE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -I C:\Users\maxschmitt\webkit\WebKitBuild\Release -I C:\Users\maxsc hmitt\webkit\WebKitBuild\Release\JavaScriptCore\Headers -I C:\Users\maxschmitt\webkit\WebKitBuild\Release\JavaScriptCore\PrivateHeaders -I C:\Users\maxschmitt\webk it\WebKitBuild\Release\WTF\Headers -I C:\Users\maxschmitt\webkit\WebKitBuild\Release\WebCore\PrivateHeaders -I C:\Users\maxschmitt\webkit\WebKitBuild\Release\PAL\H eaders -I C:\Users\maxschmitt\webkit\WebKitBuild\Release\ANGLE\Headers -I C:\Users\maxschmitt\webkit\WebKitBuild\Release\WebKit\Headers -I C:\Users\maxschmitt\webk it\WebKitBuild\Release\WebKit\PrivateHeaders -I C:\Users\maxschmitt\webkit\WebKitBuild\Release\WebKit\DerivedSources -I C:\Users\maxschmitt\webkit\WebKitBuild\Rele ase\WebKit\DerivedSources\include -I C:\Users\maxschmitt\webkit\Source\WebKit -I C:\Users\maxschmitt\webkit\Source\WebKit\GPUProcess -I C:\Users\maxschmitt\webkit\ Source\WebKit\GPUProcess\graphics -I C:\Users\maxschmitt\webkit\Source\WebKit\GPUProcess\graphics\WebGPU -I C:\Users\maxschmitt\webkit\Source\WebKit\GPUProcess\med ia -I C:\Users\maxschmitt\webkit\Source\WebKit\GPUProcess\webrtc -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess -I C:\Users\maxschmitt\webkit\Source\We bKit\NetworkProcess\Classifier -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\Cookies -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\Custom Protocols -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\Downloads -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\FileAPI -I C:\Users\maxsc hmitt\webkit\Source\WebKit\NetworkProcess\IndexedDB -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\Notifications -I C:\Users\maxschmitt\webkit\Source\W ebKit\NetworkProcess\PrivateClickMeasurement -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\ServiceWorker -I C:\Users\maxschmitt\webkit\Source\WebKit\N etworkProcess\SharedWorker -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\cache -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\storage -I C :\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\watchos -I C:\Users\maxschmitt\webkit\Source\WebKit\NetworkProcess\webrtc -I C:\Users\maxschmitt\webkit\Sour ce\WebKit\Platform -I C:\Users\maxschmitt\webkit\Source\WebKit\Platform\IPC -I C:\Users\maxschmitt\webkit\Source\WebKit\PluginProcess -I C:\Users\maxschmitt\webkit \Source\WebKit\Shared -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\API -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\API\c -I C:\Users\maxschmitt\webkit \Source\WebKit\Shared\ApplePay -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\Authentication -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\CoreIPCSupport -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\Databases -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\Databases\IndexedDB -I C:\Users\maxschmitt\webkit\S ource\WebKit\Shared\FileAPI -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\Gamepad -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\Notifications -I C:\Users \maxschmitt\webkit\Source\WebKit\Shared\Plugins -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\Plugins\Netscape -I C:\Users\maxschmitt\webkit\Source\WebKit\Sha red\Plugins\Netscape\x11 -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\RemoteLayerTree -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\WebGPU -I C:\Users\m axschmitt\webkit\Source\WebKit\Shared\WebsiteData -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\XR -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess -I C: \Users\maxschmitt\webkit\Source\WebKit\UIProcess\API -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\API\C -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProc ess\API\cpp -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Authentication -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Automation -I C:\Users\maxsc hmitt\webkit\Source\WebKit\UIProcess\Downloads -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Gamepad -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\ GPU -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Inspector -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Inspector\Agents -I C:\Users\maxschmitt\w ebkit\Source\WebKit\UIProcess\Launcher -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Media -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Network -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Network\CustomProtocols -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Notifications -I C:\Users\maxschm itt\webkit\Source\WebKit\UIProcess\Plugins -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\RemoteLayerTree -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProc ess\UserContent -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\WebAuthentication -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\WebAuthentication\Moc k -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\WebsiteData -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\XR -I C:\Users\maxschmitt\webkit\Source\W ebKit\WebProcess -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\ApplePay -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\ApplicationCache -I C:\User s\maxschmitt\webkit\Source\WebKit\WebProcess\Automation -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Cache -I C:\Users\maxschmitt\webkit\Source\WebKit\We bProcess\Databases -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Databases\IndexedDB -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\EncryptedMedia -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\FileAPI -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\FullScreen -I C:\Users\maxschmitt\webkit\Sou rce\WebKit\WebProcess\Gamepad -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Geolocation -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\GPU -I C:\U sers\maxschmitt\webkit\Source\WebKit\WebProcess\GPU\graphics -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\GPU\graphics\WebGPU -I C:\Users\maxschmitt\webk it\Source\WebKit\WebProcess\GPU\media -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\GPU\webrtc -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Icon Database -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\InjectedBundle -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\InjectedBundle\API -I C:\User s\maxschmitt\webkit\Source\WebKit\WebProcess\InjectedBundle\API\c -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\InjectedBundle\DOM -I C:\Users\maxschmitt\ webkit\Source\WebKit\WebProcess\Inspector -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Launching -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\M ediaCache -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\MediaStream -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Model -I C:\Users\maxschmitt\we bkit\Source\WebKit\WebProcess\Network -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Network\webrtc -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\ Notifications -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\OriginData -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Plugins -I C:\Users\maxschmi tt\webkit\Source\WebKit\WebProcess\Plugins\Netscape -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\ResourceCache -I C:\Users\maxschmitt\webkit\Source\WebKi t\WebProcess\Speech -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Storage -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\UserContent -I C:\Users\m axschmitt\webkit\Source\WebKit\WebProcess\WebCoreSupport -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\WebPage -I C:\Users\maxschmitt\webkit\Source\WebKit \WebProcess\WebPage\RemoteLayerTree -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\WebStorage -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\XR -I C:\Users\maxschmitt\webkit\Source -I C:\Users\maxschmitt\webkit\WebKitLibraries -I C:\Users\maxschmitt\webkit\Source\WebKit\GPUProcess\graphics\wc -I C:\Users\maxs chmitt\webkit\Source\WebKit\NetworkProcess\curl -I C:\Users\maxschmitt\webkit\Source\WebKit\Platform\IPC\win -I C:\Users\maxschmitt\webkit\Source\WebKit\Platform\c lassifier -I C:\Users\maxschmitt\webkit\Source\WebKit\Platform\generic -I C:\Users\maxschmitt\webkit\Source\WebKit\PluginProcess\win -I C:\Users\maxschmitt\webkit\ Source\WebKit\Shared\API\c\win -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\CoordinatedGraphics -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\Coordinate dGraphics\threadedcompositor -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\Plugins\win -I C:\Users\maxschmitt\webkit\Source\WebKit\Shared\wc -I C:\Users\maxsc hmitt\webkit\Source\WebKit\Shared\win -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\API\C\cairo -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\API\C \curl -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\API\C\win -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\API\cpp\win -I C:\Users\maxschmitt\webk it\Source\WebKit\UIProcess\API\win -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\CoordinatedGraphics -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\ Inspector\socket -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Inspector\win -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\Plugins\win -I C:\Users\ maxschmitt\webkit\Source\WebKit\UIProcess\wc -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\win -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\GPU\g raphics\wc -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\InjectedBundle\API\win -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\InjectedBundle\API\ win\DOM -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\Inspector\win -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\WebCoreSupport\curl -I C:\Users \maxschmitt\webkit\Source\WebKit\WebProcess\WebCoreSupport\win -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\WebPage\CoordinatedGraphics -I C:\Users\maxsc hmitt\webkit\Source\WebKit\WebProcess\WebPage\wc -I C:\Users\maxschmitt\webkit\Source\WebKit\WebProcess\WebPage\win -I C:\Users\maxschmitt\webkit\Source\WebKit\win -I C:\Users\maxschmitt\webkit\Source\WebKit\UIProcess\socket -I C:\Users\maxschmitt\webkit\WebKitLibraries\win\include -I C:\Users\maxschmitt\webkit\WebKitLibrari es\win\include\libxml2 -I C:\Users\maxschmitt\webkit\WebKitLibraries\win\include\cairo -DWIN32 -D_ENABLE_EXTENDED_ALIGNED_STORAGE /fo Tools\MiniBrowser\win\CMakeFi les\MiniBrowserLib.dir\MiniBrowserLib.rc.res C:\Users\maxschmitt\webkit\Tools\MiniBrowser\win\MiniBrowserLib.rc ninja: FATAL: Couldn't parse arguments. usage: cmcldeps <language C, CXX or RC> <source file path> <output path for *.d file> <output path for *.obj file> <prefix of /showIncludes> <path to cl.exe> <p ath to tool (cl or rc)> <rest of command ...> [6383/6536] Building RC object Tools\MiniBrowser\win\CMakeFiles\MiniBrowser.dir\MiniBrowser.rc.res Based on this error, some more follow-up errors are thrown which are caused by no MiniBrowserLib.rc.obj... I suspect we need to set CMAKE_NINJA_FORCE_RESPONSE_FILE or similar to work around file path length limitations. 1942875 1 max 2023-03-21 11:09:53 -0700 I can verify that this is caused that we compiling inside MinGW -> Batch and hit the 8191 limitation (https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation). See e.g. https://gitlab.kitware.com/cmake/cmake/-/merge_requests/24 which is related. 1942883 2 max 2023-03-21 11:27:26 -0700 As per https://github.com/Kitware/CMake/commit/15b3f6f0f187ab12c29e437f737356bed13d977b and https://github.com/Kitware/CMake/blob/b69441c796827f28742e2b0a4a611c55c7d0ce45/Source/cmNinjaTargetGenerator.cxx#L652-L660 (current implementation) it looks like its not possible to have response files for RCs. 1943172 3 fujii 2023-03-22 13:51:11 -0700 MiniBrowserLib.rc.res isn't a response file, but an object file. WebKit implementation include paths shouldn't be propagating to MiniBrowser. I'm going to replace WebKit_INCLUDE_DIRECTORIES with WebKit_PRIVATE_INCLUDE_DIRECTORIES to stop propagating. 1943199 4 fujii 2023-03-22 15:17:27 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11827 1943468 5 ews-feeder 2023-03-23 13:17:19 -0700 Committed 262028@main (8da564110578): <https://commits.webkit.org/262028@main> Reviewed commits have been landed. Closing PR #11827 and removing active labels. 1943469 6 webkit-bug-importer 2023-03-23 13:18:20 -0700 <rdar://problem/107149973> 1943470 7 fujii 2023-03-23 13:19:12 -0700 Unfortunately, the bug still exists. Reopened. 1943496 8 fujii 2023-03-23 14:02:35 -0700 Here is my error message: [6376/6530] Building RC object Tools\MiniBrowser\win\CMakeFiles\MiniBrowserLib.dir\MiniBrowserLib.rc.res FAILED: Tools/MiniBrowser/win/CMakeFiles/MiniBrowserLib.dir/MiniBrowserLib.rc.res C:/ProgramData/chocolatey/bin/ccache.exe C:/PROGRA~1/CMake/bin/cmcldeps.exe RC C:\home\webkit\gc\Tools\MiniBrowser\win\MiniBrowserLib.rc Tools\MiniBrowser\win\CMakeFiles\MiniBrowserLib.dir\MiniBrowserLib.rc.res.d Tools\MiniBrowser\win\CMakeFiles\MiniBrowserLib.dir\MiniBrowserLib.rc.res "Note: including file: " "C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe" C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe -DBUILDING_MiniBrowser -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DEGL_EGLEXT_PROTOTYPES -DEGL_EGL_PROTOTYPES=1 -DGL_GLES_PROTOTYPES=1 -DGL_GLEXT_PROTOTYPES -DHAVE_CONFIG_H=1 -DMiniBrowserLib_EXPORTS -DNOCRYPT -DNOMINMAX -DPAS_BMALLOC=1 -DUNICODE -DUSE_SYSTEM_EGL -DWINVER=0x601 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -I C:\home\webkit\gc\WebKitBuild\Debug -I C:\home\webkit\gc\WebKitBuild\Debug\JavaScriptCore\Headers -I C:\home\webkit\gc\WebKitBuild\Debug\JavaScriptCore\PrivateHeaders -I C:\home\webkit\gc\WebKitBuild\Debug\WTF\Headers -I C:\home\webkit\gc\WebKitBuild\Debug\WebCore\PrivateHeaders -I C:\home\webkit\gc\WebKitBuild\Debug\PAL\Headers -I C:\home\webkit\gc\WebKitBuild\Debug\ANGLE\Headers -I C:\home\webkit\gc\WebKitBuild\Debug\WebKit\Headers -I C:\home\webkit\gc\WebKitBuild\Debug\WebKit\PrivateHeaders -I C:\home\webkit\gc\WebKitLibraries\win\include -I C:\home\webkit\gc\WebKitLibraries\win\include\libxml2 -I C:\home\webkit\gc\WebKitLibraries\win\include\cairo -DWIN32 -D_DEBUG -D_ENABLE_EXTENDED_ALIGNED_STORAGE /fo Tools\MiniBrowser\win\CMakeFiles\MiniBrowserLib.dir\MiniBrowserLib.rc.res C:\home\webkit\gc\Tools\MiniBrowser\win\MiniBrowserLib.rc cl : Command line warning D9002 : ignoring unknown option '/fo' c1: fatal error C1083: Cannot open source file: 'Tools\MiniBrowser\win\CMakeFiles\MiniBrowserLib.dir\MiniBrowserLib.rc.res.dep.obj ': No such file or directory MiniBrowserLib.rc 1943500 9 fujii 2023-03-23 14:08:47 -0700 If I invoke the above command line manually without the first item "C:/ProgramData/chocolatey/bin/ccache.exe", it passes. It seems like a ccache.exe problem. 1943502 10 fujii 2023-03-23 14:13:30 -0700 Looks like a same problem: MSVC resource compiler wrong case '/fo' parameter (#21328) · Issues · CMake / CMake · GitLab https://gitlab.kitware.com/cmake/cmake/-/issues/21328 1943508 11 fujii 2023-03-23 14:23:34 -0700 The document says we should use CMAKE_{LANG}_COMPILER_LAUNCHER. https://cmake.org/cmake/help/latest/prop_gbl/RULE_LAUNCH_COMPILE.html 1943517 12 fujii 2023-03-23 14:45:23 -0700 ccache doesn't seem to work as expected. It has no cach after compiling WebKit. Accoring to the document, https://ccache.dev/platform-compiler-language-support.html Run-time support: Windows native: B Run-time support: MSVC native: B Does it work fine for you? 1943524 13 fujii 2023-03-23 14:55:51 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11891 1943575 14 fujii 2023-03-23 17:41:08 -0700 It doesn't support /Zi and /Zc:lambda. It works as expected if I remove the switches. 1943786 15 max 2023-03-24 10:07:03 -0700 I can confirm after https://github.com/WebKit/WebKit/pull/11891 it compiles for me, thanks! 1943863 16 ews-feeder 2023-03-24 15:02:37 -0700 Committed 262101@main (0caa8dae5802): <https://commits.webkit.org/262101@main> Reviewed commits have been landed. Closing PR #11891 and removing active labels. 1943930 17 philn 2023-03-25 02:56:06 -0700 This broke sccache builds, the command line ends up chaining ccache to sccache... FAILED: Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/minalign32_heap_config.c.o /usr/bin/sccache /usr/bin/ccache /usr/lib/sdk/llvm14/bin/clang -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_bmalloc -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr /bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WebKitGTK-4.1\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -D_GNU_SOURCE -I/app/webkit/Source/bmalloc -I/app/webkit/Source/bmalloc/bmalloc -I/app/webkit/Sour ce/bmalloc/libpas/src/libpas -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -pipe -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing -format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fno-strict-aliasing -fno-exceptions -O3 -DNDEBUG -fPIC -fvisibility=hidden -Wno-missing-field-initializers -Wno-cast-align -MD -MT Sourc e/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/minalign32_heap_config.c.o -MF Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/minalign32_heap_config.c.o.d -o Source/bmalloc/CMakeFiles/bmalloc.dir/libpa s/src/libpas/minalign32_heap_config.c.o -c /app/webkit/Source/bmalloc/libpas/src/libpas/minalign32_heap_config.c sccache: error: failed to execute compile Reverting. 1943934 18 commit-queue 2023-03-25 02:58:14 -0700 Re-opened since this is blocked by bug 254458 1943938 19 philn 2023-03-25 03:04:49 -0700 Forgot to share this as well: sccache: caused by: Compiler not supported: "/usr/bin/ccache: invalid option -- \'E\'\n" 1943940 20 pnormand 2023-03-25 04:27:46 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11966 1944035 21 ews-feeder 2023-03-26 03:13:37 -0700 Committed 262125@main (c7e72788869f): <https://commits.webkit.org/262125@main> Reviewed commits have been landed. Closing PR #11966 and removing active labels.