254207 2023-03-21 04:32:58 -0700 media/media-source/media-source-remove-readystate is a failure on GTK/WPE and media/media-source/media-source-monitor-playing-event.html timeouts on WPE 2023-08-31 10:43:24 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Linux NEW https://bugs.webkit.org/show_bug.cgi?id=254198 P2 Normal --- 1 jean-yves.avenard webkit-unassigned aboya clopez oldest_to_newest 1942805 0 465538 jean-yves.avenard 2023-03-21 04:32:58 -0700 Created attachment 465538 TestCase Test added in bug 254198 is a constant failure and I can't make much sense of it seeing that readyState calculations should occur in platform agnostic code. The test calls `SourceBuffer.appendBuffer()` until there's over 10s of data added to the buffered range. Yet readyState stays at 1 (HAVE_METADATA) ``` --- /home/ews/worker/GTK-WK2-Tests-EWS/build/layout-test-results/media/media-source/media-source-remove-readystate-expected.txt +++ /home/ews/worker/GTK-WK2-Tests-EWS/build/layout-test-results/media/media-source/media-source-remove-readystate-actual.txt @@ -6,7 +6,7 @@ RUN(sourceBuffer.appendBuffer(loader.initSegment())) EVENT(update) Appending 10s Data -EXPECTED (video.readyState > '1') OK +EXPECTED (video.readyState > '1'), OBSERVED '1' FAIL RUN(video.currentTime = 2.5) EVENT(seeked) RUN(source.endOfStream()) @@ -15,6 +15,6 @@ RUN(sourceBuffer.remove(video.currentTime, video.currentTime + 5)) EVENT(waiting) EVENT(update) -EXPECTED (video.readyState == '1') OK +EXPECTED (video.readyState == '1'), OBSERVED '2' FAIL END OF TEST ``` 1943035 1 jean-yves.avenard 2023-03-22 01:32:24 -0700 The test found in `LayoutTests/media/media-source/media-source-monitor-playing-event.html` is incorrect too. There's a sleep(1s) right after `sourceBuffer.remove(0, 10)` to check the `readyState` but it should have been updated even before the `updateend` event got fired. I have marked it as failed for now. 1974762 2 clopez 2023-08-31 10:43:01 -0700 (In reply to Jean-Yves Avenard [:jya] from comment #1) > The test found in > `LayoutTests/media/media-source/media-source-monitor-playing-event.html` is > incorrect too. > > There's a sleep(1s) right after `sourceBuffer.remove(0, 10)` to check the > `readyState` but it should have been updated even before the `updateend` > event got fired. > > I have marked it as failed for now. The test media/media-source/media-source-monitor-playing-event.html passes fine on GTK now, but on WPE timeouts 90% of the times. 465538 2023-03-21 04:32:58 -0700 2023-03-21 04:32:58 -0700 TestCase media-source-remove-readystate.html text/html 2562 jean-yves.avenard PCFET0NUWVBFIGh0bWw+IDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgTWVkaWFTb3VyY2VFbmFi bGVkPXRydWUgXSAtLT4KPGh0bWw+CjxoZWFkPgogICAgPHRpdGxlPm1hbmFnZWRtZWRpYXNvdXJj ZS1zdHJlYW1pbmc8L3RpdGxlPgogICAgPHNjcmlwdCBzcmM9Ii4uLy4uL21lZGlhL21lZGlhLXNv dXJjZS9tZWRpYS1zb3VyY2UtbG9hZGVyLmpzIj48L3NjcmlwdD4KICAgIDxzY3JpcHQgc3JjPSIu Li8uLi9tZWRpYS92aWRlby10ZXN0LmpzIj48L3NjcmlwdD4KICAgIDxzY3JpcHQgc3JjPSIuLi8u Li9tZWRpYS91dGlsaXRpZXMuanMiPjwvc2NyaXB0PgogICAgPHNjcmlwdD4KICAgIHZhciBsb2Fk ZXI7CiAgICB2YXIgc291cmNlOwogICAgdmFyIHNvdXJjZUJ1ZmZlcjsKCiAgICBmdW5jdGlvbiBs b2FkZXJQcm9taXNlKGxvYWRlcikgewogICAgICAgIHJldHVybiBuZXcgUHJvbWlzZSgocmVzb2x2 ZSwgcmVqZWN0KSA9PiB7CiAgICAgICAgICAgIGxvYWRlci5vbmxvYWQgPSByZXNvbHZlOwogICAg ICAgICAgICBsb2FkZXIub25lcnJvciA9IHJlamVjdDsKICAgICAgICB9KTsKICAgIH0KCiAgICB3 aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGFzeW5jIGV2ZW50ID0+IHsKICAgICAgICB0 cnkgewogICAgICAgICAgICBmaW5kTWVkaWFFbGVtZW50KCk7CgogICAgICAgICAgICBsZXQgbWFu aWZlc3RzID0gWyAnY29udGVudC90ZXN0LW9wdXMtbWFuaWZlc3QuanNvbicsICdjb250ZW50L3Rl c3Qtdm9yYmlzLW1hbmlmZXN0Lmpzb24nLCAnY29udGVudC90ZXN0LTQ4a2h6LW1hbmlmZXN0Lmpz b24nLCAnY29udGVudC90ZXN0LXhoZS1hYWMtbWFuaWZlc3QuanNvbicgXTsKICAgICAgICAgICAg Zm9yIChjb25zdCBtYW5pZmVzdCBvZiBtYW5pZmVzdHMpIHsKICAgICAgICAgICAgICAgIGxvYWRl ciA9IG5ldyBNZWRpYVNvdXJjZUxvYWRlcihtYW5pZmVzdCk7CiAgICAgICAgICAgICAgICBhd2Fp dCBsb2FkZXJQcm9taXNlKGxvYWRlcik7CiAgICAgICAgICAgICAgICBpZiAoTWVkaWFTb3VyY2Uu aXNUeXBlU3VwcG9ydGVkKGxvYWRlci50eXBlKCkpKQogICAgICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICB9CgogICAgICAgICAgICB3YWl0Rm9yKHZpZGVvLCAnZXJyb3InKS50aGVu KGZhaWxUZXN0KTsKCiAgICAgICAgICAgIHJ1bignc291cmNlID0gbmV3IE1lZGlhU291cmNlKCkn KTsKICAgICAgICAgICAgcnVuKCd2aWRlby5zcmMgPSBVUkwuY3JlYXRlT2JqZWN0VVJMKHNvdXJj ZSknKTsKCiAgICAgICAgICAgIGF3YWl0IHdhaXRGb3Ioc291cmNlLCAnc291cmNlb3BlbicpOwoK ICAgICAgICAgICAgcnVuKCdzb3VyY2VCdWZmZXIgPSBzb3VyY2UuYWRkU291cmNlQnVmZmVyKGxv YWRlci50eXBlKCkpJyk7CgogICAgICAgICAgICBydW4oJ3NvdXJjZUJ1ZmZlci5hcHBlbmRCdWZm ZXIobG9hZGVyLmluaXRTZWdtZW50KCkpJyk7CiAgICAgICAgICAgIGF3YWl0IHdhaXRGb3Ioc291 cmNlQnVmZmVyLCAndXBkYXRlJyk7CgogICAgICAgICAgICBjb25zb2xlV3JpdGUoJ0FwcGVuZGlu ZyAxMHMgRGF0YScpOwogICAgICAgICAgICBkbyB7CiAgICAgICAgICAgICAgICBzb3VyY2VCdWZm ZXIuYXBwZW5kQnVmZmVyKGxvYWRlci5tZWRpYVNlZ21lbnQoMCkpOwogICAgICAgICAgICAgICAg YXdhaXQgb25jZShzb3VyY2VCdWZmZXIsICd1cGRhdGUnKTsKICAgICAgICAgICAgICAgIHNvdXJj ZUJ1ZmZlci50aW1lc3RhbXBPZmZzZXQgPSBzb3VyY2VCdWZmZXIuYnVmZmVyZWQuZW5kKHNvdXJj ZUJ1ZmZlci5idWZmZXJlZC5sZW5ndGggLSAxKTsKICAgICAgICAgICAgfSB3aGlsZSAoc291cmNl QnVmZmVyLmJ1ZmZlcmVkLmVuZChzb3VyY2VCdWZmZXIuYnVmZmVyZWQubGVuZ3RoLTEpIDwgMTAp OwogICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoJ3ZpZGVvLnJlYWR5U3RhdGUnLCAxLCAnPicpOwog ICAgICAgICAgICBydW4oJ3ZpZGVvLmN1cnJlbnRUaW1lID0gMi41Jyk7CiAgICAgICAgICAgIGF3 YWl0IHdhaXRGb3IodmlkZW8sICdzZWVrZWQnKTsKICAgICAgICAgICAgcnVuKCdzb3VyY2UuZW5k T2ZTdHJlYW0oKScpOwogICAgICAgICAgICBhd2FpdCB3YWl0Rm9yKHNvdXJjZSwgJ3NvdXJjZWVu ZGVkJyk7CiAgICAgICAgICAgIHJ1bigndmlkZW8ucGxheSgpJyk7CiAgICAgICAgICAgIHJ1bign c291cmNlQnVmZmVyLnJlbW92ZSh2aWRlby5jdXJyZW50VGltZSwgdmlkZW8uY3VycmVudFRpbWUg KyA1KScpOwogICAgICAgICAgICBhd2FpdCBQcm9taXNlLmFsbChbd2FpdEZvcih2aWRlbywgJ3dh aXRpbmcnKSwgd2FpdEZvcihzb3VyY2VCdWZmZXIsICd1cGRhdGUnKV0pOwoKICAgICAgICAgICAg dGVzdEV4cGVjdGVkKCd2aWRlby5yZWFkeVN0YXRlJywgMSk7CgogICAgICAgICAgICBlbmRUZXN0 KCk7CiAgICAgICAgfSBjYXRjaCAoZSkgewogICAgICAgICAgICBmYWlsVGVzdChgQ2F1Z2h0IGV4 Y2VwdGlvbjogIiR7ZX0iYCk7CiAgICAgICAgfQogICAgfSk7CiAgICA8L3NjcmlwdD4KPC9oZWFk Pgo8Ym9keT4KICAgIDx2aWRlbyBjb250cm9scz48L3ZpZGVvPgo8L2JvZHk+CjwvaHRtbD4K