254200 2023-03-20 23:13:01 -0700 [UI-side compositing] fast/repaint/canvas-object-fit.html fails on macOS due to a missing repaint rect 2023-03-21 12:46:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223283 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa bfulgham jenner simon.fraser webkit-bug-importer zalan oldest_to_newest 1942771 0 sabouhallawa 2023-03-20 23:13:01 -0700 --- /Volumes/z/safari/main/OpenSource/WebKitBuild/Debug/layout-test-results/fast/repaint/canvas-object-fit-expected.txt +++ /Volumes/z/safari/main/OpenSource/WebKitBuild/Debug/layout-test-results/fast/repaint/canvas-object-fit-actual.txt @@ -10,9 +10,6 @@ (position 8.00 8.00) (bounds 202.00 102.00) (drawsContent 1) - (repaint rects - (rect 70.00 20.00 7.00 7.00) - ) ) ) ) The problem is the two JS functions in the test are combined in one updateRendering() so we report one repaint rect which the entire canvas rect. So there is no user problem here but the test does not generate exactly the expected output. To fix the test, the first JS function needs to run in the first updateRendering() loop instead of running it onload. It looks like running the first JS function after two requestAnimationFrame(), fixes the test for WK1 as well. 1942772 1 sabouhallawa 2023-03-20 23:21:42 -0700 rdar://103582615 1942775 2 sabouhallawa 2023-03-20 23:33:44 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11747 1942891 3 sabouhallawa 2023-03-21 11:52:52 -0700 *** Bug 223283 has been marked as a duplicate of this bug. *** 1942902 4 ews-feeder 2023-03-21 12:46:19 -0700 Committed 261933@main (9eeb1f044a72): <https://commits.webkit.org/261933@main> Reviewed commits have been landed. Closing PR #11747 and removing active labels.