254183 2023-03-20 14:15:10 -0700 Let siblings layout if an adjacent float may no longer affect them 2023-04-01 10:04:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ahmad.saleem792 zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1942674 0 ahmad.saleem792 2023-03-20 14:15:10 -0700 Hi Team, While going through Blink's commit, I came across another potential merge and bug fix. Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/789b5e528fb3bd9ca44341de46547c45355652ab Test Case - https://jsfiddle.net/kqj93hp5/show ^ Failing in Safari Technology Preview 165, passes after adding following in WebKit Source: fb = std::max(fb, childBlockFlow->lowestFloatLogicalBottom()); In WebKit Source after this as L969: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow.cpp#968 Just wanted to raise so we can fix it. Thanks! 1942712 1 ahmad.saleem792 2023-03-20 16:25:50 -0700 (In reply to Ahmad Saleem from comment #0) > Hi Team, > > While going through Blink's commit, I came across another potential merge > and bug fix. > > Blink Commit - > https://chromium.googlesource.com/chromium/src.git/+/ > 789b5e528fb3bd9ca44341de46547c45355652ab > > Test Case - https://jsfiddle.net/kqj93hp5/show > > ^ Failing in Safari Technology Preview 165, passes after adding following in > WebKit Source: > > fb = std::max(fb, childBlockFlow->lowestFloatLogicalBottom()); > > In WebKit Source after this as L969: > > https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow. > cpp#968 > > Just wanted to raise so we can fix it. > > Thanks! Merging this as it is, led to crashes in my local build (It happened when I try to looked into old bugs with 'negative margin' reference to see, if they are now fixed with this or not. Additionally, then I took the patch reference to search whether there is any follow-up on Chromium / Blink and noticed that it had regression in performance test and got superseded by this: https://chromium.googlesource.com/chromium/src.git/+/4a961b8eca27af4108358a30753197754316524b 1944369 2 webkit-bug-importer 2023-03-27 14:16:17 -0700 <rdar://problem/107283741> 1945953 3 465729 zalan 2023-04-01 07:08:54 -0700 Created attachment 465729 [fast-cq]Patch 1945955 4 zalan 2023-04-01 07:10:32 -0700 Different approach as I am not convinced that the blink patch is correct. 1945965 5 ews-feeder 2023-04-01 10:04:02 -0700 Committed 262481@main (5673db1ac5ba): <https://commits.webkit.org/262481@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465729. 465729 2023-04-01 07:08:54 -0700 2023-04-01 10:04:03 -0700 [fast-cq]Patch bug-254183-20230401070854.patch text/plain 4164 zalan RnJvbSAzNDQ0ODM4YWVjM2Q0MTEzZjAxMWUzNWE3Y2RkMzY4NWEyYWJhNWM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFNhdCwgMSBBcHIgMjAyMyAwNjo0ODozMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIExldCBzaWJs aW5ncyBsYXlvdXQgaWYgYW4gYWRqYWNlbnQgZmxvYXQgbWF5IG5vIGxvbmdlciBhZmZlY3QKIHRo ZW0gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NDE4MwogPHJkYXI6 Ly9wcm9ibGVtLzEwNzI4Mzc0MT4KClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKV2hlbiBh IGNoYW5naW5nIGZsb2F0IHdhcyBwcmV2aW91c2x5IGludHJ1ZGluZyB0byBzaWJsaW5nIGJsb2Nr IGNvbnRhaW5lciBlLmcuCjxibG9jaz4KICA8ZmxvYXQgYm94PjwvZmxvYXQgYm94PgogIDxibG9j az4KICAgIFRoZSBmbG9hdCBib3ggc2hyaW5rcyB0aGUgYXZhaWxhYmxlIHNwYWNlIGhlcmUKICA8 L2Jsb2NrPgogIDxibG9jaz4KICAgIGFuZCBoZXJlIHRvbwogIDwvYmxvY2s+CjwvYmxvY2s+Cgp0 aGVzZSBzaWJsaW5nIGNvbnRhaW5lcnMgbmVlZCB0byBiZSBtYXJrZWQgZm9yIGxheW91dCBhcyB3 ZWxsLgoKKiBMYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0LW5vdC1pbnRydWRpbmct YW55bW9yZS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKiBMYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zs b2F0L2Zsb2F0LW5vdC1pbnRydWRpbmctYW55bW9yZS5odG1sOiBBZGRlZC4KKiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKFdlYkNvcmU6OlJlbmRlckJsb2Nr Rmxvdzo6bGF5b3V0QmxvY2tDaGlsZHJlbik6Ci0tLQogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrRmxvdy5jcHAgIHwgMTggKysrKysrKysrKysKIC4uLi9mbG9hdC1ub3QtaW50 cnVkaW5nLWFueW1vcmUtZXhwZWN0ZWQuaHRtbCB8ICA4ICsrKysrCiAuLi4vZmxvYXQvZmxvYXQt bm90LWludHJ1ZGluZy1hbnltb3JlLmh0bWwgICAgfCAzMiArKysrKysrKysrKysrKysrKysrCiAz IGZpbGVzIGNoYW5nZWQsIDU4IGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlv dXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0LW5vdC1pbnRydWRpbmctYW55bW9yZS1leHBl Y3RlZC5odG1sCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9mbG9h dC9mbG9hdC1ub3QtaW50cnVkaW5nLWFueW1vcmUuaHRtbAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggMTk4MjgwNDRmYjZiLi5lOTcxNjI3YWU3 ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBA IC04MjQsNiArODI0LDI0IEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93OjpsYXlvdXRCbG9ja0NoaWxk cmVuKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgTGF5b3V0VW5pdCYgbWF4CiAgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgfQogICAgICAgICBpZiAoY2hpbGQuaXNGbG9hdGluZygpKSB7Cisg ICAgICAgICAgICBhdXRvIG1hcmtTaWJsaW5nc0lmSW50cnVkaW5nRm9yTGF5b3V0ID0gWyZdIHsK KyAgICAgICAgICAgICAgICAvLyBMZXQncyBmaW5kIG91dCBpZiB0aGlzIGZsb2F0IGJveCBpcyAo d2FzKSBpbnRydWRpbmcgdG8gc2libGluZyBib3hlcyBhbmQgbWFyayB0aGVtIGZvciBsYXlvdXQg YWNjb3JkaW5nbHkuIAorICAgICAgICAgICAgICAgIGlmICghY2hpbGQuc2VsZk5lZWRzTGF5b3V0 KCkgfHwgIWNoaWxkLmV2ZXJIYWRMYXlvdXQoKSkgeworICAgICAgICAgICAgICAgICAgICAvLyBB dCB0aGlzIHBvaW50IGZsb2F0aW5nT2JqZWN0U2V0KCkgaXMgcHVyZ2VkLCB3ZSBjYW4ndCBjaGVj ayB3aGV0aGVyCisgICAgICAgICAgICAgICAgICAgIC8vIHRoaXMgaXMgYSBuZXcgb3IgYW4gZXhp c3RpbmcgZmxvYXQgaW4gdGhpcyBibG9jayBjb250YWluZXIuCisgICAgICAgICAgICAgICAgICAg IHJldHVybjsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgZm9yIChhdXRvKiBu ZXh0U2libGluZyA9IGNoaWxkLm5leHRTaWJsaW5nKCk7IG5leHRTaWJsaW5nOyBuZXh0U2libGlu ZyA9IG5leHRTaWJsaW5nLT5uZXh0U2libGluZygpKSB7CisgICAgICAgICAgICAgICAgICAgIGlm ICghaXM8UmVuZGVyQmxvY2tGbG93PigqbmV4dFNpYmxpbmcpKQorICAgICAgICAgICAgICAgICAg ICAgICAgY29udGludWU7CisgICAgICAgICAgICAgICAgICAgIGF1dG8mIGJsb2NrID0gZG93bmNh c3Q8UmVuZGVyQmxvY2tGbG93PigqbmV4dFNpYmxpbmcpOworICAgICAgICAgICAgICAgICAgICBp ZiAoYmxvY2suYXZvaWRzRmxvYXRzKCkgJiYgIWJsb2NrLnNocmlua1RvQXZvaWRGbG9hdHMoKSkK KyAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgICAgICBp ZiAoYmxvY2suY29udGFpbnNGbG9hdChjaGlsZCkpCisgICAgICAgICAgICAgICAgICAgICAgICBi bG9jay5tYXJrQWxsRGVzY2VuZGFudHNXaXRoRmxvYXRzRm9yTGF5b3V0KCk7CisgICAgICAgICAg ICAgICAgfQorICAgICAgICAgICAgfTsKKyAgICAgICAgICAgIG1hcmtTaWJsaW5nc0lmSW50cnVk aW5nRm9yTGF5b3V0KCk7CiAgICAgICAgICAgICBpbnNlcnRGbG9hdGluZ09iamVjdChjaGlsZCk7 CiAgICAgICAgICAgICBhZGp1c3RGbG9hdGluZ0Jsb2NrKG1hcmdpbkluZm8pOwogICAgICAgICAg ICAgY29udGludWU7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zs b2F0LW5vdC1pbnRydWRpbmctYW55bW9yZS1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9ibG9jay9mbG9hdC9mbG9hdC1ub3QtaW50cnVkaW5nLWFueW1vcmUtZXhwZWN0ZWQuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLmM1MmVjOTQwY2RkZQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvZmxvYXQtbm90LWlu dHJ1ZGluZy1hbnltb3JlLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw4IEBACis8c3R5bGU+Citk aXYgeworICB3aWR0aDogMTAwcHg7CisgIGhlaWdodDogNTBweDsKKyAgYmFja2dyb3VuZC1jb2xv cjpncmVlbjsKK30KKzwvc3R5bGU+Cis8ZGl2PjwvZGl2PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9ibG9jay9mbG9hdC9mbG9hdC1ub3QtaW50cnVkaW5nLWFueW1vcmUuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvZmxvYXQtbm90LWludHJ1ZGluZy1hbnltb3JlLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwLi5iMjdjNDc3MmVmNjYK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0LW5v dC1pbnRydWRpbmctYW55bW9yZS5odG1sCkBAIC0wLDAgKzEsMzIgQEAKKzxzdHlsZT4KKyNmbG9h dCB7CisgIGZsb2F0OiBsZWZ0OworICB3aWR0aDogMTAwcHg7CisgIGhlaWdodDogNTBweDsKK30K KworLmlubGluZSB7CisgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKKyAgYmFja2dyb3VuZC1jb2xv cjpncmVlbjsKKyAgd2lkdGg6IDEwMHB4OworICBoZWlnaHQ6IDUwcHg7Cit9CisKKy5zaG91bGRf bm90X3Nob3cgeworICBwb3NpdGlvbjogYWJzb2x1dGU7CisgIGJhY2tncm91bmQtY29sb3I6IHJl ZDsKKyAgei1pbmRleDogLTE7CisgIHdpZHRoOiAxMDBweDsKKyAgaGVpZ2h0OiA1MHB4OworfQor PC9zdHlsZT4KKzxkaXYgY2xhc3M9c2hvdWxkX25vdF9zaG93PjwvZGl2PgorPGRpdiBpZD1mbG9h dD48L2Rpdj4KKzxkaXY+CisgIDxkaXYgY2xhc3M9aW5saW5lPjwvZGl2PgorPC9kaXY+Cis8c2Ny aXB0PgorZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7CisvLyBUaGlzIGZsb2F0IGlzIG5vdCBpbnRy dWRpbmcgYW55bW9yZS4KK2Zsb2F0LnN0eWxlLm1hcmdpblRvcCA9ICItNTBweCI7Cis8L3Njcmlw dD4K