<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>253992</bug_id>
          
          <creation_ts>2023-03-15 17:03:52 -0700</creation_ts>
          <short_desc>New argument in run_benchmark&apos;s BrowserDriver init broke linux platform subclass</short_desc>
          <delta_ts>2023-03-15 18:41:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=253553</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="valerie young">spectranaut</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>clopez</cc>
    
    <cc>emw</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1941709</commentid>
    <comment_count>0</comment_count>
    <who name="valerie young">spectranaut</who>
    <bug_when>2023-03-15 17:03:52 -0700</bug_when>
    <thetext>Introduced by: https://github.com/WebKit/WebKit/commit/fa4a5245bfbbbbd12c6fd9fea70b4efc83f2023a

The fix is simple, we just need to expect that argument in the init here: https://github.com/WebKit/WebKit/blob/a48e91ce4ab51138a9c6f01a2289c5429f11be21/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py#L48

I&apos;ll submit a fix right now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1941717</commentid>
    <comment_count>1</comment_count>
    <who name="valerie young">spectranaut</who>
    <bug_when>2023-03-15 17:16:10 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/11581</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1941719</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-03-15 17:44:49 -0700</bug_when>
    <thetext>Committed 261723@main (9179a6c1494d): &lt;https://commits.webkit.org/261723@main&gt;

Reviewed commits have been landed. Closing PR #11581 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1941720</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-03-15 17:45:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/106782597&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1941736</commentid>
    <comment_count>4</comment_count>
    <who name="Elliott Williams">emw</who>
    <bug_when>2023-03-15 18:41:06 -0700</bug_when>
    <thetext>Thank you and sorry for the disruption!</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>