253913 2023-03-14 15:06:30 -0700 [GTK][WPE] run-webkit-tests: Add an option to enable coredumps and selectively enable it on the bots. 2023-03-15 17:53:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=252762 InRadar P2 Normal --- 1 clopez clopez bugs-noreply fujii webkit-bug-importer oldest_to_newest 1941354 0 clopez 2023-03-14 15:06:30 -0700 On the GTK and WPE test bots we run with coredumps enabled so when layout tests crash they generate a coredump and we get a backtrace. The problem is on the EWS bots that we repeat each failure up to 11 times each failure 10 times then a lot of coredumps can be generated in a sort space of time. This may end causing the bot to run out of space. In bug 252762 I implemented a way of cleaning the coredump after processing it but it seems this is not enough as sometimes the bots are still filing the disk. See: https://ews-build.webkit.org/#/builders/86/builds/5299 The cause is that sometimes crashes happen that are not intercepted by the tooling so those coredump don't get deleted after generating them. It would be good to investigate why those crashes are not intercepted by the tooling, and is on my todo. However, at any rate, it makes little sense that we run with coredumps enabled the repeat steps for the EWS. If a test is crashing 11 times we don't need to generate 11 coredumps. It is enough with just picking one. So I think we should disable coredumps when doing the repeat steps. For doing this we can implement a new flag that can be passed to run-webkit-tests to enable coredumps and we pass this flag on the bots for the steps we want coredumps to be generated. This can be useful also for developers as they can just enable coredumps when running tests by passing a flag to run-webkit-tests instead of enabling those on the parent sell. This also has the advantage of having faster runs when doing the retry step with lot of crashes. Having to generate 11 coredumps per crashing test and running GDB on all of them to generate the backtrace is really slow and can make the retry test step last 10x or 20x more time. Generating each backtrace can take easily 1 or 2 minutes so we are spending 10 or 20 minutes per each test that crashes. Not good. 1941422 1 clopez 2023-03-14 18:55:41 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11533 1941641 2 ews-feeder 2023-03-15 13:15:03 -0700 Committed 261707@main (4bf80e3962bb): <https://commits.webkit.org/261707@main> Reviewed commits have been landed. Closing PR #11533 and removing active labels. 1941642 3 webkit-bug-importer 2023-03-15 13:16:17 -0700 <rdar://problem/106769832> 1941722 4 fujii 2023-03-15 17:53:11 -0700 Regressed: Bug 253994 – REGRESSION(261707@main) run-webkit-tests: ModuleNotFoundError: No module named 'resource'