253868 2023-03-13 19:26:54 -0700 REGRESSION(261559@main) [Win] js/ShadowRealm-iframe-detach.html is randomly timing out 2023-03-28 14:34:14 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 fujii fujii webkit-bug-importer oldest_to_newest 1941100 0 fujii 2023-03-13 19:26:54 -0700 REGRESSION(261559@main) [Win] js/ShadowRealm-iframe-detach.html is randomly timing out After 261559@main (bug#175336) disabled USE_CF for WinCairo, the following tests are randomly timing out. js/ShadowRealm-iframe-detach.html js/ShadowRealm-importValue.html The timeout is more likely happening in the first time. --run-singly switch is useful to reproduce the timeout. > python.exe ./Tools/Scripts/run-webkit-tests --wincairo --debug js/ShadowRealm-iframe-detach.html --iterations=30 -v --no-retry-failures --run-singly The reproduction rate is 8/30. 1941101 1 465428 fujii 2023-03-13 19:28:07 -0700 Created attachment 465428 WIP patch This patch resolves the problem. I don't understand reportAbandonedObjectGraph at all. 1941428 2 fujii 2023-03-14 19:20:13 -0700 Test gardening by 261667@main. 1941748 3 fujii 2023-03-15 19:21:36 -0700 If I keep 'realm' in the 'window' object, the timeout problem doesn't happen. The realm is garbage collected!? diff --git a/LayoutTests/js/ShadowRealm-iframe-detach.html b/LayoutTests/js/ShadowRealm-iframe-detach.html index d4651f0897d2..1c0e3721705b 100644 --- a/LayoutTests/js/ShadowRealm-iframe-detach.html +++ b/LayoutTests/js/ShadowRealm-iframe-detach.html @@ -22,6 +22,7 @@ frame.onload = async () => { debug(frame); let realm = frame.realm; + window.xxx = realm; debug("detaching iframe"); document.getElementsByTagName("iframe")[0].remove() $vm.gc(); 1942026 4 fujii 2023-03-16 21:34:33 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11639 1942471 5 465511 fujii 2023-03-19 20:51:35 -0700 Created attachment 465511 patch to reproduce the timeout for Mac port This timeout is reproducible with Mac port if I apply this patch to take the garbageCollectOnNextRunLoop code path. > Tools/Scripts/run-webkit-tests --debug js/ShadowRealm-iframe-detach.html --iterations=30 --no-retry-failures --run-singly The reproduction rate is 25/30. 1942756 6 webkit-bug-importer 2023-03-20 19:27:25 -0700 <rdar://problem/106974546> 1944114 7 ews-feeder 2023-03-26 21:22:16 -0700 Committed 262136@main (6c72fadf79d3): <https://commits.webkit.org/262136@main> Reviewed commits have been landed. Closing PR #11639 and removing active labels. 1944752 8 fujii 2023-03-28 14:27:45 -0700 The test is still timing out on a Buildbot tester even after 262136@main. Reopened. https://results.webkit.org/?suite=layout-tests&test=js%2FShadowRealm-importValue.html 1944753 9 fujii 2023-03-28 14:34:14 -0700 It's a wrong URL. js/ShadowRealm-iframe-detach.html is still timing out. https://results.webkit.org/?platform=wincairo&suite=layout-tests&test=js%2FShadowRealm-iframe-detach.html js/ShadowRealm-importValue.html and http/tests/misc/iframe-shadow-realm.html doesn't seem to time out after the change. https://results.webkit.org/?platform=wincairo&suite=layout-tests&suite=layout-tests&test=js%2FShadowRealm-importValue.html&test=http%2Ftests%2Fmisc%2Fiframe-shadow-realm.html 465428 2023-03-13 19:28:07 -0700 2023-03-16 21:41:02 -0700 WIP patch wip.patch text/plain 1254 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwCmluZGV4IDVmOTM0 OTE3NTZmMi4uNmI2YWU0NTM0NTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9HQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dD Q29udHJvbGxlci5jcHAKQEAgLTcwLDcgKzcwLDcgQEAgdm9pZCBHQ0NvbnRyb2xsZXI6OmdhcmJh Z2VDb2xsZWN0U29vbigpCiAgICAgLy8gV2Ugb25seSB1c2UgcmVwb3J0QWJhbmRvbmVkT2JqZWN0 R3JhcGggZm9yIHN5c3RlbXMgZm9yIHdoaWNoIHRoZXJlJ3MgYW4gaW1wbGVtZW50YXRpb24KICAg ICAvLyBvZiB0aGUgZ2FyYmFnZSBjb2xsZWN0b3IgdGltZXJzIGluIEphdmFTY3JpcHRDb3JlLiBX ZSB3b3VsZG4ndCBuZWVkIHRoaXMgaWYgSmF2YVNjcmlwdENvcmUKICAgICAvLyB1c2VkIGEgdGlt ZXIgaW1wbGVtZW50YXRpb24gZnJvbSBXVEYgbGlrZSBSdW5Mb29wOjpUaW1lci4KLSNpZiBVU0Uo Q0YpIHx8IFVTRShHTElCKQorI2lmIFVTRShDRikgfHwgVVNFKEdMSUIpIHx8IDEKICAgICBKU0xv Y2tIb2xkZXIgbG9jayhjb21tb25WTSgpKTsKICAgICBjb21tb25WTSgpLmhlYXAucmVwb3J0QWJh bmRvbmVkT2JqZWN0R3JhcGgoKTsKICNlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93 b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29y a2VyR2xvYmFsU2NvcGUuY3BwCmluZGV4IDM0NzQ4NWEyODQ4YS4uMjU3ODE3NmM3MWUxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmNwcApAQCAtNjA3LDcg KzYwNyw3IEBAIHZvaWQgV29ya2VyR2xvYmFsU2NvcGU6OmRlbGV0ZUpTQ29kZUFuZEdDKFN5bmNo cm9ub3VzIHN5bmNocm9ub3VzKQogICAgICAgICByZXR1cm47CiAgICAgfQogI2VuZGlmCi0jaWYg VVNFKENGKSB8fCBVU0UoR0xJQikKKyNpZiBVU0UoQ0YpIHx8IFVTRShHTElCKSB8fCAxCiAgICAg dm0oKS5oZWFwLnJlcG9ydEFiYW5kb25lZE9iamVjdEdyYXBoKCk7CiAjZWxzZQogICAgIHZtKCku aGVhcC5jb2xsZWN0Tm93KEpTQzo6QXN5bmMsIEpTQzo6Q29sbGVjdGlvblNjb3BlOjpGdWxsKTsK 465511 2023-03-19 20:51:35 -0700 2023-03-19 20:51:46 -0700 patch to reproduce the timeout for Mac port debug-patch-for-mac.patch text/plain 999 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwCmluZGV4IDVmOTM0 OTE3NTZmMi4uNDE1MjAyMTRlNzU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9HQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dD Q29udHJvbGxlci5jcHAKQEAgLTcwLDcgKzcwLDcgQEAgdm9pZCBHQ0NvbnRyb2xsZXI6OmdhcmJh Z2VDb2xsZWN0U29vbigpCiAgICAgLy8gV2Ugb25seSB1c2UgcmVwb3J0QWJhbmRvbmVkT2JqZWN0 R3JhcGggZm9yIHN5c3RlbXMgZm9yIHdoaWNoIHRoZXJlJ3MgYW4gaW1wbGVtZW50YXRpb24KICAg ICAvLyBvZiB0aGUgZ2FyYmFnZSBjb2xsZWN0b3IgdGltZXJzIGluIEphdmFTY3JpcHRDb3JlLiBX ZSB3b3VsZG4ndCBuZWVkIHRoaXMgaWYgSmF2YVNjcmlwdENvcmUKICAgICAvLyB1c2VkIGEgdGlt ZXIgaW1wbGVtZW50YXRpb24gZnJvbSBXVEYgbGlrZSBSdW5Mb29wOjpUaW1lci4KLSNpZiBVU0Uo Q0YpIHx8IFVTRShHTElCKQorI2lmIDAKICAgICBKU0xvY2tIb2xkZXIgbG9jayhjb21tb25WTSgp KTsKICAgICBjb21tb25WTSgpLmhlYXAucmVwb3J0QWJhbmRvbmVkT2JqZWN0R3JhcGgoKTsKICNl bHNlCkBAIC0xMDAsNyArMTAwLDcgQEAgdm9pZCBHQ0NvbnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0 Tm93KCkKIAogdm9pZCBHQ0NvbnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0Tm93SWZOb3REb25lUmVj ZW50bHkoKQogewotI2lmIFVTRShDRikgfHwgVVNFKEdMSUIpCisjaWYgMAogICAgIEpTTG9ja0hv bGRlciBsb2NrKGNvbW1vblZNKCkpOwogICAgIGlmICghY29tbW9uVk0oKS5oZWFwLmN1cnJlbnRU aHJlYWRJc0RvaW5nR0NXb3JrKCkpCiAgICAgICAgIGNvbW1vblZNKCkuaGVhcC5jb2xsZWN0Tm93 RnVsbElmTm90RG9uZVJlY2VudGx5KEFzeW5jKTsK