253841 2023-03-13 12:57:05 -0700 Ignore calc() values on colgroup elements 2023-10-11 07:28:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=254034 https://bugs.webkit.org/show_bug.cgi?id=262918 InRadar P2 Normal --- 254038 1 ahmad.saleem792 webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1940973 0 ahmad.saleem792 2023-03-13 12:57:05 -0700 Hi Team, While going through Blink's commit, I came across following commit, which can be merged and in local testing on WebKit ToT, it fixes following test: Test Case - https://jsfiddle.net/a0r9q1p3/show ^ Fails in Safari Technology Preview 165. Passes in Chrome Canary 113 and Firefox Nightly 112. Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=193912 WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/AutoTableLayout.cpp#157 ^ I am not going to add FIXME, because I am planning to look into fixing by merging other subsequent Blink patches as well after local testing. Just wanted to raise so I can fix it. It might progress - auto-layout-calc-width-001.html test case as well. Thanks! 1941166 1 ews-feeder 2023-03-14 03:29:16 -0700 Committed 261623@main (f013f2c88a3b): <https://commits.webkit.org/261623@main> Reviewed commits have been landed. Closing PR #11457 and removing active labels. 1941167 2 webkit-bug-importer 2023-03-14 03:30:18 -0700 <rdar://problem/106692191> 1941907 3 commit-queue 2023-03-16 10:58:16 -0700 Re-opened since this is blocked by bug 254038 1984089 4 ahmad.saleem792 2023-10-10 12:01:04 -0700 I just ran full css-tables suite of WPT via --debug flag on top of 269151@main (debug build) and didn't get any debug crash or assert failure. I think post Alan's fix of bug 262918, it seems we can land this. Going to do PR now. 1984091 5 ahmad.saleem792 2023-10-10 12:12:59 -0700 Another PR attempt - https://github.com/WebKit/WebKit/pull/18900 1984287 6 ews-feeder 2023-10-11 07:28:06 -0700 Committed 269200@main (a47442a35d9c): <https://commits.webkit.org/269200@main> Reviewed commits have been landed. Closing PR #18900 and removing active labels.