253837 2023-03-13 11:58:17 -0700 Reduce some costly includes from WebPage.h 2023-03-16 12:29:34 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 253601 1 bfulgham fujii webkit-bug-importer oldest_to_newest 1940956 0 bfulgham 2023-03-13 11:58:17 -0700 This is a subset of the mega-patch in Bug 253601. Benchmarking shows that WebPage.h is very costly to parse due to a few heavyweight includes. We can improve build time by using more specific includes where appropriate, and forward declare classes when possible. 1940957 1 webkit-bug-importer 2023-03-13 12:01:09 -0700 <rdar://problem/106655602> 1940959 2 bfulgham 2023-03-13 12:05:22 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11451 1941577 3 bfulgham 2023-03-15 09:47:17 -0700 Pull request: https://github.com/Webkit/WebKit/pull/11451 1941653 4 ews-feeder 2023-03-15 13:39:51 -0700 Committed 261710@main (d59dce7984ad): <https://commits.webkit.org/261710@main> Reviewed commits have been landed. Closing PR #11451 and removing active labels. 1941673 5 fujii 2023-03-15 14:53:05 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/11574 1941674 6 ews-feeder 2023-03-15 14:57:24 -0700 Committed 261715@main (baddb1e77fcb): <https://commits.webkit.org/261715@main> Reviewed commits have been landed. Closing PR #11574 and removing active labels. 1941680 7 fujii 2023-03-15 15:25:02 -0700 Hmm, GTK/WPE are still broken. WinCairo/PlayStation got back to green. 1941685 8 bfulgham 2023-03-15 15:35:23 -0700 It looks like your fix should work for WPE/GTK, too. They are complaining about Logging in debug build for the same symbols you just landed. 1941718 9 fujii 2023-03-15 17:37:23 -0700 Ah, you are right. I checked a wrong revision. GTK is green. WPE bot is still building.