25380 2009-04-24 15:37:52 -0700 LayoutTests/media/video-played.html has a race condition when starting the test. 2009-04-24 15:53:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pdherbemont webkit-unassigned oldest_to_newest 118753 0 pdherbemont 2009-04-24 15:37:52 -0700 LayoutTests/media/video-played.html has a race condition when starting the test. The test may attempt to call video.play() even before the 'canplay' event has been fired. 118754 1 29768 pdherbemont 2009-04-24 15:39:03 -0700 Created attachment 29768 patch v1. 118755 2 29768 simon.fraser 2009-04-24 15:41:57 -0700 Comment on attachment 29768 patch v1. > Index: LayoutTests/ChangeLog > =================================================================== > --- LayoutTests/ChangeLog (revision 42845) > +++ LayoutTests/ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Fixed a race condition on the first 'played' attribute test start. > + > + Previously we were starting nearly right away to play, and probably > + before receiving the 'canplay' event. Now we ensure we'll wait for > + that 'canplay' event before attempting to play. "...before starting the tests." > waitForEvent("loadedmetadata"); > - waitForEvent("canplay", canplay); > + waitForEvent("canplay", canplay); // Will triggers nextTest() which launches the tests. "Will trigger" r=me 118758 3 simon.fraser 2009-04-24 15:53:03 -0700 http://trac.webkit.org/changeset/42848 29768 2009-04-24 15:39:03 -0700 2009-04-24 15:41:57 -0700 patch v1. played_patchv1.patch text/plain 2235 pdherbemont SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQyODQ1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDQtMjQgIFBpZXJyZSBkJ0hlcmJlbW9u dCAgPHBkaGVyYmVtb250QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCBhIHJhY2UgY29uZGl0aW9uIG9uIHRoZSBmaXJzdCAn cGxheWVkJyBhdHRyaWJ1dGUgdGVzdCBzdGFydC4KKworICAgICAgICBQcmV2aW91c2x5IHdlIHdl cmUgc3RhcnRpbmcgbmVhcmx5IHJpZ2h0IGF3YXkgdG8gcGxheSwgYW5kIHByb2JhYmx5CisgICAg ICAgIGJlZm9yZSByZWNlaXZpbmcgdGhlICdjYW5wbGF5JyBldmVudC4gTm93IHdlIGVuc3VyZSB3 ZSdsbCB3YWl0IGZvcgorICAgICAgICB0aGF0ICdjYW5wbGF5JyBldmVudCBiZWZvcmUgYXR0ZW1w dGluZyB0byBwbGF5LgorCisgICAgICAgICogbWVkaWEvdmlkZW8tcGxheWVkLWV4cGVjdGVkLnR4 dDogVXBkYXRlZAorICAgICAgICAqIG1lZGlhL3ZpZGVvLXBsYXllZC5odG1sOgorCiAyMDA5LTA0 LTI0ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBTaW1vbiBGcmFzZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wbGF5ZWQtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXllZC1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDQyODM1KQorKysgTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8t cGxheWVkLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSwxMSArMSwxMSBAQAogVGVz dCBvZiB0aGUgbWVkaWEgZWxlbWVudCAncGxheWVkJyBhdHRyaWJ1dGUKIAotCi1UZXN0IHBsYXlp bmcgd2hlbiB0aGVyZSBhcmUgbm8gcmFuZ2VzCiBFVkVOVChsb2Fkc3RhcnQpCiBFVkVOVChsb2Fk ZWRtZXRhZGF0YSkKIEVWRU5UKGNhbnBsYXkpCiBUZXN0IDEgT0sKKworVGVzdCBwbGF5aW5nIHdo ZW4gdGhlcmUgYXJlIG5vIHJhbmdlcwogUlVOKHZpZGVvLnBsYXkoKSkKIFJVTih2aWRlby5wYXVz ZSgpKQogRVZFTlQocGF1c2UpCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wbGF5ZWQu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wbGF5ZWQuaHRtbAko cmV2aXNpb24gNDI4MzUpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wbGF5ZWQuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtMjI1LDggKzIyNSw3IEBACiAgICAgICAgICAgICBmdW5jdGlvbiBj YW5wbGF5KGV2ZW50KSAKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICB0ZXN0UmFuZ2Vz KCk7Ci0gICAgICAgICAgICAgICAgaWYgKGN1cnJlbnRUZXN0ID4gMSkKLSAgICAgICAgICAgICAg ICAgICAgbmV4dFRlc3QoKTsKKyAgICAgICAgICAgICAgICBuZXh0VGVzdCgpOwogICAgICAgICAg ICAgfQogCiAgICAgICAgICAgICBmdW5jdGlvbiB3aWxsQ3JlYXRlTmV3UmFuZ2UoKQpAQCAtMjU3 LDEyICsyNTYsMTAgQEAKICAgICAgICAgICAgICAgICB3YWl0Rm9yRXZlbnQoImxvYWRzdGFydCIp OwogICAgICAgICAgICAgICAgIHdhaXRGb3JFdmVudCgicmF0ZWNoYW5nZSIpOwogICAgICAgICAg ICAgICAgIHdhaXRGb3JFdmVudCgibG9hZGVkbWV0YWRhdGEiKTsKLSAgICAgICAgICAgICAgICB3 YWl0Rm9yRXZlbnQoImNhbnBsYXkiLCBjYW5wbGF5KTsKKyAgICAgICAgICAgICAgICB3YWl0Rm9y RXZlbnQoImNhbnBsYXkiLCBjYW5wbGF5KTsgLy8gV2lsbCB0cmlnZ2VycyBuZXh0VGVzdCgpIHdo aWNoIGxhdW5jaGVzIHRoZSB0ZXN0cy4KICAgICAgICAgICAgICAgICB3YWl0Rm9yRXZlbnQoInBh dXNlIiwgcGF1c2UpOwogCiAgICAgICAgICAgICAgICAgdmlkZW8ubG9hZCgpOwotCi0gICAgICAg ICAgICAgICAgbmV4dFRlc3QoKTsKICAgICAgICAgICAgIH0KICAgICAgICAgPC9zY3JpcHQ+CiAg ICAgIDwvaGVhZD4K