25378 2009-04-24 14:48:04 -0700 Document InlineBox::x(),y() 2009-05-05 22:49:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 playmobil webkit-unassigned eric hyatt oldest_to_newest 118741 0 playmobil 2009-04-24 14:48:04 -0700 The use of m_x & m_y in InlineBox and it's various inherited classes is a little confusing. Adding a comment to clear up what they represent would be helpful. 118747 1 29767 playmobil 2009-04-24 14:54:05 -0700 Created attachment 29767 patch 119051 2 eric 2009-04-27 17:13:13 -0700 This agrees with my understanding of InlineBox::x() and y(). Assuming Hyatt agrees, r+. 119808 3 29767 eric 2009-05-04 01:52:52 -0700 Comment on attachment 29767 patch Assuming Hyatt's silence is agreement. 120067 4 eric 2009-05-05 22:49:48 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/InlineBox.h Committed r43282 29767 2009-04-24 14:54:05 -0700 2009-05-04 01:52:52 -0700 patch documentation.patch text/plain 1273 playmobil Y29tbWl0IGIwZWFiNTkzN2YwODNiZGVmNTRkODQ2ODM1ZTUyMjFmNzIwNmJlMTMKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIEZyaSBBcHIgMjQg MTQ6NDk6MzEgMjAwOSAtMDcwMAoKICAgIEFkZCBzb21lIGRvY3VtZW50YXRpb24gYWJvdXQgY29v cmRpbmF0ZSBzeXN0ZW1zIHRvIElubGluZUJveC4KCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGY5ZDVlNjguLjQyYTA1MzYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMDktMDQtMjQgIEplcmVteSBNb3Nrb3ZpY2ggIDxqZXJlbXlAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBz b21lIGRvY3VtZW50YXRpb24gdG8gSW5saW5lQm94Ojp4KCkseSgpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTM3OAorCisgICAgICAgICogcmVu ZGVyaW5nL0lubGluZUJveC5oOgorCiAyMDA5LTA0LTI0ICBEYXZpZCBMZXZpbiAgPGxldmluQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKGNocm9taXVtIGJ1aWxk IGZpeCkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaCBiL1dlYkNv cmUvcmVuZGVyaW5nL0lubGluZUJveC5oCmluZGV4IGU2NjU3NGEuLmFmMTA3MjUgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUJveC5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5n L0lubGluZUJveC5oCkBAIC0xODIsOSArMTgyLDExIEBAIHB1YmxpYzoKICAgICB2b2lkIHNldFdp ZHRoKGludCB3KSB7IG1fd2lkdGggPSB3OyB9CiAgICAgaW50IHdpZHRoKCkgY29uc3QgeyByZXR1 cm4gbV93aWR0aDsgfQogCisgICAgLy8geCgpIGlzIHRoZSBsZWZ0IHNpZGUgb2YgdGhlIGJveCBp biB0aGUgcGFyZW50J3MgY29vcmRpbmF0ZSBzeXN0ZW0uCiAgICAgdm9pZCBzZXRYKGludCB4KSB7 IG1feCA9IHg7IH0KICAgICBpbnQgeCgpIGNvbnN0IHsgcmV0dXJuIG1feDsgfQogCisgICAgLy8g eSgpIGlzIHRoZSB0b3Agb2YgdGhlIGJveCBpbiB0aGUgcGFyZW50J3MgY29vcmRpbmF0ZSBzeXN0 ZW0uCiAgICAgdm9pZCBzZXRZKGludCB5KSB7IG1feSA9IHk7IH0KICAgICBpbnQgeSgpIGNvbnN0 IHsgcmV0dXJuIG1feTsgfQogCg==