25375 2009-04-24 13:46:58 -0700 [GTK] Add translator comment to translatable message(s) 2021-05-06 01:58:02 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED CONFIGURATION CHANGED P2 Minor --- 0 elle.uca christian bugs-noreply darin eric gustavo mrobinson piotrdrag oldest_to_newest 118721 0 elle.uca 2009-04-24 13:46:58 -0700 #: WebCore/platform/gtk/LocalizedStringsGtk.cpp:66 msgid "_Searchable Index" This is a translatable message for WebKitGtk. Could be good add here (and maybe on other messages) a little suggestion or tip or explanation about where the message will appear and its meaning, in order to help translators to produce a better work. 118724 1 elle.uca 2009-04-24 13:48:53 -0700 #: WebCore/platform/gtk/LocalizedStringsGtk.cpp:179 msgid "No Guesses Found" Another message that could need a tip for translators. 118725 2 elle.uca 2009-04-24 13:49:36 -0700 #: WebCore/platform/gtk/LocalizedStringsGtk.cpp:262 msgid "_Outline" Third message.... 119578 3 elle.uca 2009-05-01 02:12:11 -0700 Another stuff that could be good to clarify is the "minimum logical size" for fonts. It's explained here[1], but could be good add more info for translators and/or in gtk-doc stuff. http://developer.apple.com/documentation/Cocoa/Reference/WebKit/Classes/WebPreferences_Class/Reference/Reference.html 356138 4 83489 christian 2011-02-23 09:15:49 -0800 Created attachment 83489 Document font sizes, no guesses found and outline The search index string no longer exists. I documented the other items you mentioned and actually added gtk-doc comments for the minimum font size settings. 356155 5 83489 mrobinson 2011-02-23 09:45:21 -0800 Comment on attachment 83489 Document font sizes, no guesses found and outline View in context: https://bugs.webkit.org/attachment.cgi?id=83489&action=review > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:349 > + * The smallest font size used for display if a website doesn't correctly > + * define it, which can happen with <small> elements or percentages. I'm not sure that "doesn't correctly" is erm...correct here. It's not incorrect to use a logical font size. Perhaps something like this: The minimum font size used for elements which do not absolutely declare their font sizes. Examples of non-absolute font sizes are those that are defined with words such as "small" or "large" or those defined relative to other font sizes with words like "larger," "smaller" or a percentage. > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:356 > + // i18n: The smallest font size used for display if a website doesn't correctly > + // define it, which can happen with <small> elements or percentages. It seems redudant to have it both places. 362425 6 84727 christian 2011-03-04 05:07:02 -0800 Created attachment 84727 83489: Document font sizes, no guesses found and outline #2 (In reply to comment #5) > (From update of attachment 83489 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83489&action=review > > > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:349 > > + * The smallest font size used for display if a website doesn't correctly > > + * define it, which can happen with <small> elements or percentages. > > I'm not sure that "doesn't correctly" is erm...correct here. It's not incorrect to use a logical font size. Perhaps something like this: > > The minimum font size used for elements which do not absolutely declare their font sizes. > Examples of non-absolute font sizes are those that are defined with words such as "small" > or "large" or those defined relative to other font sizes with words like "larger," "smaller" or a percentage. Updated it: The smallest font size used for display for elements which don't absolutely declare their font sizes. Examples of that are "small", "smaller" or percentages. I'm trying to keep it consise and focus on visual effect here. The examples are obvious enough to anyone who knows CSS. > > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:356 > > + // i18n: The smallest font size used for display if a website doesn't correctly > > + // define it, which can happen with <small> elements or percentages. > > It seems redudant to have it both places. It isn't. Translators don't read developer documentation. Many don't event test what they translate. 392869 7 84727 mrobinson 2011-04-26 15:47:19 -0700 Comment on attachment 84727 83489: Document font sizes, no guesses found and outline #2 View in context: https://bugs.webkit.org/attachment.cgi?id=84727&action=review Looks good, but please fix the remaining issues when landing. > Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:239 > + // i18n: Context menu item, if spell checking found no correction suggestions Please add a period to this sentence when landing. > Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:323 > + // i18n: Unused, font markup menu item Please complete this sentence and add a period. 423237 8 eric 2011-06-18 13:40:19 -0700 Attachment 84727 was posted by a committer and has review+, assigning to Christian Dywan for commit. 800000 9 eric 2013-01-04 00:50:24 -0800 I don't think this was ever landed. 83489 2011-02-23 09:15:49 -0800 2011-03-04 05:07:02 -0800 Document font sizes, no guesses found and outline 0001-Add-translator-comment-to-translatable-message-s.diff text/plain 4646 christian RnJvbSA4MWY0MGEzYzg5Nzg5Y2RhNGMyMmJmMmZiNGUxOGZiNjAyNWJhY2U5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRHl3YW4gPGNocmlzdGlhbkB0d290b2FzdHMu ZGU+CkRhdGU6IFdlZCwgMjMgRmViIDIwMTEgMTg6MTQ6MzQgKzAxMDAKU3ViamVjdDogW1BBVENI XSBBZGQgdHJhbnNsYXRvciBjb21tZW50IHRvIHRyYW5zbGF0YWJsZSBtZXNzYWdlKHMpCiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjUzNzUKClJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKU291cmNlL1dlYkNvcmU6CgoqIHBsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRT dHJpbmdzR3RrLmNwcDogQWRkIGNvbW1lbnRzIGZvciB0cmFuc2xhdG9ycwogICAgYWJvdXQgJ05v IGd1ZXNzZXMgZm91bmQnIGFuZCAnT3V0bGluZScuCgpTb3VyY2UvV2ViS2l0L2d0azoKCiogd2Vi a2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcDogRG9jdW1lbnQgbWluaW11bSBmb250IHNpemUgcHJv cGVydGllcwogICAgYW5kIGFkZCBhIGNvbW1lbnQgZm9yIHRyYW5zbGF0b3JzLgotLS0KIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMCArKysr KysrKysrCiAuLi4vV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHAg ICB8ICAgIDIgKysKIFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxMCArKysrKysrKysrCiBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vic2V0dGluZ3MuY3BwICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdl ZCwgMzYgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMxODRj ZS4uMDU4MzFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAyLTIzICBDaHJp c3RpYW4gRHl3YW4gIDxjaHJpc3RpYW5AbGFuZWRvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdHJhbnNsYXRvciBjb21tZW50IHRvIHRy YW5zbGF0YWJsZSBtZXNzYWdlKHMpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNTM3NQorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0 cmluZ3NHdGsuY3BwOiBBZGQgY29tbWVudHMgZm9yIHRyYW5zbGF0b3JzCisgICAgICAgICAgICBh Ym91dCAnTm8gZ3Vlc3NlcyBmb3VuZCcgYW5kICdPdXRsaW5lJy4KKwogMjAxMS0wMi0yMiAgU3Rl dmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6 ZWRTdHJpbmdzR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRT dHJpbmdzR3RrLmNwcAppbmRleCAxYmY5YTQ0Li5iNDA5NTkzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwCkBAIC0yMzYsNiAr MjM2LDcgQEAgU3RyaW5nIGNvbnRleHRNZW51SXRlbVRhZ1Bhc3RlKCkKIAogU3RyaW5nIGNvbnRl eHRNZW51SXRlbVRhZ05vR3Vlc3Nlc0ZvdW5kKCkKIHsKKyAgICAvLyBpMThuOiBDb250ZXh0IG1l bnUgaXRlbSwgaWYgc3BlbGwgY2hlY2tpbmcgZm91bmQgbm8gY29ycmVjdGlvbiBzdWdnZXN0aW9u cwogICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KF8oIk5vIEd1ZXNzZXMgRm91bmQiKSk7CiB9 CiAKQEAgLTMxOSw2ICszMjAsNyBAQCBTdHJpbmcgY29udGV4dE1lbnVJdGVtVGFnVW5kZXJsaW5l KCkKIAogU3RyaW5nIGNvbnRleHRNZW51SXRlbVRhZ091dGxpbmUoKQogeworICAgIC8vIGkxOG46 IFVudXNlZCwgZm9udCBtYXJrdXAgbWVudSBpdGVtCiAgICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVU RjgoXygiX091dGxpbmUiKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCAzNzBkMWZlLi5kMzAy ZTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMjMgIENocmlz dGlhbiBEeXdhbiAgPGNocmlzdGlhbkBsYW5lZG8uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0cmFuc2xhdG9yIGNvbW1lbnQgdG8gdHJh bnNsYXRhYmxlIG1lc3NhZ2UocykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI1Mzc1CisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vic2V0dGluZ3Mu Y3BwOiBEb2N1bWVudCBtaW5pbXVtIGZvbnQgc2l6ZSBwcm9wZXJ0aWVzCisgICAgICAgICAgICBh bmQgYWRkIGEgY29tbWVudCBmb3IgdHJhbnNsYXRvcnMuCisKIDIwMTEtMDItMjEgIEFsZWphbmRy byBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFu IExvcGV6LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNl dHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5j cHAKaW5kZXggZDA5ODEwMy4uOWM5OGFhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCkBAIC0zMjcsNiArMzI3LDEyIEBAIHN0YXRpYyB2b2lk IHdlYmtpdF93ZWJfc2V0dGluZ3NfY2xhc3NfaW5pdChXZWJLaXRXZWJTZXR0aW5nc0NsYXNzKiBr bGFzcykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDUsIEdfTUFYSU5ULCAx MCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsYWdzKSk7CiAKKyAgICAv KioKKyAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczptaW5pbXVtLWZvbnQtc2l6ZToKKyAgICAgKgor ICAgICAqIFRoZSBzbWFsbGVzdCBmb250IHNpemUgdXNlZCBmb3IgZGlzcGxheSwgcmVnYXJkbGVz cyBvZiB0aGUgc2l6ZSBzcGVjaWZpZWQKKyAgICAgKiBieSBhIHdlYnNpdGUuCisgICAgICovCiAg ICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnb2JqZWN0X2NsYXNzLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUFJPUF9NSU5JTVVNX0ZPTlRfU0laRSwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdfcGFyYW1fc3BlY19pbnQoCkBAIC0z MzYsMTAgKzM0MiwxOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2NsYXNzX2lu aXQoV2ViS2l0V2ViU2V0dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAwLCBHX01BWElOVCwgNSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZsYWdzKSk7CiAKKyAgICAvKioKKyAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczpt aW5pbXVtLWxvZ2ljYWwtZm9udC1zaXplOgorICAgICAqCisgICAgICogVGhlIHNtYWxsZXN0IGZv bnQgc2l6ZSB1c2VkIGZvciBkaXNwbGF5IGlmIGEgd2Vic2l0ZSBkb2Vzbid0IGNvcnJlY3RseQor ICAgICAqIGRlZmluZSBpdCwgd2hpY2ggY2FuIGhhcHBlbiB3aXRoIDxzbWFsbD4gZWxlbWVudHMg b3IgcGVyY2VudGFnZXMuCisgICAgICovCiAgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9w ZXJ0eShnb2JqZWN0X2NsYXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg UFJPUF9NSU5JTVVNX0xPR0lDQUxfRk9OVF9TSVpFLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZ19wYXJhbV9zcGVjX2ludCgKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJtaW5pbXVtLWxvZ2ljYWwtZm9udC1zaXplIiwKKyAgICAvLyBpMThuOiBUaGUg c21hbGxlc3QgZm9udCBzaXplIHVzZWQgZm9yIGRpc3BsYXkgaWYgYSB3ZWJzaXRlIGRvZXNuJ3Qg Y29ycmVjdGx5CisgICAgLy8gZGVmaW5lIGl0LCB3aGljaCBjYW4gaGFwcGVuIHdpdGggPHNtYWxs PiBlbGVtZW50cyBvciBwZXJjZW50YWdlcy4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIF8oIk1pbmltdW0gTG9naWNhbCBGb250IFNpemUiKSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIF8oIlRoZSBtaW5pbXVtIGxvZ2ljYWwgZm9udCBzaXplIHVzZWQg dG8gZGlzcGxheSB0ZXh0LiIpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg MSwgR19NQVhJTlQsIDUsCi0tIAoxLjcuMy41Cgo= 84727 2011-03-04 05:07:02 -0800 2011-04-26 15:47:19 -0700 83489: Document font sizes, no guesses found and outline #2 0001-Add-translator-comment-to-translatable-message-s.diff text/plain 4688 christian RnJvbSA4MWY0MGEzYzg5Nzg5Y2RhNGMyMmJmMmZiNGUxOGZiNjAyNWJhY2U5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRHl3YW4gPGNocmlzdGlhbkB0d290b2FzdHMu ZGU+CkRhdGU6IFdlZCwgMjMgRmViIDIwMTEgMTg6MTQ6MzQgKzAxMDAKU3ViamVjdDogW1BBVENI XSBBZGQgdHJhbnNsYXRvciBjb21tZW50IHRvIHRyYW5zbGF0YWJsZSBtZXNzYWdlKHMpCiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjUzNzUKClJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKU291cmNlL1dlYkNvcmU6CgoqIHBsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRT dHJpbmdzR3RrLmNwcDogQWRkIGNvbW1lbnRzIGZvciB0cmFuc2xhdG9ycwogICAgYWJvdXQgJ05v IGd1ZXNzZXMgZm91bmQnIGFuZCAnT3V0bGluZScuCgpTb3VyY2UvV2ViS2l0L2d0azoKCiogd2Vi a2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcDogRG9jdW1lbnQgbWluaW11bSBmb250IHNpemUgcHJv cGVydGllcwogICAgYW5kIGFkZCBhIGNvbW1lbnQgZm9yIHRyYW5zbGF0b3JzLgotLS0KIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMCArKysr KysrKysrCiAuLi4vV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHAg ICB8ICAgIDIgKysKIFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxMCArKysrKysrKysrCiBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vic2V0dGluZ3MuY3BwICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdl ZCwgMzYgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMxODRj ZS4uMDU4MzFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAyLTIzICBDaHJp c3RpYW4gRHl3YW4gIDxjaHJpc3RpYW5AbGFuZWRvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdHJhbnNsYXRvciBjb21tZW50IHRvIHRy YW5zbGF0YWJsZSBtZXNzYWdlKHMpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNTM3NQorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0 cmluZ3NHdGsuY3BwOiBBZGQgY29tbWVudHMgZm9yIHRyYW5zbGF0b3JzCisgICAgICAgICAgICBh Ym91dCAnTm8gZ3Vlc3NlcyBmb3VuZCcgYW5kICdPdXRsaW5lJy4KKwogMjAxMS0wMi0yMiAgU3Rl dmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6 ZWRTdHJpbmdzR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRT dHJpbmdzR3RrLmNwcAppbmRleCAxYmY5YTQ0Li5iNDA5NTkzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwCkBAIC0yMzYsNiAr MjM2LDcgQEAgU3RyaW5nIGNvbnRleHRNZW51SXRlbVRhZ1Bhc3RlKCkKIAogU3RyaW5nIGNvbnRl eHRNZW51SXRlbVRhZ05vR3Vlc3Nlc0ZvdW5kKCkKIHsKKyAgICAvLyBpMThuOiBDb250ZXh0IG1l bnUgaXRlbSwgaWYgc3BlbGwgY2hlY2tpbmcgZm91bmQgbm8gY29ycmVjdGlvbiBzdWdnZXN0aW9u cwogICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KF8oIk5vIEd1ZXNzZXMgRm91bmQiKSk7CiB9 CiAKQEAgLTMxOSw2ICszMjAsNyBAQCBTdHJpbmcgY29udGV4dE1lbnVJdGVtVGFnVW5kZXJsaW5l KCkKIAogU3RyaW5nIGNvbnRleHRNZW51SXRlbVRhZ091dGxpbmUoKQogeworICAgIC8vIGkxOG46 IFVudXNlZCwgZm9udCBtYXJrdXAgbWVudSBpdGVtCiAgICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVU RjgoXygiX091dGxpbmUiKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCAzNzBkMWZlLi5kMzAy ZTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMjMgIENocmlz dGlhbiBEeXdhbiAgPGNocmlzdGlhbkBsYW5lZG8uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0cmFuc2xhdG9yIGNvbW1lbnQgdG8gdHJh bnNsYXRhYmxlIG1lc3NhZ2UocykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI1Mzc1CisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vic2V0dGluZ3Mu Y3BwOiBEb2N1bWVudCBtaW5pbXVtIGZvbnQgc2l6ZSBwcm9wZXJ0aWVzCisgICAgICAgICAgICBh bmQgYWRkIGEgY29tbWVudCBmb3IgdHJhbnNsYXRvcnMuCisKIDIwMTEtMDItMjEgIEFsZWphbmRy byBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFu IExvcGV6LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNl dHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5j cHAKaW5kZXggZDA5ODEwMy4uOWM5OGFhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCkBAIC0zMjcsNiArMzI3LDEyIEBAIHN0YXRpYyB2b2lk IHdlYmtpdF93ZWJfc2V0dGluZ3NfY2xhc3NfaW5pdChXZWJLaXRXZWJTZXR0aW5nc0NsYXNzKiBr bGFzcykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDUsIEdfTUFYSU5ULCAx MCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsYWdzKSk7CiAKKyAgICAv KioKKyAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczptaW5pbXVtLWZvbnQtc2l6ZToKKyAgICAgKgor ICAgICAqIFRoZSBzbWFsbGVzdCBmb250IHNpemUgdXNlZCBmb3IgZGlzcGxheSwgcmVnYXJkbGVz cyBvZiB0aGUgc2l6ZSBzcGVjaWZpZWQKKyAgICAgKiBieSBhIHdlYnNpdGUuCisgICAgICovCiAg ICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnb2JqZWN0X2NsYXNzLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUFJPUF9NSU5JTVVNX0ZPTlRfU0laRSwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdfcGFyYW1fc3BlY19pbnQoCkBAIC0z MzYsMTAgKzM0MiwxOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2NsYXNzX2lu aXQoV2ViS2l0V2ViU2V0dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAwLCBHX01BWElOVCwgNSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZsYWdzKSk7CiAKKyAgICAvKioKKyAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczpt aW5pbXVtLWxvZ2ljYWwtZm9udC1zaXplOgorICAgICAqCisgICAgICogVGhlIHNtYWxsZXN0IGZv bnQgc2l6ZSB1c2VkIGZvciBkaXNwbGF5IGZvciBlbGVtZW50cyB3aGljaCBkb24ndCBhYnNvbHV0 ZWx5CisgICAgICogZGVjbGFyZSB0aGVpciBmb250IHNpemVzLiBFeGFtcGxlcyBvZiB0aGF0IGFy ZSAic21hbGwiLCAic21hbGxlciIgb3IgcGVyY2VudGFnZXMuCisgICAgICovCiAgICAgZ19vYmpl Y3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnb2JqZWN0X2NsYXNzLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgUFJPUF9NSU5JTVVNX0xPR0lDQUxfRk9OVF9TSVpFLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX2ludCgKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJtaW5pbXVtLWxvZ2ljYWwtZm9udC1zaXpl IiwKKyAgICAvLyBpMThuOiBUaGUgc21hbGxlc3QgZm9udCBzaXplIHVzZWQgZm9yIGRpc3BsYXkg Zm9yIGVsZW1lbnRzIHdoaWNoIGRvbid0IGFic29sdXRlbHkKKyAgICAvLyBkZWNsYXJlIHRoZWly IGZvbnQgc2l6ZXMuIEV4YW1wbGVzIG9mIHRoYXQgYXJlICJzbWFsbCIsICJzbWFsbGVyIiBvciBw ZXJjZW50YWdlcy4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIk1pbmlt dW0gTG9naWNhbCBGb250IFNpemUiKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF8oIlRoZSBtaW5pbXVtIGxvZ2ljYWwgZm9udCBzaXplIHVzZWQgdG8gZGlzcGxheSB0ZXh0 LiIpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMSwgR19NQVhJTlQsIDUs Ci0tIAoxLjcuMy41Cgo=