25373 2009-04-24 13:06:16 -0700 Popup menu has the wrong size when popped up near the edge of the screen 2009-04-25 11:13:14 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jobi webkit-unassigned enrico.troeger xan.lopez oldest_to_newest 118707 0 jobi 2009-04-24 13:06:16 -0700 When popping up the context menu with the pointer is near the edge of the screen, the menu has the wrong size (it's not offset to not be offscreen). See the attached illustration. 118708 1 29757 jobi 2009-04-24 13:06:46 -0700 Created attachment 29757 illustration 118710 2 29758 jobi 2009-04-24 13:14:14 -0700 Created attachment 29758 proposed patch 118715 3 29758 xan.lopez 2009-04-24 13:31:13 -0700 Comment on attachment 29758 proposed patch Looks good. I need you to generate a ChangeLog with WebKitTools/Scripts/prepare-ChangeLog though, and when you upload a patch put the review flag to '?' so it appears in the review queue. Marking as r- for now, thanks for the patch! 118720 4 29760 jobi 2009-04-24 13:44:58 -0700 Created attachment 29760 the same with a ChangeLog entry 118723 5 29760 xan.lopez 2009-04-24 13:47:45 -0700 Comment on attachment 29760 the same with a ChangeLog entry Great. I'll commit it ASAP. 118729 6 xan.lopez 2009-04-24 14:18:19 -0700 Landed as r42837, thanks. 118843 7 enrico.troeger 2009-04-25 11:13:14 -0700 *** Bug 24270 has been marked as a duplicate of this bug. *** 29757 2009-04-24 13:06:46 -0700 2009-04-24 13:06:46 -0700 illustration popup-menu-fail.png image/png 666 jobi iVBORw0KGgoAAAANSUhEUgAAAI4AAAAuCAYAAAD+4SHmAAAAAXNSR0IArs4c6QAAAAZiS0dEAP8A /wD/oL2nkwAAAAlwSFlzAAAOdQAADnUBuWNRMgAAAAd0SU1FB9kEFw8NMFmAJ30AAAAZdEVYdENv bW1lbnQAQ3JlYXRlZCB3aXRoIEdJTVBXgQ4XAAAB9UlEQVR42u2cMZKqQBBAe1YJEENKI8orcAAz i9xjeAESrPICJBzAE2jCFTzElDFlGVjMDSiLjdxN9v+F78rOh/diSbpfdff0IOp6vdbSktFoJD/N 5XKR/X4v2+1WgiAQsJs3QgCIA/aLo5QiegNm/Iw0X8lT1zXiIQ6VCJhx4Lcrzt/aUZOK07SdwYBa FVLQqgAQBxAHEAcQBxAHAHEAccAenrrkfNB26aeUkrquudcamjjfifSqZ4BWBYgDiAPQdNRo8y+H 1WpFxCzmfD7bOxzP53MyZCG3283+U9X9fidTHMehL2w2G8R56WCnlPi+L8aYXr2xuNvtEOeV0gRB INPpVDzPk6IoeiPPeNxdOt+GKo2IyGQykcViwRYbcb6XxvM8McZIURRSlqW4ros8XbSqro99P0lZ lmT8t8Rhj2Mn7HGAGQcQ578mDEMJw/Dp38DAxImiSOI4/qMYYRhKHMcSRRFGIM4nWZaJ1vpLeR7S aK0lyzKMQJxPqqqSNE0/5ImiSGaz2Ucl0lpLmqZSVRVGNKT1+zi+7xM1CzHGyOl0srfivOJTtV3i OI4kSSKHw0GSJBHHcbDuHxjcJeejba3Xa8nznPaEOO3kOR6PZJ/hGDqvOK7rEoWe0OW8Ns7znIj3 hC5zqZbLZePjuDGG7FhMl6uSd522m+q7VelsAAAAAElFTkSuQmCC 29758 2009-04-24 13:14:14 -0700 2009-04-24 13:44:58 -0700 proposed patch 0001-Bug-25373-Popup-menu-has-the-wrong-size-when-near-t.patch text/plain 1837 jobi RnJvbSAwYTkzNzYyZDQ1YjU0ZDE0NjI5YmJlMjM4YTkzM2M2Y2Y2YWNkMjVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2hhbiBCaWxpZW4gPGpvYmlAdmlhLmVjcC5mcj4KRGF0ZTog RnJpLCAyNCBBcHIgMjAwOSAyMToxMToyNCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEJ1ZyAyNTM3 MzogUG9wdXAgbWVudSBoYXMgdGhlIHdyb25nIHNpemUgd2hlbiBuZWFyIHRoZSBlZGdlCgpXZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDogbGV0IEdUSyBwb3NpdGlvbiB0aGUgcG9w dXAgbWVudQppbnN0ZWFkIG9mIHRyeWluZyBhbmQgZmFpbGluZyB0byBkbyBiZXR0ZXIuCi0tLQog V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgfCAgICA5ICstLS0tLS0tLQogMSBm aWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAxNTI0ZWJiLi40NDdlYWFjIDEwMDY0NAotLS0gYS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMTY4LDEzICsxNjgsNiBAQCBHX0RFRklORV9UWVBFKFdl YktpdFdlYlZpZXcsIHdlYmtpdF93ZWJfdmlldywgR1RLX1RZUEVfQ09OVEFJTkVSKQogc3RhdGlj IHZvaWQgd2Via2l0X3dlYl92aWV3X3NldHRpbmdzX25vdGlmeShXZWJLaXRXZWJTZXR0aW5ncyog d2ViU2V0dGluZ3MsIEdQYXJhbVNwZWMqIHBzcGVjLCBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KTsK IHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXRfd2luZG93X2ZlYXR1cmVzKFdlYktpdFdl YlZpZXcqIHdlYlZpZXcsIFdlYktpdFdlYldpbmRvd0ZlYXR1cmVzKiB3ZWJXaW5kb3dGZWF0dXJl cyk7CiAKLXN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jb250ZXh0X21lbnVfcG9zaXRpb25f ZnVuYyhHdGtNZW51KiwgZ2ludCogeCwgZ2ludCogeSwgZ2Jvb2xlYW4qIHB1c2hJbiwgV2ViS2l0 V2ViVmlld1ByaXZhdGUqIGRhdGEpCi17Ci0gICAgKnB1c2hJbiA9IEZBTFNFOwotICAgICp4ID0g ZGF0YS0+bGFzdFBvcHVwWFBvc2l0aW9uOwotICAgICp5ID0gZGF0YS0+bGFzdFBvcHVwWVBvc2l0 aW9uOwotfQotCiBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X2ZvcndhcmRfY29udGV4 dF9tZW51X2V2ZW50KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IFBsYXRmb3JtTW91c2VF dmVudCYgZXZlbnQpCiB7CiAgICAgUGFnZSogcGFnZSA9IGNvcmUod2ViVmlldyk7CkBAIC0yMDks NyArMjAyLDcgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19mb3J3YXJkX2NvbnRl eHRfbWVudV9ldmVudChXZWJLaXRXZWJWaWV3KiB3ZWJWaWUKICAgICBwcml2LT5sYXN0UG9wdXBY UG9zaXRpb24gPSBldmVudC5nbG9iYWxYKCk7CiAgICAgcHJpdi0+bGFzdFBvcHVwWVBvc2l0aW9u ID0gZXZlbnQuZ2xvYmFsWSgpOwogICAgIGd0a19tZW51X3BvcHVwKG1lbnUsIE5VTEwsIE5VTEws Ci0gICAgICAgICAgICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxHdGtNZW51UG9zaXRpb25GdW5j Pih3ZWJraXRfd2ViX3ZpZXdfY29udGV4dF9tZW51X3Bvc2l0aW9uX2Z1bmMpLAorICAgICAgICAg ICAgICAgICAgIE5VTEwsCiAgICAgICAgICAgICAgICAgICAgcHJpdiwgZXZlbnQuYnV0dG9uKCkg KyAxLCBndGtfZ2V0X2N1cnJlbnRfZXZlbnRfdGltZSgpKTsKICAgICByZXR1cm4gVFJVRTsKIH0K LS0gCjEuNi4yLjQKCg== 29760 2009-04-24 13:44:58 -0700 2009-04-24 13:47:45 -0700 the same with a ChangeLog entry 0001-Popup-menu-has-the-wrong-size-when-popped-up-near-th.patch text/plain 2843 jobi RnJvbSA3MmZhM2E0YzA0Yjg3ZjViMWNjMjEwNWEwNTZmZDczOGNiNDg3ZjYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2hhbiBCaWxpZW4gPGpvYmlAdmlhLmVjcC5mcj4KRGF0ZTog RnJpLCAyNCBBcHIgMjAwOSAyMTo0MDo0OSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFBvcHVwIG1l bnUgaGFzIHRoZSB3cm9uZyBzaXplIHdoZW4gcG9wcGVkIHVwIG5lYXIgdGhlIGVkZ2Ugb2YgdGhl IHNjcmVlbgoKMjAwOS0wNC0yNCAgSm9oYW4gQmlsaWVuICA8am9iaUB2aWEuZWNwLmZyPgoKICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MzczCiAgICAgICAgUG9wdXAgbWVudSBoYXMgdGhl IHdyb25nIHNpemUgd2hlbiBwb3BwZWQgdXAgbmVhciB0aGUgZWRnZQogICAgICAgIG9mIHRoZSBz Y3JlZW4KCiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CiAgICAgICAgKHdlYmtp dF93ZWJfdmlld19mb3J3YXJkX2NvbnRleHRfbWVudV9ldmVudCk6IExldCBHVEsgcGxhY2UKICAg ICAgICB0aGUgcG9wdXAgbWVudSBpbnN0ZWFkIG9mIHRyeWluZyB0byBkbyBiZXR0ZXIgYW5kIGZh aWxpbmcKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8ICAgMTIgKysr KysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAgIDkgKy0t LS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxv ZwppbmRleCAxYjlkOGRjLi4yMWVhMjdiIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTA0LTI0 ICBKb2hhbiBCaWxpZW4gIDxqb2JpQHZpYS5lY3AuZnI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI1MzczCisgICAgICAgIFBvcHVwIG1lbnUgaGFzIHRoZSB3cm9uZyBzaXplIHdo ZW4gcG9wcGVkIHVwIG5lYXIgdGhlIGVkZ2UKKyAgICAgICAgb2YgdGhlIHNjcmVlbgorCQorICAg ICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmll d19mb3J3YXJkX2NvbnRleHRfbWVudV9ldmVudCk6IExldCBHVEsgcGxhY2UKKyAgICAgICAgdGhl IHBvcHVwIG1lbnUgaW5zdGVhZCBvZiB0cnlpbmcgdG8gZG8gYmV0dGVyIGFuZCBmYWlsaW5nCisK IDIwMDktMDQtMjEgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAK aW5kZXggMTUyNGViYi4uNDQ3ZWFhYyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAK QEAgLTE2OCwxMyArMTY4LDYgQEAgR19ERUZJTkVfVFlQRShXZWJLaXRXZWJWaWV3LCB3ZWJraXRf d2ViX3ZpZXcsIEdUS19UWVBFX0NPTlRBSU5FUikKIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmll d19zZXR0aW5nc19ub3RpZnkoV2ViS2l0V2ViU2V0dGluZ3MqIHdlYlNldHRpbmdzLCBHUGFyYW1T cGVjKiBwc3BlYywgV2ViS2l0V2ViVmlldyogd2ViVmlldyk7CiBzdGF0aWMgdm9pZCB3ZWJraXRf d2ViX3ZpZXdfc2V0X3dpbmRvd19mZWF0dXJlcyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJL aXRXZWJXaW5kb3dGZWF0dXJlcyogd2ViV2luZG93RmVhdHVyZXMpOwogCi1zdGF0aWMgdm9pZCB3 ZWJraXRfd2ViX3ZpZXdfY29udGV4dF9tZW51X3Bvc2l0aW9uX2Z1bmMoR3RrTWVudSosIGdpbnQq IHgsIGdpbnQqIHksIGdib29sZWFuKiBwdXNoSW4sIFdlYktpdFdlYlZpZXdQcml2YXRlKiBkYXRh KQotewotICAgICpwdXNoSW4gPSBGQUxTRTsKLSAgICAqeCA9IGRhdGEtPmxhc3RQb3B1cFhQb3Np dGlvbjsKLSAgICAqeSA9IGRhdGEtPmxhc3RQb3B1cFlQb3NpdGlvbjsKLX0KLQogc3RhdGljIGdi b29sZWFuIHdlYmtpdF93ZWJfdmlld19mb3J3YXJkX2NvbnRleHRfbWVudV9ldmVudChXZWJLaXRX ZWJWaWV3KiB3ZWJWaWV3LCBjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmIGV2ZW50KQogewogICAg IFBhZ2UqIHBhZ2UgPSBjb3JlKHdlYlZpZXcpOwpAQCAtMjA5LDcgKzIwMiw3IEBAIHN0YXRpYyBn Ym9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfZm9yd2FyZF9jb250ZXh0X21lbnVfZXZlbnQoV2ViS2l0 V2ViVmlldyogd2ViVmllCiAgICAgcHJpdi0+bGFzdFBvcHVwWFBvc2l0aW9uID0gZXZlbnQuZ2xv YmFsWCgpOwogICAgIHByaXYtPmxhc3RQb3B1cFlQb3NpdGlvbiA9IGV2ZW50Lmdsb2JhbFkoKTsK ICAgICBndGtfbWVudV9wb3B1cChtZW51LCBOVUxMLCBOVUxMLAotICAgICAgICAgICAgICAgICAg IHJlaW50ZXJwcmV0X2Nhc3Q8R3RrTWVudVBvc2l0aW9uRnVuYz4od2Via2l0X3dlYl92aWV3X2Nv bnRleHRfbWVudV9wb3NpdGlvbl9mdW5jKSwKKyAgICAgICAgICAgICAgICAgICBOVUxMLAogICAg ICAgICAgICAgICAgICAgIHByaXYsIGV2ZW50LmJ1dHRvbigpICsgMSwgZ3RrX2dldF9jdXJyZW50 X2V2ZW50X3RpbWUoKSk7CiAgICAgcmV0dXJuIFRSVUU7CiB9Ci0tIAoxLjYuMi40Cgo=