253706 2023-03-10 08:08:24 -0800 RenderLayer::hasVisibleContent() incorrect when layer removed 2023-03-29 12:34:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED BrowserCompat, InRadar P2 Normal --- 1 ahmad.saleem792 ahmad.saleem792 bfulgham karlcow koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1940385 0 ahmad.saleem792 2023-03-10 08:08:24 -0800 Hi Team, While going through Blink's commit, I came across another failing test case: Test case - https://jsfiddle.net/b7kwpvx8/1/ ^ Safari Technology Preview 164 show 'Red' while Chrome Canary 113 and Firefox Nightly 112 show 'Green'. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/c5587982b1ed1ec62452f5d2c93c0f385a3941a1 WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderLayer.cpp#459 Below this WebKit source, in local testing when I add following: if (renderer().style().visibility() != Visibility::Visible) dirtyVisibleContentStatus(); _________ It fixes this bug and show 'Green' similar to other browsers. Appreciate if someone can share input and I am happy to do PR. Thanks! 1942110 1 webkit-bug-importer 2023-03-17 09:09:15 -0700 <rdar://problem/106860749> 1944111 2 karlcow 2023-03-26 20:59:03 -0700 That looks like a low hanging fruit. 1944113 3 zalan 2023-03-26 21:15:41 -0700 Indeed. diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp index db8ca3df7421..432a841c61e8 100644 --- a/Source/WebCore/rendering/RenderLayer.cpp +++ b/Source/WebCore/rendering/RenderLayer.cpp @@ -475,6 +475,8 @@ void RenderLayer::removeChild(RenderLayer& oldChild) if (oldChild.hasBlendMode() || (oldChild.hasNotIsolatedBlendingDescendants() && !oldChild.isolatesBlending())) dirtyAncestorChainHasBlendingDescendants(); #endif + if (renderer().style().visibility() != Visibility::Visible) + dirtyVisibleContentStatus(); } void RenderLayer::dirtyPaintOrderListsOnChildChange(RenderLayer& child) shows green. 1944229 4 ahmad.saleem792 2023-03-27 07:41:04 -0700 (In reply to zalan from comment #3) > Indeed. > diff --git a/Source/WebCore/rendering/RenderLayer.cpp > b/Source/WebCore/rendering/RenderLayer.cpp > index db8ca3df7421..432a841c61e8 100644 > --- a/Source/WebCore/rendering/RenderLayer.cpp > +++ b/Source/WebCore/rendering/RenderLayer.cpp > @@ -475,6 +475,8 @@ void RenderLayer::removeChild(RenderLayer& oldChild) > if (oldChild.hasBlendMode() || > (oldChild.hasNotIsolatedBlendingDescendants() && > !oldChild.isolatesBlending())) > dirtyAncestorChainHasBlendingDescendants(); > #endif > + if (renderer().style().visibility() != Visibility::Visible) > + dirtyVisibleContentStatus(); > } > > void RenderLayer::dirtyPaintOrderListsOnChildChange(RenderLayer& child) > > shows green. Running through EWS - https://github.com/WebKit/WebKit/pull/12005 Let's see. 1945047 5 ahmad.saleem792 2023-03-29 10:53:48 -0700 PR - https://github.com/WebKit/WebKit/pull/12005 1945070 6 ews-feeder 2023-03-29 12:34:13 -0700 Committed 262284@main (059e2bb75dc3): <https://commits.webkit.org/262284@main> Reviewed commits have been landed. Closing PR #12005 and removing active labels.